From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AC2C27C76 for ; Wed, 25 Jan 2023 21:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D2AB6B0071; Wed, 25 Jan 2023 16:55:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 982676B0073; Wed, 25 Jan 2023 16:55:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 822FD6B0074; Wed, 25 Jan 2023 16:55:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 721916B0071 for ; Wed, 25 Jan 2023 16:55:29 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 45FDB160251 for ; Wed, 25 Jan 2023 21:55:29 +0000 (UTC) X-FDA: 80394678378.24.27E2FAA Received: from fx405.security-mail.net (smtpout140.security-mail.net [85.31.212.145]) by imf17.hostedemail.com (Postfix) with ESMTP id CF39C40005 for ; Wed, 25 Jan 2023 21:55:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kalray.eu header.s=sec-sig-email header.b=R24zqPFV; dkim=pass header.d=kalray.eu header.s=32AE1B44-9502-11E5-BA35-3734643DEF29 header.b=FiSVH+wq; dmarc=pass (policy=quarantine) header.from=kalray.eu; spf=pass (imf17.hostedemail.com: domain of jmaselbas@kalray.eu designates 85.31.212.145 as permitted sender) smtp.mailfrom=jmaselbas@kalray.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674683726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OP2H0clmfjMlntXGEQUOupSQETmz7iibW86xdOXdO/c=; b=p+5PDJZBaFmFQmfC4aJLEOYLVzlCWywNMLM2lellpYGlJehNn/wWtD42HIQDfP7rio6+oc TnZgJx7BXFzP88uOCPSW6s+rx7x/591r/ffptuDwHPDQYa1eNeRQlpSoVM5SPoGYsZ7I84 M+p38l5dO4zGzMXSQ53+bbkr3P6vRAg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kalray.eu header.s=sec-sig-email header.b=R24zqPFV; dkim=pass header.d=kalray.eu header.s=32AE1B44-9502-11E5-BA35-3734643DEF29 header.b=FiSVH+wq; dmarc=pass (policy=quarantine) header.from=kalray.eu; spf=pass (imf17.hostedemail.com: domain of jmaselbas@kalray.eu designates 85.31.212.145 as permitted sender) smtp.mailfrom=jmaselbas@kalray.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674683726; a=rsa-sha256; cv=none; b=bfCQcF2M+oEODzmYJPOfT6Wb2EEaEMtgWC2xNNTppS7+f/EbsA4L3oGXG4Z7z1tIdlUqzz v5UcKj9n+6Nxal5tDJ7PHGyN2EcSGcemEPyANBPiMWBb3DixeFG3ficLXgRmNqX9LLgXsx dDFiZ28N/JVuhPZcGJur+IlnJ61sOj0= Received: from localhost (fx405.security-mail.net [127.0.0.1]) by fx405.security-mail.net (Postfix) with ESMTP id 957CA335E52 for ; Wed, 25 Jan 2023 22:55:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kalray.eu; s=sec-sig-email; t=1674683723; bh=WtoB9JtlKwd4Y8mogATd1m73eAkNffWMtzkgdcOdrFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=R24zqPFVwlJyEATOT1tu/iX7ietNJvIVvv7K7gqBOtn9jLrOTH8pteeRCZC1lCRAg 3NNKmyaLawif3kimkn+2sMZ/YTLBkjZ7pNtvQcfEvkvqACBNFbEtQopp5pmYYJNpJ1 RKgkwdhP+5VL9HTiu8SKp6QGRQzKa6sZnvRN5JgM= Received: from fx405 (fx405.security-mail.net [127.0.0.1]) by fx405.security-mail.net (Postfix) with ESMTP id 643CB335CFD; Wed, 25 Jan 2023 22:55:22 +0100 (CET) Received: from zimbra2.kalray.eu (unknown [217.181.231.53]) by fx405.security-mail.net (Postfix) with ESMTPS id 4E24D335C78; Wed, 25 Jan 2023 22:55:21 +0100 (CET) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTPS id 0BE4B27E0491; Wed, 25 Jan 2023 22:55:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id CBFDF27E0492; Wed, 25 Jan 2023 22:55:20 +0100 (CET) Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S_SO1U8LWSyE; Wed, 25 Jan 2023 22:55:20 +0100 (CET) Received: from tellis.lin.mbt.kalray.eu (unknown [192.168.36.206]) by zimbra2.kalray.eu (Postfix) with ESMTPSA id 4AA5127E0461; Wed, 25 Jan 2023 22:55:20 +0100 (CET) X-Virus-Scanned: E-securemail Secumail-id: <50de.63d1a549.4c368.0> DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu CBFDF27E0492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalray.eu; s=32AE1B44-9502-11E5-BA35-3734643DEF29; t=1674683720; bh=OP2H0clmfjMlntXGEQUOupSQETmz7iibW86xdOXdO/c=; h=Date:From:To:Message-ID:MIME-Version; b=FiSVH+wqDIs88qUIullcsu5BFjd2D7z2E5u8DrTYSpKgGNXgRV/wZx6pLf0jEnjj1 nq174SqV22wtEYt+DC4eOS10NI0yUL2JmwTj2bfQCvZEO4mxAawGM/7zjbG/MQC8HR kpFf4zpnPjbRuo+I0TP0j3cj6aN2Vd984BCzoL6c= Date: Wed, 25 Jan 2023 22:55:19 +0100 From: Jules Maselbas To: "Jason A. Donenfeld" Cc: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guillaume Thouvenin , Clement Leger , Vincent Chardon , Marc =?utf-8?b?UG91bGhpw6hz?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan , Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [RFC PATCH v2 12/31] kvx: Add other common headers Message-ID: <20230125215519.GE5952@tellis.lin.mbt.kalray.eu> References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-13-ysionneau@kalray.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ALTERMIMEV2_out: done X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CF39C40005 X-Stat-Signature: am9o15g5xce6uhggky5ro3ui7b9kj45n X-HE-Tag: 1674683725-223237 X-HE-Meta: U2FsdGVkX1/sGp5TX+c6ZaLDH5oPle3tJilgM+7VVnVAdFx9OSVbHxifV5WIpc+oWmMroujDzVaGu0wQBXbqEKS3TmY8LhLWniNYYpiFUV59NKF2vzx5YW34pj85eGPJddN0c1qfU8T3BbqfcK+RfuP1kaMcAUpy4vCP9PFM/wD1NMUvbH3t1jAMG9K3kQfYoQFyamY/XeQlRhfCEj+E+TNvuwFW/80h1BSrZkM23YWo/3CM3yTcBZ9VxfFQpBFycGOIPViEbIrt/PclT+wWnQnfaNMVoeoBG4VJwl/MF1yfn64l/2JOS9ulkewIeCFG5/3yw4phzdj+4B94zRjdz7tKAzbIcPvH++goFCZ5snXREQYm0s+wzdjP9Ko+YeowUttV5tQxG5ztWhTI1XtGxFfmzOoF+o/Y5gW+/gOcIiZypuQgAdEiwcyGhA3FfofuNoGAIwvBAof9yYGTxWqSAeFJEEQLAU+m4xk8/OgsU+SbmCrwJUwrQFNmhFoTsR43AraorDhe15+87ThJee4l8Su0RAsrhJlMV+a6Sdlnu+PDEoLbHyOWcVpcw4s3DEt1eRoJOUK9VCITkA8BAhPlr9N00b93RizarDTedf+MhBNcODTBj3BiidWS8/Y5ELEnu/hgCuK+1DDmoDpLSWVPnGSjWsSO3nNMAI+KMkhj/+1kNB/gNLIHfUKtOjnMyfLrqhxMV5hWBr1XEiurLE7OgyE8wCUzRnM+6+l0j4C8ehZy9PPfEPoY9PQFy4iOKtDtgLiHea1JV3U7Tnqt7kDGILHbfbiik0nvOvHOrNNg+iIQ+EayPtuKPg82UnEMIACZESsN6ZQ0RWQsVx0qBtMhWcKixsemhzlvqErR6k78UVI0vVov6XNkVpkKnItiDMsRCV9ugd7NDfsrrOXKV1kW+T5fuWdzMrs9t2+v1vbjR3nDBqGjRz9vUmMJ3dlm+cbvkkXhh2aAhxMuWPppaKm PCpIVpOQ p9U7qn5mF/hxO4RbkBSyE0YSBGOKOcuFjwpUXENVJposDooRI6PVIcNSeCF5eJmwdbbNl87VGAawUMJYiP1dqeq/6fCIwKqXeqxB86PuwAkaQHUZhlRxxt5D/jSTnAJOojcuYnONT8urj/IalwhhX8+nLHoH0MWtznkt2v2xzgtw02fxda9JkcQjbwnI+R2HcN7kUIVMvDUJeAKChTuDIMsHMKslPje3mSRkAPvWPpBwpN6YnJm2CdLCwdsU8mi4O90PfFCveDrvx8TEbZ5yn95VoZBnZmWCkEf8QS8uxOthfldPCdFhIFU5Z65ZoQyLHAu0tTiMJXNjFGT5RO7QSURq70QvCoLjMwNIHHKX7kQ5UNf20eA8cObq9RY8N3hAKl9FrYAXKcQF35tWx59VwvFBYNDdpzYmgZpohkYxMT2PLM5PjC/5Hwb8WQ6TQIUPfBKxwiPj8zxdlsz+1phgYH1lE6VOP1Ug2pLEMiXNcZrH7M1c/pNU/IExVocuZvWn9sVGo721/qbQqHaUOtOOYchH5lg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jason, On Fri, Jan 20, 2023 at 03:29:14PM +0100, Jason A. Donenfeld wrote: > Hi Yann, > > On Fri, Jan 20, 2023 at 03:09:43PM +0100, Yann Sionneau wrote: > > +#include > > +#include > > + > > +extern unsigned long __stack_chk_guard; > > + > > +/* > > + * Initialize the stackprotector canary value. > > + * > > + * NOTE: this must only be called from functions that never return, > > + * and it must always be inlined. > > + */ > > +static __always_inline void boot_init_stack_canary(void) > > +{ > > + unsigned long canary; > > + > > + /* Try to get a semi random initial value. */ > > + get_random_bytes(&canary, sizeof(canary)); > > + canary ^= LINUX_VERSION_CODE; > > + canary &= CANARY_MASK; > > + > > + current->stack_canary = canary; > > + __stack_chk_guard = current->stack_canary; > > +} > > > You should rewrite this as: > > current->stack_canary = get_random_canary(); > __stack_chk_guard = current->stack_canary; > > which is what the other archs all now do. (They didn't used to, and this > looks like it's simply based on older code.) Thanks for the suggestion, this will be into v3 > > +#define get_cycles get_cycles > > + > > +#include > > +#include > > + > > +static inline cycles_t get_cycles(void) > > +{ > > + return kvx_sfr_get(PM0); > > +} > > Glad to see this CPU has a cycle counter. Out of curiosity, what is > its resolution? This cpu has 4 performance monitor (PM), the first one is reserved to count cycles, and it is cycle accurate. > Also, related, does this CPU happen to have a "RDRAND"-like instruction? I didn't knew about the RDRAND insruction, but no this CPU do not have an instruction like that. > (I don't know anything about kvx or even what it is.) It's a VLIW core, a bit like Itanium, there are currently not publicly available documentation. We have started a discussion internally at Kalray to share more information regarding this CPU and its ABI. A very crude instruction listing can be found in our fork of gdb-binutils: https://raw.githubusercontent.com/kalray/binutils/binutils-2_35_2/coolidge/opcodes/kv3-opc.c Best regards, -- Jules