From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15899C54E94 for ; Wed, 25 Jan 2023 12:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 749A26B0071; Wed, 25 Jan 2023 07:55:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FA036B0072; Wed, 25 Jan 2023 07:55:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C22C6B0073; Wed, 25 Jan 2023 07:55:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 49F3D6B0071 for ; Wed, 25 Jan 2023 07:55:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0CA9F120D8E for ; Wed, 25 Jan 2023 12:55:16 +0000 (UTC) X-FDA: 80393317032.10.10A17AB Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf14.hostedemail.com (Postfix) with ESMTP id A137F10000F for ; Wed, 25 Jan 2023 12:55:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HCywxhwj; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674651314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nBwiK9G8UOJJJlf5ylbe/nEUMVB1/OWE4ZuYAtvucuQ=; b=6FUAYTL7BsHbS04FXkbAlVu0+ZT1BurZNmAV4hTrmpF9HDcoa5FpvxhhU0IFUCqldrMsyK Nyich/fNITlaokG36Ng996kCOvl9V+Cdil2iBy6XmGQjIAlqJkq2HA2Ypu97PQrfhTKB1M V9NduQYdB+b6kggr4qXgODHdT6/Um1M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HCywxhwj; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674651314; a=rsa-sha256; cv=none; b=w4Ms0EbvzRIuobCl87a+vIAjCnggCJH4EPzz8fsQX3BXaT6XUzlAyQVZcPqjxCY1C/Sa8a qAecqD8d39E/8zVywPluctmu2quH8FbmLiwP9jL8UdL87jwj3cJ7h+dNZUFxMeL4FVfrlm /Lr3q9/thRfGqMtNOe1OY9pxLbBpm4g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674651312; x=1706187312; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MDLw4SI9AuliqMuFsm+CU5yI64+eZZfEdC5qdusTYOc=; b=HCywxhwjEJUQErVgnHpw2ivJUW+m8MbAbaxko+e3J+1WBIKqdMfcwWaL Zol3kj4dDVzu4XnBwZMwQymKuxKgRetsAQ7j60hmVTV2JXH1Y8MNjB/aW 7NrSWtK0k802l56sZThFtY8Q7Jf5wVNXUd0eRN137gSYSZqaKKvfSTDYV 1j/M10VM3+C6ljsOL8x4vMblYzTUjykDz2FoQvGiA1W7nU76xiBZQ1+zG vSDPa7k8Oq6UigWGkB46g+ky5tALWgHZdFMnccPPx3C42+Cyb3Sm5wwIn /UL9vd0FYTYpvxW64OR2moamjF+oHUadNSrZnESy2cSuN3j4NKzqk9oz8 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="306209622" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="306209622" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 04:55:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="751180484" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="751180484" Received: from lkp-server01.sh.intel.com (HELO 5646d64e7320) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jan 2023 04:55:07 -0800 Received: from kbuild by 5646d64e7320 with local (Exim 4.96) (envelope-from ) id 1pKfIx-0007JE-0c; Wed, 25 Jan 2023 12:55:07 +0000 Date: Wed, 25 Jan 2023 20:54:40 +0800 From: kernel test robot To: Zach O'Keefe , linux-mm@kvack.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Hugh Dickins , Yang Shi , Zach O'Keefe , stable@vger.kernel.org Subject: Re: [PATCH 2/2] mm/MADV_COLLAPSE: catch !none !huge !bad pmd lookups Message-ID: <202301252033.HoFIRXm4-lkp@intel.com> References: <20230125015738.912924-2-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125015738.912924-2-zokeefe@google.com> X-Rspamd-Queue-Id: A137F10000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: rpq4i4s9pdh7ybxq8hz7jjm91feiy8kh X-HE-Tag: 1674651312-741069 X-HE-Meta: U2FsdGVkX1+ynyQV3KIwO8OZZapp4RLRGWF+VjtkNUfXANynAeaYAiY7ewronYxsdTZ2kxKj4SN78R3iWNxMiccdy6rSfpOWVTciZ87O7YQom+Bsqw4Jf2JsfCcDvLYjbhmzRuk5ECyw+PMT3giSrspFmGzSPMctaXAHNL/F+eUVSqqMReq6bEfHvCN8BS93a2gzzNU8mnBv+DH1vcD0x8/M8XVzLtvE+ZYg5J7YioeeszohKLB2TTUcp4yowEGZpqIJvxYtz/I8gh3XcjDcK2AGIE+Nxfbb0k09nDzKbeOXgwtHpp2aglkBpSXU5gQ73FGYCnFzKxz23uFA4XM5mv00EVkQwxi9QcqknwYe2qlcsWl+M1Qg39/h0WQZjCLSEPOYZjRjGHKFl0Ei5qyUJAHiLojS3gUpYbWlCTSfnrNvd8/4KC2j9sVr0QuKr5m8ZMc0eVmUq6xaB/vlD5hnlpCXlHU7EnaVsi6DG0OPnHhBy2Be6XgEz0lux8fpf9En90EWIPkJaJsyuxdQMYm7nFqvwOi++DSSzyDej9Rr31sEKmiWenLEERaZUoxO8Dz36DzB2I+62OULrLnfN2XCbKXbi+b2DnwQoY9ukNhr6shfBbG5Ij67cg5blrGiRcyDwUgh8eu3cWgqrWn+F3nvDQox2r9kdPaTXM+fw6goR9yonUWLAOJXng1Gps99057R3Q8UGiPR3wvH+RchGtl5peykpMLlr8fkGwzDnR6b82g1bsSM5N323uUm1FxluPsVg7XkdBoeu9bvxRXfYYfygY6JJzKZqb6w58m/BMFNcU1Kz0ymhetieBwD7OWhWSISDB6EHC8PddTzXHYfyvnakCBc/wLX4rW0Kd7MFVRfFutVbUZUaYooD92j+m3tCtfaNJDzVcVD+1+XiBoMdQOQ/mHlrka5sbfxt/vE3ABa35GbS++7NHSNnweL1pLDPpbH9/Vh9sgc5sujgprrRWZ DaxkcIny FzeyHF9+62qWyCxMkVd+5+x6wa/SJztsmMLtAFgWbOZugEbuZR8oEhLVYjlrwwRkFh/YjvnPowPFP8HnfZaH60nJzT2RwxE3xBpLYpBHfkaskFOJXGuSgbncUAQU18jhBvyi2LYvW2lsI157ilNc/kQ9QCvHx7m/JxcRhf+4qFz+dF3sZBVLX8k6WNAr1KBQysxUZ0QKRFOyywA4ARBZbeN5lC86w3ENy697Ji6TocqEBcR7OBRoYKGEcLGAQV5Pqmle/cy517Nms0xHCf2QiPIIimAqd0FsVs4qaByPgbRuVAqPnAfUL51LlrC5PA5sszNhPCBzUYxvkP27O6mkaTBq9krgk1PVmn3ZlsB/9iALuG1UST8iIZHvijenpOy0ayBzDjVWOwGZzpe0rKGr4I5lLRtlnfpQYCfbyl3a49pRLKYWZlL7N2YPTUnpgtxNZKfptlThvAf02sxbt8uSRgUmsMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-MADV_COLLAPSE-catch-none-huge-bad-pmd-lookups/20230125-095954 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230125015738.912924-2-zokeefe%40google.com patch subject: [PATCH 2/2] mm/MADV_COLLAPSE: catch !none !huge !bad pmd lookups config: x86_64-randconfig-r025-20230123 (https://download.01.org/0day-ci/archive/20230125/202301252033.HoFIRXm4-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6001eb9a8f1687a1d0b72831d991886106cac37b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-MADV_COLLAPSE-catch-none-huge-bad-pmd-lookups/20230125-095954 git checkout 6001eb9a8f1687a1d0b72831d991886106cac37b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/khugepaged.c:972:17: error: passing 'pmd_t **' to parameter of incompatible type 'pmd_t' if (pmd_devmap(pmd)) ^~~ arch/x86/include/asm/pgtable.h:254:36: note: passing argument to parameter 'pmd' here static inline int pmd_devmap(pmd_t pmd) ^ 1 error generated. vim +972 mm/khugepaged.c 945 946 /* 947 * See pmd_trans_unstable() for how the result may change out from 948 * underneath us, even if we hold mmap_lock in read. 949 */ 950 static int find_pmd_or_thp_or_none(struct mm_struct *mm, 951 unsigned long address, 952 pmd_t **pmd) 953 { 954 pmd_t pmde; 955 956 *pmd = mm_find_pmd(mm, address); 957 if (!*pmd) 958 return SCAN_PMD_NULL; 959 960 pmde = pmdp_get_lockless(*pmd); 961 962 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 963 /* See comments in pmd_none_or_trans_huge_or_clear_bad() */ 964 barrier(); 965 #endif 966 if (pmd_none(pmde)) 967 return SCAN_PMD_NONE; 968 if (!pmd_present(pmde)) 969 return SCAN_PMD_NULL; 970 if (pmd_trans_huge(pmde)) 971 return SCAN_PMD_MAPPED; > 972 if (pmd_devmap(pmd)) 973 return SCAN_PMD_NULL; 974 if (pmd_bad(pmde)) 975 return SCAN_PMD_NULL; 976 return SCAN_SUCCEED; 977 } 978 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests