From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90386C54EAA for ; Thu, 26 Jan 2023 00:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9DE76B0072; Wed, 25 Jan 2023 19:24:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4C4C6B0073; Wed, 25 Jan 2023 19:24:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C7F6B0075; Wed, 25 Jan 2023 19:24:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 77C646B0073 for ; Wed, 25 Jan 2023 19:24:25 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4742E140265 for ; Thu, 26 Jan 2023 00:24:25 +0000 (UTC) X-FDA: 80395053690.22.2876341 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 98CF9A0004 for ; Thu, 26 Jan 2023 00:24:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yBfgnLWE; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674692663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sD3Uc7kD25/aRa+d27Bk7IPKjG3JujjT6Art82143Cw=; b=MV2rxgMhwLGwUWg0BQH0xjkb7cOY+i6EdP3W5YPe16jibqUJKRJL7sywM7VUsd1JWnVioL MajhLNJCylJLJkzZzhy179fYwdZFsf0bgncWzkWDnnR0jIFJEfrNjZuACi2g2yYP0nn+qx wyzbHRa1seH2jZmowBAZrVI/QWRTcTg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yBfgnLWE; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674692663; a=rsa-sha256; cv=none; b=IkXyIggARr0cBOgDyUyv8+MMStCtAVVw8Qt3OZQWs+JxEiLrEeln4n2BiGgSz6nwnPJvkG XOqrmqCUK4dIkNj2Bf6rjRoS1h+gFbSzUKnJ9X70+jptDyIt8tIu3Bq5j52JulTEYv7Qx8 9Ws4ejXGn065VANgVy+KD8uqbeDnu94= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5518F616EE; Thu, 26 Jan 2023 00:24:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B02CC433EF; Thu, 26 Jan 2023 00:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674692661; bh=N0v5l5ZR0YrLLuXkW8rcRAmrAzQT9ot2bUDRvREIlOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yBfgnLWERC7RJfGt+Vcyq9ihgxPtUxN5ZDIv9T78iTGUTZ2aEZOryZgFk1X9EdABl lrQiE4BNvEpCbVdhotoGo5aDtCNiXOfu0mPz54AqvHfY+yWZf+Nd9ue7sLNvJjNzgQ WOOjjg1+ziaccQFgXs89KnsVW3vxyXi02Y4i5DoA= Date: Wed, 25 Jan 2023 16:24:19 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions Message-Id: <20230125162419.13379944d6c0d4253d7bc88c@linux-foundation.org> In-Reply-To: <20230125233554.153109-3-surenb@google.com> References: <20230125233554.153109-1-surenb@google.com> <20230125233554.153109-3-surenb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 98CF9A0004 X-Rspam-User: X-Stat-Signature: jsetb15qxnsasettkeqtoakzy4e77eah X-HE-Tag: 1674692663-244479 X-HE-Meta: U2FsdGVkX19sgWxJ3ksJvsQ6Fg3CNZ8ouxZWsN6YyfVevf8xjU/MEpPaGfYVMUbordBQIttRyFvseEaG1fBgmFtZSCvzaqmGbeHkJk1mYfKRdDg3FKpAihebDPJLlpHr/OKFzp6bwnI2CHd/jk9slVgl0Lqnkw6l8yOVLTxmN7zkDoSbAtuZ2iy9zt7wqh4QN/n/8d2EI+b2EjIePTxoOzO417Hw1YOXFiftImV/v+kssIveLXnBRsAkEF+dTzVn69O3KgkpP+YnJC7Eg+OChq4gKiJMNtp6nZ8CobdKM72n230ok6EEII9ANkmBnsuuhzQA0+jLFx3Rg7ANALozs2yh4tz2RVm8irGxlz1F0PlOzpWQpI9/+sQjEwQ3lzvm6Nt8VxT53ntyygMpkkJNx8fzxZIviNdWzlL01oioWigaio62BK5sIAl4GmRIWyt2i2V9hcmrIVoLFcPxdFmQTK37C7zwZ++3V+gYgB6sMx+aiUa1TrNkutB03+5YZ5UrbaV2ZpAYzf4NSOkJHICZdLg97tfUd5E8RdwQFEMjSKY09zb9R3YmeuQ00z4PWzqd1zJD5UwEL10axDQpHMsvhIyLabRCTWq/UMbw8O+fut2wQmdzgZm0C6aXTJ+N7+CTOH6qTQjmA4gAc0pnsAhrvfVadIeo78+WUy/mTr6/xGtMDcaqJYhXF1NNDFO+aCRlIQAPQ+38dumUYFyOzZDylRWozjNEMm4R/tyMsJk3BkWslF0qtIm7hB2wnDShvm+Oe1CjHInUG+Qpn5oiRWFIw1y7XZni6T7plZXGEKwQ+3GkOmLQc6fpNeB2BdQzYpzaZO+3Cs5LXiGJKIivyHN3grQGLXfILyJJVkgHlBQKNH2ilHKzvKUO6lE4u5mli80pETAF7CJZD2BuPdMIMnTmbnEKWu03UvAp3lrkxp8LGCklh89rhBZQIQD9GuoPoPoqHTsU625brsmQGJmQ6nF sImHqa0S YgPF+AanRsAEK7D2frQ5ablr2mRaVhou6bsSUZCUQJXCYrhYqZ8DIKCk6TmwcDkNgnAevNbP6o+a75YanrhxCWaNxiYBhcaOP7CW7ED68s/E9fB+b/jQxwfcDQkAmD6MKzAeSLF/V+M7KVC2uh2GsyAzAArB5cAZrH79E0rZ9xgFA1wKpVoaRZNpr+VM1LZO4zmTf1n1IyIEI2FC3d+2bZd9TakvuJcrWDgT+zsN0rv6xz4+TTdS+DGzShe6R3rhI9nGNFws341+Q+zqQrWKki2ISxLetm3RVw6CTs+h0uQRmZwxnQTLF46gJrG939Y38f3loPoNP2+4iBgkrzVN1tjT3YhCgFeMnzt8k2ppbSol67kptMqdh7vPj9kmt+8vQyzUwHmdsuJ/VM+tV/Sj1hNZmS3ZC6jBi/jjK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 25 Jan 2023 15:35:49 -0800 Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such > operations. Introduce modifier functions for vm_flags to be used whenever > flags are updated. This way we can better check and control correct > locking behavior during these updates. > > ... > > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > +static inline void init_vm_flags(struct vm_area_struct *vma, > +static inline void reset_vm_flags(struct vm_area_struct *vma, > +static inline void set_vm_flags(struct vm_area_struct *vma, > +static inline void clear_vm_flags(struct vm_area_struct *vma, > +static inline void mod_vm_flags(struct vm_area_struct *vma, vm_flags_init(), vm_flags_reset(), etc? This would be more idiomatic and I do think the most-significant-first naming style is preferable.