From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AC0C27C76 for ; Wed, 25 Jan 2023 14:45:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F34B76B0071; Wed, 25 Jan 2023 09:45:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4BB6B0072; Wed, 25 Jan 2023 09:45:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABE06B0073; Wed, 25 Jan 2023 09:45:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA71E6B0071 for ; Wed, 25 Jan 2023 09:45:35 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 689A340DC7 for ; Wed, 25 Jan 2023 14:45:35 +0000 (UTC) X-FDA: 80393595030.08.CADDF77 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf23.hostedemail.com (Postfix) with ESMTP id 8CDC2140016 for ; Wed, 25 Jan 2023 14:45:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rOOvRup5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3jEDRYwcKCHchYVitgjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--mdanylo.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3jEDRYwcKCHchYVitgjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--mdanylo.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674657933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGfGUjaGLH+8XJ9armKqzpt89zfr+otVnTMhjbMCoI4=; b=wZjDfagYJO1QwcwNl23RqUhOeXKwimLzsrjDfcg2v4lWx6G+S4Do80BEjankIXLdzP9Uw5 8VChGiPeeEXqzx8X9+CV/Fe2e54FFC+ryPJAZ0yS7sYdakVHVTeFtJewczTKm1QqpQGCwx nuwX8uW90NIWV5VYaj/JHL4mMDnz/Qc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rOOvRup5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3jEDRYwcKCHchYVitgjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--mdanylo.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3jEDRYwcKCHchYVitgjbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--mdanylo.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674657933; a=rsa-sha256; cv=none; b=3hXq+ncdJKiUAs+JoDBdH8YEdhyxX59DfQwSavbPJ6Dky6urcD5wCvHOaEDmP0ZZc6smx/ WHVihftrvsoi9h7OKzgOhXCxU6MeVBjmmgDdCnlENAHXo6tXrwIAvht5HgoRT73ts0GB9I PXpA1g9lzildy2VMuOgR5qffCTTPj94= Received: by mail-yb1-f201.google.com with SMTP id k15-20020a5b0a0f000000b007eba3f8e3baso19784510ybq.4 for ; Wed, 25 Jan 2023 06:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XGfGUjaGLH+8XJ9armKqzpt89zfr+otVnTMhjbMCoI4=; b=rOOvRup5i80rTrCdededOy5eOHDXSOWC4JOHuwbako4X/IP6tSOe4t0Uq6NT9zncrt 6pMzQAKz0XS6hSLJ1vnCRioRsOfbndERsOdxfrWcgy1EQgQ2YQyO9+l+nDLm7MiwNV+2 O00Pyo/suVmmHuA0IXW65H2rKJ0/CUU0nw7aChk2qLJNlSvnqjwBNmaYg3ib2tVZd39X 3q8s8bSmCLgiuetJPB0SxvCvejHEcyEiSNil7W3RYZMXY/jKURm5eZW6aTUFQhs3lcZe 1o2/S95mBqBEzagirjGXsYc3TmmxrlkPcfLwgXs/8VPAPwaB0bzNvZfCS06Lbep9Gqta xysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGfGUjaGLH+8XJ9armKqzpt89zfr+otVnTMhjbMCoI4=; b=bKo/+SJbtDnb/nUhymjGs1c6ZsB861WHA+L7T7ps1SAHrsnBNF+V8nGymr5HR1UBvr DzAYn0URPhrIBHkgZM34/N8aPe2NOIVL4KykmTu08j7j+nYCk6rgu8+2cuwroPfroIoA XWRUdWbRMJPDD4aea28Y67xbweBfcYvFj+nLPcaIr//1CDETSmOSMjKChuTDrhVE9uKS fgExy0UU0Rkj7v7YLxyNp5feZ2s1w/SOFvjmhHXH0sN6SiLsYKFszqRI/4QG8WeKMDQ3 HqPew8+wOMfvREpKTDyeyIbPQsjSGIf1xu00h4TGlWqh1bhvhuCpg7BlNeKiPI+GxG/k dblQ== X-Gm-Message-State: AO0yUKXLp8nRCEiuc9z/vay/H5fvocSlQtxVmOii5yGckMVC54wUb6Y4 eddjS9cyb+rvihjNk/qbV+5HKBXt0hP+ X-Google-Smtp-Source: AK7set/tmTwyZYMl/jIoH2jKvSplFAhH7z4Cf9+VFwkQOG+1wRywqg63gkehHrmk61wsnNB67mOZRJgPfpy9 X-Received: from mdanylo.waw.corp.google.com ([2a00:79e0:9b:0:1ad0:76d7:3d4b:21e1]) (user=mdanylo job=sendgmr) by 2002:a81:ac61:0:b0:506:596a:586c with SMTP id z33-20020a81ac61000000b00506596a586cmr567812ywj.237.1674657932535; Wed, 25 Jan 2023 06:45:32 -0800 (PST) Date: Wed, 25 Jan 2023 15:45:29 +0100 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.39.1.405.gd4c25cc71f-goog Message-ID: <20230125144529.1630917-1-mdanylo@google.com> Subject: Re: [PATCH v7 0/4] Implement IOCTL to get and/or the clear info about PTEs From: Danylo Mocherniuk To: peterx@redhat.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, alex.sierra@amd.com, avagin@gmail.com, axelrasmussen@google.com, brauner@kernel.org, dan.j.williams@intel.com, david@redhat.com, emmir@google.com, gorcunov@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, kernel@collabora.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mdanylo@google.com, namit@vmware.com, pasha.tatashin@soleen.com, pgofman@codeweavers.com, rppt@kernel.org, shuah@kernel.org, shy828301@gmail.com, surenb@google.com, usama.anjum@collabora.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, willy@infradead.org, yun.zhou@windriver.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8CDC2140016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: qsqkhmo6z9jj9yz6tdy3a1ra7kgd1ne1 X-HE-Tag: 1674657933-512641 X-HE-Meta: U2FsdGVkX18vcbHIh0z8acPh4BdAKOeDbZUy5KpOCyICt2uGtjnqPCtQ7xzzQihMu6JblyjhUa17QA0xfIKKGBwMAU+LbTHzB770b/TTiOo4bexxNKl2SzDOpOkt0vrKJ5w06f/GZqM8OpZd8FBUPtzYNKMcv/VVYktYUwgPp4/8TXjryJhEGlHLTI1uVSBC8JsRcDmmBnNqBW8SHo7F0iKoTNNfrQy/bv47D4ojaqOG18D79n3Bbiu3nx+/vdza8SbPJMFfdIpTzyPcVg0T3wLuu3WkfsJRaFQ28xdaolbm7o4Kt4jkBk84XXKG2JuBrsA8z7V5JlwY5Z5T3x65btOCwdbHO41x5vIM3pI9ddcWvoyvtm2iS82A8wCK6ubWSxXT62D4StSQAmmebjzkOatBRNBSaoNEIRskQMUg7mjjU6YazTDSO3hO2kHMR4ez7miyXDly20b8hbajFCyrhple/Q3pwBV2Ed/BP96LsDpQQl90umhpF9RP9+Q56956ROcuRjslNnK57go+eqWwt+7n1lEpL2HXIsTxU8/K5kPphcA6x3w3ZTAWG0va742igzoKSrn2n1VF48mlzQs4HCF2Km2VirzQwyH/5Kv7rOEQ3+1+OMt9VdShz40iEVvph9wnSdbbzGcQJPX45UMfJ7XFnt2ytTc9XVDw3QoT8qK5ff040kVoEjOzEwM0SCj5AWoKtZxwmwjZSqC6qMKHe/qHgWbh8x4c5JPW+Eb0rtt5b/duj29FxuqI1KedTIP3gc1tHkv0m59OR7CmXEoq9XthYGMWq/9no3Z5EJSS+uc5irI2616hTy4PckEpBYHUqi2jA47W4+9D1kwn8mA5pGmgo3M4pp06h7jWxCN9re+t4e5vkyTYKTZvPFA+wOQ4loSjOdrEs6K39nnTwWEwLSigVLvBX5LQ41iZJmsKHhvBaUYoH958cAJfc/NJd8WFajhxWV19/nOCVRWVHDH iWOrZk9b 4jzmhVOiCZ/pwtpVTD+BapphsRJfYkr0NAP7P+uUWmeAXgbQvBws30gzwNegcSgwHHzZIKy1S4yhcUYBl/ZsN7+8NgoRynLO5dwpOafNz2/2YgUgdiZJCS1LvZWP3/K16kRfAa/Tgm1SSKN5VeVSQCkng/TRdrymqYpMTW6sEPX7wQC22hnGgsv7Vj41aKEH+aLSNY3+J7fPeFENLdr0UL9VSvk8b/VjemLcTTdFvTBNGiwrQYz8eaE+CEysLP14xpKOvdeXkEnVQARgdgx6uIY71BnHnV+3wNy5HCnklFVD4xHDa6q4bSSaMCysfdP0pud4+57aHOOuJ6sDyfvx+x3Wsx8HYokqAzGFJSfmxlYqHiwDbqEwkr+S+exnty3zf5nMoV8byHqHaXTqG7tqkS5vM+B5MX/VwqYDg9PZAkxpOuqCQ3Q85po2etfsl4N1d67ay1/EkMEnAsDBYUbOazb8whDWc8zGNzHzJUaNTWDxjhsdr3edqRIVDV/WDer/59zGdrYdPF6ZkpO0xoV9nzk34lRHKX2kb/tp+q3Fh8WvGFxEU3gQHvtrry4bfpIivO2ExwQozNoNMlQkNmqCdbEDUAJOJZs+HlVOupXcyuUKFmp0XYXnH4PgwJPSrdxZMJp55 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 8:49 PM Peter Xu wrote: > On Mon, Jan 23, 2023 at 06:15:00PM +0500, Muhammad Usama Anjum wrote: > > > Firstly, doc update is more than welcomed to explain the new interface > > first (before throwing the code..). That can be done in pagemap.rst on > > > pagemap changes, or userfaultfd.rst on userfaultfd. > > Okay. I'll add the documentation in next version or after the series has > > been accepted. Initially I'd added the documentation. But the code kept on > > changing so much that I had to spend considerable time on updating the > > documentation. I know it is better to add documentation with the patches. > > I'll try to add it. > > Yes, logically it should be the thing people start looking with. It'll > help reviewers to understand how does it work in general if relevant > description is not in the cover letter, so it can matter even before the > series is merged. > > > There're four kinds of masks (required/anyof/excluded/return). Are they > > > all needed? Why this is a good interface design? > > Then, CRIU developers Andrea [1] and Danylo [2], asked to include all these > > different kinds of masks. I'd thought of these masks as fancy filter inside > > the kernel. But there wasn't anyone else to review. So I'd included them to > > move forward. Please let me know your thoughts after reading emails from [1]. > The idea makes sense to me, thanks. I just hope "moving it forward" is not > the only reason that you included it. > Please also consider to attach relevant links to your next cover letter so > new reviewers can be aware of why the interface is proposed like that. > IMHO it would be also great if the CRIU people can acknowledge the > interface at some point to make sure it satisfies the needs. I acknowledge that this interface looks good for my use case to get interesting pages from a big sparse mapping. For Andrei's use case to iteratively dump memory it also looks good IMO. > An POC would be even better on CRIU, but maybe that's asking too much. Can't promise now, but happy to do this when there'll be a clear signal that this patchset is about to be merged. Meanwhile, I'll make some smaller tests with this patchset rebased and will get back if there are some problems with that. > -- > Peter Xu