From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D01C38142 for ; Tue, 24 Jan 2023 15:24:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B60746B0073; Tue, 24 Jan 2023 10:24:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B110C6B0075; Tue, 24 Jan 2023 10:24:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D9626B0078; Tue, 24 Jan 2023 10:24:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DAFF6B0073 for ; Tue, 24 Jan 2023 10:24:22 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44CBD120B9E for ; Tue, 24 Jan 2023 15:24:22 +0000 (UTC) X-FDA: 80390063964.02.0E349F9 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP id 8E932A0018 for ; Tue, 24 Jan 2023 15:24:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=p4BBTOLb; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf25.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674573858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zZGjMjcjm4r7qco+xF5Csqx8YX3fGvwxRVOz+yxZjAk=; b=gGr+eR6KAeUfFIWiKjrGtnRq7hEorVioy8ZiOAVkb1TK6YDWLI0DMHu4PPkO5OFJx3BiVx R2Y7as3IKd+Xt0NJtRO/cz8r2n1xAc+C0NPt9Dh/b1m+UnBxZXPnrLpdO+gpSzrZrQzmWj oDghDgWoEMv3gi1uN1Clq2/F2Uny+L4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=p4BBTOLb; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf25.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674573858; a=rsa-sha256; cv=none; b=MB6ezJppyPzxiTHoYt6NOHUI1QjJzNQxoFxthACY9G2l2w970ZEB30iHnWiJE4XT/4ohLp nY+cvZ5P4/eJZscwZ0xnkaj//vPWwkQTTihKwkuQIHVQ/U46d0Jc+0P0l1j44I96oz0INW V6Sb1WGdTTXt+n+vrKWMeP+aUMwxrYM= Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30OET9XS006166; Tue, 24 Jan 2023 15:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=zZGjMjcjm4r7qco+xF5Csqx8YX3fGvwxRVOz+yxZjAk=; b=p4BBTOLbehhEpGSPhkTqTzBzbFwCazZ4hspvP7Id6zJ69hMv4QAYrI77GKunF9QLiyHf 09CNfcOcRMjHqdiw1tW7K5pRHE0gBdFKSTYwUbiUz1Rgi3xy+SnPZ7K96KYq/UqRlbIm R0GnD5YJscst/9gJ81kW2hz8cFW3kvXz0CzlfhL0EPWUR3VPwsn1Pivmz9c7AJAFncAr woO3WDl8dQxMoUZ8MRg0tG4qVF8MpCdT3PvUDFo2ncAQc9AG5f+gnLseHhBYXIUY153z fdZHWrTWStWTMkzc+eLY9OMdY7mpV/7sYkn1saP6MBZYIoAkG8RnLRL0tY1u16AJITYL CA== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3na6vyqtrx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 15:23:55 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30O4ujra018029; Tue, 24 Jan 2023 15:23:51 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3n87p62usm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 15:23:51 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30OFNnJO20120038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jan 2023 15:23:49 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B2612004B; Tue, 24 Jan 2023 15:23:49 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2B4920040; Tue, 24 Jan 2023 15:23:48 +0000 (GMT) Received: from thinkpad (unknown [9.171.28.222]) by smtpav03.fra02v.mail.ibm.com (Postfix) with SMTP; Tue, 24 Jan 2023 15:23:48 +0000 (GMT) Date: Tue, 24 Jan 2023 16:23:46 +0100 From: Gerald Schaefer To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, willy@infradead.org, jhubbard@nvidia.com, linux-s390@vger.kernel.org Subject: Re: [PATCH 8/9] mm/hugetlb: convert hugetlb_wp() to take in a folio Message-ID: <20230124162346.404985e8@thinkpad> In-Reply-To: <20230119211446.54165-9-sidhartha.kumar@oracle.com> References: <20230119211446.54165-1-sidhartha.kumar@oracle.com> <20230119211446.54165-9-sidhartha.kumar@oracle.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FEepWRTrhP5FT2DgTCs3k73bRN9a3bTq X-Proofpoint-ORIG-GUID: FEepWRTrhP5FT2DgTCs3k73bRN9a3bTq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_12,2023-01-24_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301240136 X-Rspamd-Queue-Id: 8E932A0018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: w8ogqzcxnoy5dhth1iknpssq3mjq5aod X-HE-Tag: 1674573858-474510 X-HE-Meta: U2FsdGVkX18aJyYEbU272UvjRo1GLysFzlT2Wjvl2pvqPVaI+GvPHhx2aEtgwD+JOi1lq02Prh0SztfNMhrTuj8gise44qh4pcouApNBwi2JTL5YvgUdYqsocT2GUAcmS4y7nPQXo+DwZ4mjPzjQcbh7z5l0HFgjaYaOMcNv58Nqx+RfFDxXcAa80Xps+n1f1CYCQh6BCtfqHgrezgX+6/Va7V/Gxq1rF/YKcsQsx1uxm+tMgnm7mLHH7R4A9KA8wbw/tFPQS9jqkXpR4xLIKgQPITfPeVnlXQAiB52mmpbIe45kuKoUZ2CQ5nSuH4uyUwwLRLzIHtGcdZkuM6BUcTzyWnoPNMY+HcME7jleE3JJerVLzZQ59ISKi4y4hqXbaK7mYBV7DZ+MXd0sPgto8d2aC0ZYdqHyQE5nyZeet11wBxHEZ4IWNpTCSgmlQwjrbYAujcJaz/SopOvpQG99pDdsx+z1TK6LwlbfVdsj1ugGMrbw7XDbNF/xiDo4hLX/k12vWMEc0D/AQkkAnCLsc1RDsut2l8SFFvnjqqPN5DvwY95Sft3VbzuRt05iSr/iG9yujqiMrmcx5iUaGZJxJ8DLQITvgRT010OBNvBkXS7/8v+/ze7fBli0SoZDcH+OrECTYD5z7c2EdxT7Pp0izmpDtRARfIWvRBy4sGS1vYJ9oNlppmhcwjY2C2B1FpkkQmD0GU9P6DKJy6E+zym2R7lAbyQFzrt+GMZem9gf0oNnySoeVkvKLfBOuLS4q2X+28H0HdP3pcobkJOXO6xfX2P9GkHlxS8Hvqh8dnxEe4FRgQIfpNKPLgwwhd//miMqZky2F8HP+bFXpsAb3qXTiRGyNstb21Mc6GyxZcC6FX/6njCj6uNzplh6rRCMmN2wqTAhiff0dGSjcoU2pHDWerocqazRcs3+pWD+yHZNGKw3b8IAowGFgA0TZnEvEVdZUf9xe2v60g0Mdnw0dRH 8h103065 B4Sjo5lbj8rSG0cKgFDzT9GFO1wSjIfeLEriyVTA8TzjjPm/dnplfVMj7aNp9TSQrV/tn2CjFZHSflwFvpST32IiFG4DAlE7XU2dSHTLtNsYtGx923oEtR3b8CGpiQqR+LsiXREVnvL/kcsJVzdauAga31/rZKi52CaFDoHdsEgaR9cLMV9WA66tU3nses8pd4NOTBH6TG8pkkTAyqxcivs62kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 Jan 2023 13:14:45 -0800 Sidhartha Kumar wrote: [...] > page =3D pte_page(entry); > - if (page !=3D pagecache_page) > + if (page_folio(page) !=3D pagecache_folio) > if (!trylock_page(page)) { > need_wait_lock =3D 1; > goto out_ptl; > } > =20 > - get_page(page); > + folio_get(pagecache_folio); > =20 We get a kernel crash on s390 in mprotect testcase from libhugetlbfs testsuite, starting with next-20230120, bisected to this commit. We get here with pagecache_folio =3D=3D NULL, and crash in folio_get(). It doesn=C2=B4t seem right to replace the get_page() with folio_get() here, the matching put_page() at out_put_page: also wasn't changed correspondingly. Also, pagecache_folio =3D=3D NULL seems to be a valid case here, on all architectures. Reverting this folio_get() to get_page() fixes the crash. Not sure though if I missed something. I think you only want to replace pagecache_page with pagecache_folio, like in the rest of the commit, and not page -> pagecache_folio for this get_page().