From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6FEC25B4E for ; Tue, 24 Jan 2023 05:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0A616B0072; Tue, 24 Jan 2023 00:57:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C92256B0083; Tue, 24 Jan 2023 00:57:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B329D6B0085; Tue, 24 Jan 2023 00:57:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9D5CF6B0072 for ; Tue, 24 Jan 2023 00:57:52 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6F01B80380 for ; Tue, 24 Jan 2023 05:57:52 +0000 (UTC) X-FDA: 80388636384.13.9D7240D Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf04.hostedemail.com (Postfix) with ESMTP id 3B9BD40016 for ; Tue, 24 Jan 2023 05:57:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aHLXXPB/"; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674539870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mv+FioXMlrsyxTXhzb/PLjNi/QnnyARXj25ZruRtvZc=; b=dqJuvOezHPb6pfCB5BX8syQxHYktcXECxAxi/+iMjYndhDYZ+LChQgK29Z5VpaE6pEyYXB 5NxPX6j4XotRY3uXYd6sbqjFhWue5SOvZv8AyjqZ8nS+Zm3qgGK7hAf/AokLMzY0qA5Q2x Ht3C3h+uENf/yx+qZogWqkW/zLrPuo4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aHLXXPB/"; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674539870; a=rsa-sha256; cv=none; b=xBYZ8t4mr6maPwei7OV0vxh74AJUKTFqiBsA7lw8PGGi0mxmYVkoKqUxvUA27j1wXJRNL5 HVF1pg737gVsQxDXopG8BXCjRXsYZzJRAs/zcyokS3/X4+mB5cF4Knwwue69Va4R4RTYT2 xUWFgmgLDdA3OC6EZa3nKTCsetfFq1A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674539870; x=1706075870; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BWXT55pgTN05p8rmoGRsHN/Pu5yqlCqCpxTEG344HI0=; b=aHLXXPB/AmA3OJFxv3YgQUQWD7+JYHPg7hYWwtSLfLY97rALraEcjWaw eqtM3m6tMI9SlyMFJG2QHeetbWIpPiH5Ua/RqZN9yO35AJr4DEilAydpk Vg135vQD5eDV2nTXgEspzjP2ZCVGjCbGFuWdOPN6c7HgHIAtzL2+TOHlS EXZ/1fIJpYY8hStQZs26U+nQCmiAKDo/yQkW+V63vmSQfy2XxE3DZKIb6 5fNltTMozo4DaGMByoi5f6/EVmgfJHovAxWaadzvaTcWdi6ZYHRMH+Jvs kSu0Hb/BPFgCUjmCjhhIihAwlTSxgl3T2AKQmZKtaFAmswaFGleg8rJe4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="305896705" X-IronPort-AV: E=Sophos;i="5.97,241,1669104000"; d="scan'208";a="305896705" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 21:57:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="662001918" X-IronPort-AV: E=Sophos;i="5.97,241,1669104000"; d="scan'208";a="662001918" Received: from lkp-server01.sh.intel.com (HELO 5646d64e7320) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 23 Jan 2023 21:57:42 -0800 Received: from kbuild by 5646d64e7320 with local (Exim 4.96) (envelope-from ) id 1pKCJR-0006BK-1d; Tue, 24 Jan 2023 05:57:41 +0000 Date: Tue, 24 Jan 2023 13:57:28 +0800 From: kernel test robot To: George Prekas , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Catalin Marinas , Andrew Morton , Linux Memory Management List , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Thomas Gleixner , "Eric W. Biederman" , Sebastian Andrzej Siewior , Andy Lutomirski , Peter Zijlstra , "Liam R. Howlett" , Fenghua Yu , Andrei Vagin , George Prekas Subject: Re: [PATCH 1/9] mm: kmemleak: properly disable task stack scanning Message-ID: <202301241309.4F6LhLvK-lkp@intel.com> References: <20230123170419.7292-2-george@enfabrica.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123170419.7292-2-george@enfabrica.net> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3B9BD40016 X-Stat-Signature: z6yczhurfj8ots5pnya3o69hqfamj9ym X-HE-Tag: 1674539869-926351 X-HE-Meta: U2FsdGVkX1/V1zGxy0jTCJXf9UeqQ/ftGIhgTCdE/cUxyEFOpyOoxA0LOnacnklrI+KCc7ITIEryeiR6sC0xxAmvDuG+Uy5rMfWQkzszv6xTVPqTQUbvzQQkzv1lZbkRRJACiudqTbdLI6mQSlGTavLg5zEK98CnYFxIYf+Sxzb5nM1D0P6KYnTnbMZj1DIyjiAqsHhny8/jHTxpXWvr8QTZRu2Qzl4t701SxAEi9di7XdMQl8QpEU1ZF+Vk6Cnx0ASruG3sl6J7UrbbOlnmEtllgwZHUANOtVKYfdGm2ptaFMiaqE3dSbS/5SZ/1pi+akIxdrvORjV1W5JAMqQ0oIco/1J9uZxf0GlFc8xVPYm9w2lAqp9rRs7bU8abo/80sYKDFjAuX0z7Q+0ivuJNZ8lbYskbxin2h3+Ds84v1dt12dcL51Zalz+DHJ4dLDZZ9AbqHzhd759Mjn5NvukVl1mtIfoHQPcQXz7NGLwdhyYv/hZJBJIXjtoiJLHsoSj+JV64QqKUr88ryFIlss/JQwE3Zan6Yxaud9XTOVSmVaxg8XGZKtj5zX+R35L78KjMj1AxYLFa1uUbPpb/OZe4z/yvKXhmSd8cdo8lWoJU563XOp5kM/xGWNu9qP/EYELIgZaK4huddynEcUIjy/FWp+NtHIIxOvAqfDAZw8IeoE9XT7xqM3fpEaSA48ZkT6G21YznGTpV59VAASgCXu9ATDthhLGSDrCAlIFIq+Srt6k/Z1nNW1OCBeTl/PFoQsS9dgTaTSbUvcgNrogyTE9em27LaS+NocAkCgtn2Y44FEuL0STEFRHq5dBmOUfFjhcVvtKnyTQL59Trt6erSY1G//FAYeHs40tApHzvxwFSEzoy8qxrJLOjrKnLDN/GnyfNg3dI60aHK24XEinYfveimATJuTf6K4wdTXHUzIkJxZ1bAkkilLOyXZzQcqErrjes2/ex3iENoY383u5ve8d XJ7HBTcJ dgaNtUCpnHP0AxdrwE+BkcZBLZWESRvT4tMOTNr3vF2CcdYMNZEOoPZbA4WULSVIVdS5/pxq8xN2heJWYB+0z4EDGHIBilWYJdR69f9BCbL6P1rJIy5IqXbuOnukbDlQDE117na3sK79ZGm4114nOw4nw/Xu0pQEkTc11VlRnryAXfc+G8nGkUcbAZ+OFk5zPABKudIBR5OHkMd3zznyiJ4p+nPmqaNuDzr7aP4jjUha0c8jREKhEvpjqrUzZs//cgE0SxN7xOb5f1VrdjIqwHqboF9l/cl0GHlfuTs0E9cOJzarUAPg3aiy8NJpEAwBwtY6HHi+PqKsMFgByRIG1RmTLC98bUQ252Gzd9wi+/mei8uVjUX0EWvEhtpNYR7VAPuJQjvhkPcijXz8nxlKb884U4zjdz1gncYPDORuNJR8u0o2/usl22Fd1sLRcWovb0yJvhzEx9AEhsdmgkslW7cieje1HKCN1SHjEm0lt8YDw3f6IfLBS+SWQqgUagYJhFTDy2hl1uiCchNtlsH5ULr1AjTZx6tOdJ+YD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi George, Thank you for the patch! Yet something to improve: [auto build test ERROR on vbabka-slab/for-next] [also build test ERROR on linus/master v6.2-rc5] [cannot apply to akpm-mm/mm-everything] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/George-Prekas/mm-kmemleak-properly-disable-task-stack-scanning/20230124-010911 base: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git for-next patch link: https://lore.kernel.org/r/20230123170419.7292-2-george%40enfabrica.net patch subject: [PATCH 1/9] mm: kmemleak: properly disable task stack scanning config: riscv-randconfig-r042-20230123 (https://download.01.org/0day-ci/archive/20230124/202301241309.4F6LhLvK-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/f0d9df4305849ecea4402bc614cadb0dd357da77 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review George-Prekas/mm-kmemleak-properly-disable-task-stack-scanning/20230124-010911 git checkout f0d9df4305849ecea4402bc614cadb0dd357da77 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/fork.c:163:13: warning: no previous prototype for function 'arch_release_task_struct' [-Wmissing-prototypes] void __weak arch_release_task_struct(struct task_struct *tsk) ^ kernel/fork.c:163:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_release_task_struct(struct task_struct *tsk) ^ static >> kernel/fork.c:320:2: error: call to undeclared function 'kmemleak_mark_stack'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] kmemleak_mark_stack(stack); ^ kernel/fork.c:865:20: warning: no previous prototype for function 'arch_task_cache_init' [-Wmissing-prototypes] void __init __weak arch_task_cache_init(void) { } ^ kernel/fork.c:865:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __init __weak arch_task_cache_init(void) { } ^ static 2 warnings and 1 error generated. vim +/kmemleak_mark_stack +320 kernel/fork.c 274 275 static int alloc_thread_stack_node(struct task_struct *tsk, int node) 276 { 277 struct vm_struct *vm; 278 void *stack; 279 int i; 280 281 for (i = 0; i < NR_CACHED_STACKS; i++) { 282 struct vm_struct *s; 283 284 s = this_cpu_xchg(cached_stacks[i], NULL); 285 286 if (!s) 287 continue; 288 289 /* Reset stack metadata. */ 290 kasan_unpoison_range(s->addr, THREAD_SIZE); 291 292 stack = kasan_reset_tag(s->addr); 293 294 /* Clear stale pointers from reused stack. */ 295 memset(stack, 0, THREAD_SIZE); 296 297 if (memcg_charge_kernel_stack(s)) { 298 vfree(s->addr); 299 return -ENOMEM; 300 } 301 302 tsk->stack_vm_area = s; 303 tsk->stack = stack; 304 return 0; 305 } 306 307 /* 308 * Allocated stacks are cached and later reused by new threads, 309 * so memcg accounting is performed manually on assigning/releasing 310 * stacks to tasks. Drop __GFP_ACCOUNT. 311 */ 312 stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN, 313 VMALLOC_START, VMALLOC_END, 314 THREADINFO_GFP & ~__GFP_ACCOUNT, 315 PAGE_KERNEL, 316 0, node, __builtin_return_address(0)); 317 if (!stack) 318 return -ENOMEM; 319 > 320 kmemleak_mark_stack(stack); 321 322 vm = find_vm_area(stack); 323 if (memcg_charge_kernel_stack(vm)) { 324 vfree(stack); 325 return -ENOMEM; 326 } 327 /* 328 * We can't call find_vm_area() in interrupt context, and 329 * free_thread_stack() can be called in interrupt context, 330 * so cache the vm_struct. 331 */ 332 tsk->stack_vm_area = vm; 333 stack = kasan_reset_tag(stack); 334 tsk->stack = stack; 335 return 0; 336 } 337 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests