From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39137C54E94 for ; Tue, 24 Jan 2023 00:40:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766EF6B0071; Mon, 23 Jan 2023 19:40:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7168A6B0072; Mon, 23 Jan 2023 19:40:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7036B0074; Mon, 23 Jan 2023 19:40:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4CDA06B0071 for ; Mon, 23 Jan 2023 19:40:49 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1A603C052A for ; Tue, 24 Jan 2023 00:40:49 +0000 (UTC) X-FDA: 80387837418.03.787ED24 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf27.hostedemail.com (Postfix) with ESMTP id E6E1D40009 for ; Tue, 24 Jan 2023 00:40:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xu7Z5PKd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674520846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WSPwNw1vPlrdeZ4Y06o9XhrpyGQHiNTeXL+Dp4ir0ro=; b=cY1wKEPuYeAtvINijcM1Y47j8MRMHxwiNBXT/aqkaNxYCVk4FwR295bkJWb5aPhVnHlh96 8TLW8gIBJ2cz28AxyLiu5UTQTMQiLsOl95u0s6oeH6ofYLKoH+GNXy2GxQPdXJW/ub/Whe lnKokXy3M2zQLADjs+VDEQ2rvznRizM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xu7Z5PKd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674520846; a=rsa-sha256; cv=none; b=RI4kZNBTFqr6GB9F3jg92nrbvpgf1a73TTb95FuxUmK87a9hHty1+TYGRZFAll6PNAXYsp j2r3llTbDpJgB7+IdElYq07q78Lsohx+HAGdP+SLdUsFamNjslyXIvmaecEg1bDRisIcZj 8zCVnu9r6Xhy2cXcFVkyJSRn9jCvFs8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674520846; x=1706056846; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v17R3QyYZCP4T22EmjJYvFeZBPZM3Q8P3+3lMWzi8To=; b=Xu7Z5PKdBi+5xYV60bZzHym29/cXlYQYUHRepJruaWtH/0neuxH2YfSS pK1HLwld8K2RajNgVXZqojZOZJTeP5fCToBaSNDjULrxL+BZvfa5Vcr1z 4P+l5Jt/yfp4YFQ+aw5uqmQoKJG4STn334lKJOjg8k5ykKp3wVjHhnqQH FYzHcvuzGKkUjyue7N87jcrnSy1CEojDL3yYXDDlOseD0WIHVNzjwcS9x K+yMJ99tgO8FDCtBYN1TcyMuDUfYR+5dPoEHS6QI5BNX4/Hz7dOLB/NF/ 0+lrQHKe7C21044Qx2GUPTnXkSABFanPIFswt5VjSYgOIPcIca9AFmhTn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="326234820" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="326234820" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 16:40:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="692428776" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="692428776" Received: from lkp-server01.sh.intel.com (HELO 5646d64e7320) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 23 Jan 2023 16:40:29 -0800 Received: from kbuild by 5646d64e7320 with local (Exim 4.96) (envelope-from ) id 1pK7MS-0005zE-2E; Tue, 24 Jan 2023 00:40:28 +0000 Date: Tue, 24 Jan 2023 08:39:40 +0800 From: kernel test robot To: George Prekas , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, Catalin Marinas , Andrew Morton , Linux Memory Management List , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Thomas Gleixner , "Eric W. Biederman" , Sebastian Andrzej Siewior , Andy Lutomirski , Peter Zijlstra , "Liam R. Howlett" , Fenghua Yu , Andrei Vagin , George Prekas Subject: Re: [PATCH 1/9] mm: kmemleak: properly disable task stack scanning Message-ID: <202301240827.j2GJi7v5-lkp@intel.com> References: <20230123170419.7292-2-george@enfabrica.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123170419.7292-2-george@enfabrica.net> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E6E1D40009 X-Stat-Signature: cjntku7wr5ha957nstrnpx6pydra8ir6 X-HE-Tag: 1674520845-966289 X-HE-Meta: U2FsdGVkX19ScJV0dlgi5PRq1YwaVhog5kldp7kPlaxG4hjqhIyBnXbj1OB0V3xoNiP/yNU0dTY798o1OrZS9OrpbXyTaf6Mt6zzXRc/GWYZUOKYJNBWZEbZ+crYKb357rnYmj/tnqxFN9vzEd7vYO5m9oVbhO7YVrq0bfEkgn3m8AgoCtmBUk6YHP1HCOnKE8JY5X3+e2ueIhgR8GYHuyr3LRbGfu3cDTxnOVHiCUuqPRTKQCL7vyFTCD60PPFy203rjhczmKmAYrX1dvJ3voJAtXi8cdXxKE6yZ8w5z7gtz75LH3mEoDn1k9NFnJ2FlTyvUqnP8Y3CSUArTksMIRdVU9o18LH3g9TFxrSUxiiIzPsneJv0rfpmxu4wKwn/X1Kpp3i7Xg777Hk0V6ifD8XZJOUN/xAsxCVY95a/arDz/CMqAuRsIRlzcRCjyg2OC5KksjlxFSgdUs35bCCwN+4v/TxwIt4HkL6IVqaAMt6BqOp44jGPWW6qJQkRbjEUboTLt+p/LKSBKKa7N70Y5k/VTk6ZsFFpNij2loWvpDee7lVSphR56mrNWoJ3LiCeOIONOn4hFxLtPOJ3qJkiJyZ/cwp+zEEdMGQUVKkF3Ph+LjRgGGSZzQF1CSPq8McyrcDNDKogBfCvvDkEkEkxuVpgR/jqftlKkQrSz4DvphPlzTSD9TavkHXkJvNTeDIT+xx7KX1m/3NX5TwU6tOSoBN0Fj16hgBPVpQ5qIHhUzkIO/FJMJtvqjJIYYdrxY3FzTj1tZ3sZK6+fHkg0hXZ1yiBU19qxNHfFcPnxPEsJiXrzTXXoa7NHBuMPgts/kfK60D2Xy2NS9TOIJxKjMrCTfqm9falOvK1jVlDn1+MSiZKxAh19MrSUKaOMMrcQfZEO3/D2CcTXiIcvQKlUuYFU2yb5DhkWRiSoYsXMR5fPjPp6CPEu8JRDfBL5C7/7UJc3Urbxnyg+XeUQvTYql4 FTKVsF0X G76ujiwc7YRJbwjB5wCSE6MjF5PJOm9of9yNPY62yGqSbwk7Rssb9VsNfoxxDqqDGjW37g33PUKArjkWmvfBv9N2zfSbklGE27Bo1hXflTGvQblRbxOmw/COPwNgP/+dULQlUR1tEGkNoLA14YWcUqTwyvqfQBkneI2LR+g112LE6pnWMyE32bsQ9YPculhW2E32cxFfikFi5kJFNfy67kMjzxiz/m/0HvGEmbgVh1xyGVw2lZpdKq4nhWg98Sa5sGZ6PxDY6K27nf3Q3PjyGkfjITS6yCfOG8Xe9XccBpBQ+GLDckeDDqgC1lL/ASC/LwEdnUdaEHFX2Ti7g/LvCL9Noh6NCLuTqXZoLX/SpM6GrVnKyAVelO6jFFXeIBZH/n7wq49MJW1uwpTfKz3MjV99gTqfG/lC0VMrEmOFQj3QyYJMt4o+gf0ZyrOwqmSAa/jd/aRhzvEsh33QNc2J8FpyksyWMhnEdAmKNsBRMrvPUFTqdqKTYl0D0/mrBT8dDD/R7t7Z59adM51Hjkpsk4Sr/3KGpVicTH3XD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi George, Thank you for the patch! Yet something to improve: [auto build test ERROR on vbabka-slab/for-next] [also build test ERROR on linus/master v6.2-rc5 next-20230123] [cannot apply to akpm-mm/mm-everything] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/George-Prekas/mm-kmemleak-properly-disable-task-stack-scanning/20230124-010911 base: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git for-next patch link: https://lore.kernel.org/r/20230123170419.7292-2-george%40enfabrica.net patch subject: [PATCH 1/9] mm: kmemleak: properly disable task stack scanning config: s390-defconfig (https://download.01.org/0day-ci/archive/20230124/202301240827.j2GJi7v5-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f0d9df4305849ecea4402bc614cadb0dd357da77 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review George-Prekas/mm-kmemleak-properly-disable-task-stack-scanning/20230124-010911 git checkout f0d9df4305849ecea4402bc614cadb0dd357da77 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/fork.c: In function 'alloc_thread_stack_node': >> kernel/fork.c:320:9: error: implicit declaration of function 'kmemleak_mark_stack'; did you mean 'kmemleak_no_scan'? [-Werror=implicit-function-declaration] 320 | kmemleak_mark_stack(stack); | ^~~~~~~~~~~~~~~~~~~ | kmemleak_no_scan kernel/fork.c: At top level: kernel/fork.c:865:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes] 865 | void __init __weak arch_task_cache_init(void) { } | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +320 kernel/fork.c 274 275 static int alloc_thread_stack_node(struct task_struct *tsk, int node) 276 { 277 struct vm_struct *vm; 278 void *stack; 279 int i; 280 281 for (i = 0; i < NR_CACHED_STACKS; i++) { 282 struct vm_struct *s; 283 284 s = this_cpu_xchg(cached_stacks[i], NULL); 285 286 if (!s) 287 continue; 288 289 /* Reset stack metadata. */ 290 kasan_unpoison_range(s->addr, THREAD_SIZE); 291 292 stack = kasan_reset_tag(s->addr); 293 294 /* Clear stale pointers from reused stack. */ 295 memset(stack, 0, THREAD_SIZE); 296 297 if (memcg_charge_kernel_stack(s)) { 298 vfree(s->addr); 299 return -ENOMEM; 300 } 301 302 tsk->stack_vm_area = s; 303 tsk->stack = stack; 304 return 0; 305 } 306 307 /* 308 * Allocated stacks are cached and later reused by new threads, 309 * so memcg accounting is performed manually on assigning/releasing 310 * stacks to tasks. Drop __GFP_ACCOUNT. 311 */ 312 stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN, 313 VMALLOC_START, VMALLOC_END, 314 THREADINFO_GFP & ~__GFP_ACCOUNT, 315 PAGE_KERNEL, 316 0, node, __builtin_return_address(0)); 317 if (!stack) 318 return -ENOMEM; 319 > 320 kmemleak_mark_stack(stack); 321 322 vm = find_vm_area(stack); 323 if (memcg_charge_kernel_stack(vm)) { 324 vfree(stack); 325 return -ENOMEM; 326 } 327 /* 328 * We can't call find_vm_area() in interrupt context, and 329 * free_thread_stack() can be called in interrupt context, 330 * so cache the vm_struct. 331 */ 332 tsk->stack_vm_area = vm; 333 stack = kasan_reset_tag(stack); 334 tsk->stack = stack; 335 return 0; 336 } 337 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests