From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6DEC25B50 for ; Mon, 23 Jan 2023 19:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC4AE6B007D; Mon, 23 Jan 2023 14:18:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C74986B007E; Mon, 23 Jan 2023 14:18:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B64196B0080; Mon, 23 Jan 2023 14:18:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A748E6B007D for ; Mon, 23 Jan 2023 14:18:19 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 75528121F3D for ; Mon, 23 Jan 2023 19:18:19 +0000 (UTC) X-FDA: 80387024718.20.C092734 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 74DD780027 for ; Mon, 23 Jan 2023 19:18:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674501497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LB+L+utv/cDjzWqbemZ5ANVNCUgUpSnHnn1bZRYaO6g=; b=gwTb5U/wVbIpNgwIRxO2HghWP7mGZRQ381hJmDfQX0/WxHyzdKHi5XCIjvk/c6TmxJ+5qc eGxC8tTh07+nyCNNXDLz+FDXsZLUzDUx4cXcm7aLXzMu/hMaFXz+va0C0B/O34hS2mY4RA OTslirctTV//sYao3adIQrHVRJHnDBY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674501497; a=rsa-sha256; cv=none; b=2o5f9yy5IytyyC8FL3yYGl3a2AZWsb58EcJqu6TJOyP0IZM3a9ct5HyK1d14mO+St66rJG 9thMFQ+celx+tJ9ulklnvSjmiXDz+VlnjcHz5N7T9TTOt3MS8Z+TmcChGARi6L36XtLUvY NRVCTrUK20HUJIWfTRRDEPtlH4tBllk= Received: by verein.lst.de (Postfix, from userid 2407) id 2BE9F68C7B; Mon, 23 Jan 2023 20:18:13 +0100 (CET) Date: Mon, 23 Jan 2023 20:18:13 +0100 From: Christoph Hellwig To: Andrew Morton Cc: Christoph Hellwig , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: return an ERR_PTR from __filemap_get_folio v2 Message-ID: <20230123191813.GA16510@lst.de> References: <20230121065755.1140136-1-hch@lst.de> <20230121170641.121f4224a0e8304765bb4738@linux-foundation.org> <20230122072006.GA3654@lst.de> <20230123105945.958075d46b0a05ffd545e276@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123105945.958075d46b0a05ffd545e276@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 74DD780027 X-Stat-Signature: 69ptr3xkn3iyy9ob8c1msqh3mzsk7iwo X-Rspam-User: X-HE-Tag: 1674501497-765884 X-HE-Meta: U2FsdGVkX1+wqET0ezvUv4YihnX9MW0pnR+xu7+VE711cqB4qrwRD+kRJle7te2yNPEh2KPD608MONZr9lRT8PM8KAyIKRYSjLOqcJT1+HPtsmjjgM3wiRTS2C7RVePFsID+63HpMPLA/V0AcQzfzJ41Te+Qa97L8rUwYUvjTKlxCbevsPndWX+hX6lcFZpdbPD2ziBC0HmA34pykKcyFg3mz375ZBxY1+3ZV4ipRQCMcqMjYCM1vCcI6jHKgny6t4x8HkupyWRw7Wg7WzlmTDx1/APtW89va65cxUTN3fpE0bpzlxWgKQtF3quuLc3UoOnJqCtWhPozux7Q7NIpTtz6AyPHZAcENAR3D8qQc/ixprnR5g59awPmFmZtgmNuE3Hpom7UQ7RLnSBfh5WtNpwQPr9GZFlfENnnwZKmdvpTxAGg7MIghq6HPmJbUOKwlpkbJrLht/Q2nHE3K4VK032RZoFPU0HilkW4Ibh1Td8a5T/fusyLifMH2dxxdG5TrjktuSpVf5bGa/c40jUg5gv3FZ7WINKuI26+kmhleeBUSct1XUh7rOkfbX/rlRZo2UlshA0obenlkopBX67uw6o4mkroBa2YwAeMJKKcB0+RXsxRJP4MBxa2eODhjnfXD0Qi7wGL2p++zfQVj61QSeOfx6rQ0jAWTLdvJOwdLbopr4Tp93iR0bx9ZiKS69V+ELYQqkV7fEiUpEZ012LTMwmv/k8cyp1CFlzQEdW8/i965ufU2aoZSmMbxRVbHgD+M4MGItl4i2hfph7WMQ5fqwflIJ2tXoqfirG5ewJPGPqgfIsRuY6M90a9GZRcBPUZYWrqkZZNTj0El4wSHNrZ9sWL+3JOStLJlCN7sLJPyXTuTrSh4dCYN8+F45kMadHIS7MJGTN8pXPXTCHy3JiHl3myGpBUn2Vl99bbbf6yjNUuJs+53VOlXmxGcPnaiVxPF91hFXtmCAlbWYmPPTl sDIXqWPh VONheAmvCG7+oZYM5BExfH0TCnMRidPjFfc9IiBF//K5nGThd1EU8knkdQf+fM4gJ7qynBS5QOCq52dO63UTnp28P4GmmR/iU01Udib2vflIkWEdLeMgrJt1MKrkF5TSmj7JyfRfoS+QGe3hm4F8nA2/JTnkAw+xDc4R4Ql1/ixgQlcyHCEQjDmu83Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 23, 2023 at 10:59:45AM -0800, Andrew Morton wrote: > On Sun, 22 Jan 2023 08:20:06 +0100 Christoph Hellwig wrote: > > > On Sat, Jan 21, 2023 at 05:06:41PM -0800, Andrew Morton wrote: > > > This patchset doesn't apply to fs/btrfs/ because linux-next contains > > > this 6+ month-old commit: > > > > Hmm. It was literally written against linux-next as of last morning, > > which does not have that commit. > > Confused. According to > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/btrfs/disk-io.c#n4023 > > it's there today. wait_dev_supers() has been foliofied. Yes, it's there now. But I'm pretty sure it wasn't there when I did the last rebase. Weird.