From: George Prekas <george@enfabrica.net>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Liam R. Howlett" <Liam.Howlett@Oracle.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Andrei Vagin <avagin@gmail.com>,
George Prekas <george@enfabrica.net>
Subject: [PATCH 3/9] mm: kmemleak: propagate NO_SCAN flag in delete_object_part
Date: Mon, 23 Jan 2023 11:04:13 -0600 [thread overview]
Message-ID: <20230123170419.7292-4-george@enfabrica.net> (raw)
In-Reply-To: <20230123170419.7292-1-george@enfabrica.net>
When part of an object is deleted, propagate the OBJECT_NO_SCAN flag to
the 2 new created objects.
Signed-off-by: George Prekas <george@enfabrica.net>
---
mm/kmemleak.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 2b9c9ad68806..5882f60d127c 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -772,7 +772,7 @@ static void delete_object_full(unsigned long ptr)
*/
static void delete_object_part(unsigned long ptr, size_t size, bool is_phys)
{
- struct kmemleak_object *object;
+ struct kmemleak_object *object, *o1 = NULL, *o2 = NULL;
unsigned long start, end;
object = find_and_remove_object(ptr, 1, is_phys);
@@ -792,11 +792,19 @@ static void delete_object_part(unsigned long ptr, size_t size, bool is_phys)
start = object->pointer;
end = object->pointer + object->size;
if (ptr > start)
- __create_object(start, ptr - start, object->min_count,
- GFP_KERNEL, is_phys);
+ o1 = __create_object(start, ptr - start, object->min_count,
+ GFP_KERNEL, is_phys);
if (ptr + size < end)
- __create_object(ptr + size, end - ptr - size, object->min_count,
- GFP_KERNEL, is_phys);
+ o2 = __create_object(ptr + size, end - ptr - size,
+ object->min_count, GFP_KERNEL, is_phys);
+
+ /* Propagate the NO_SCAN flag */
+ if (object->flags & OBJECT_NO_SCAN) {
+ if (o1)
+ o1->flags |= OBJECT_NO_SCAN;
+ if (o2)
+ o2->flags |= OBJECT_NO_SCAN;
+ }
__delete_object(object);
}
--
2.37.1
next prev parent reply other threads:[~2023-01-23 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:04 [PATCH 0/9] mm: kmemleak: fix unreported memory leaks George Prekas
2023-01-23 17:04 ` [PATCH 1/9] mm: kmemleak: properly disable task stack scanning George Prekas
2023-01-24 0:39 ` kernel test robot
2023-01-24 5:46 ` kernel test robot
2023-01-24 5:57 ` kernel test robot
2023-01-24 6:07 ` kernel test robot
2023-01-25 14:47 ` Catalin Marinas
2023-02-01 15:38 ` kernel test robot
2023-01-23 17:04 ` [PATCH 2/9] Revert "mm/kmemleak: make create_object return void" George Prekas
2023-01-23 17:04 ` George Prekas [this message]
2023-01-23 17:04 ` [PATCH 4/9] mm: kmemleak: add kmemleak_noscan_phys function George Prekas
2023-01-23 17:04 ` [PATCH 5/9] mm: kmemleak: do not scan sparsemap_buf George Prekas
2023-01-23 17:04 ` [PATCH 6/9] mm: kmemleak: do not scan cpu_cache of struct kmem_cache George Prekas
2023-01-23 17:04 ` [PATCH 7/9] mm: kmemleak: erase page->s_mem in slab_destroy George Prekas
2023-01-26 11:28 ` Christoph Lameter
2023-01-23 17:04 ` [PATCH 8/9] mm: kmemleak: erase page->freelist " George Prekas
2023-01-23 17:04 ` [PATCH 9/9] mm: kmemleak: fix undetected leaks for page aligned objects George Prekas
2023-01-24 16:16 ` Matthew Wilcox
2023-01-26 11:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123170419.7292-4-george@enfabrica.net \
--to=george@enfabrica.net \
--cc=42.hyeyoo@gmail.com \
--cc=Liam.Howlett@Oracle.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox