From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E413EC05027 for ; Mon, 23 Jan 2023 15:50:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C8126B0072; Mon, 23 Jan 2023 10:50:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 375B96B0073; Mon, 23 Jan 2023 10:50:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23CD76B0074; Mon, 23 Jan 2023 10:50:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 13D136B0072 for ; Mon, 23 Jan 2023 10:50:33 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D412480AED for ; Mon, 23 Jan 2023 15:50:32 +0000 (UTC) X-FDA: 80386501104.01.B97792A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id CB77B40002 for ; Mon, 23 Jan 2023 15:50:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPXFoGuJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xOcYsz+z; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674489031; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sUGIH2I54cp4HbnMiIaY15PfXULieuiQ0sW9X9yG6Sc=; b=GePlHwcfTvIyNoiXC/O6o0swhNO2dPztLGHlm51jQZn2wQo1wmzP3UVwi61Y5dCG3Cqm6Q 0hUhY8fRElY3FxBELPUq2P7j2u2++wu9d14sK4h7lQWGLfHYTjxpnYKJh5Z1zSrmiZR+gV gI9HtKnPrs6JtsPzRNswhmUxKv+M/vA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPXFoGuJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xOcYsz+z; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674489031; a=rsa-sha256; cv=none; b=FDVrkBRzQwIHFb3qX6/4rKECvNSfEq/YyUwynOIioMbXtTElkpGA5VgG9+YNpiO6WbpW5Q BoXp40RsjtObL2zLdqCi4+unw9qbCmWAUgjgSRb4pshk3NPQ5R1NRUciiEbM6FB1g3JM3V 1K9WTV7JDRit271Ay26qd3NpunwPkVQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2FA6A1F749; Mon, 23 Jan 2023 15:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1674489029; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUGIH2I54cp4HbnMiIaY15PfXULieuiQ0sW9X9yG6Sc=; b=OPXFoGuJ8BkSymKabi8S/f/rmJEkvx+fgrXVqizmYyDI3KhBbMlUuLj8YQectO2Ngl9/Sf oGaVWENU63tAhnkYzTuPgH+u6QSbPi1G42bWVBQW/Fd77EpB2+8rwpOtlrkGfwdjkyAjny CVCmqcffKPgt8etMatoZ+dSqDZHYXIU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1674489029; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUGIH2I54cp4HbnMiIaY15PfXULieuiQ0sW9X9yG6Sc=; b=xOcYsz+zrkERuCg65RzTgYDWspE7gLGRBq0M143VodPXwP6GO0FzliKs6WdMBcPvTtIt12 vGjp9a9wvCEfUZBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D1B05134F5; Mon, 23 Jan 2023 15:50:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id euY6MsSszmOdYgAAMHmgww (envelope-from ); Mon, 23 Jan 2023 15:50:28 +0000 Date: Mon, 23 Jan 2023 16:44:47 +0100 From: David Sterba To: Christoph Hellwig Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Message-ID: <20230123154447.GP11562@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230121065755.1140136-1-hch@lst.de> <20230121065755.1140136-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230121065755.1140136-8-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CB77B40002 X-Stat-Signature: fjhesek8uukt1fpz7bi9detywt3rezmg X-HE-Tag: 1674489030-481360 X-HE-Meta: U2FsdGVkX1/TC5pHI/gUQpyjBInI50nQuEO4CzLSp2WnOdhwo4GmIW5rm96RKo2JXIKcr/0RxJgFOHPlNMVcxY6ASzvvlG0WF4frLHNKDx/trTj1HdGeZa4F93Yt9Ad2Jw9UCE0iPa+HnUDZVRM9YCg4diDINNRiooBUICAfMEHRuzLBro2E3GLw0Lfi849uq38IiI/HCa2Y/wDqrXcszDPEVADeUw1ZtiJeqN8rZyOmJS/LjmHsb/qCwzn8eDxnfb4YV7NtNuotg056AoiX85pO2U7LB7nmCZs4O8omhcXRD+9U/DPy6Hrmtx7lDr7zMhW7pjLow5d8nvhe+mehuUBcih/JTlZ/pfmvpVx15jGfO/JbGqL6dbdIVpwHTbrDiro2xghq6n26qw8w3UTVgEj6I7qMf/WVyAAXSSAFsPsacEKK+9vrhKPhUDsOcZHN+aoU/Wzn6sdKFa4S5CepGaypbnuyMLa/bNyGMMr00CrDVl56j0VmCLDdJadq9RQrqZaaZfYOBxMPQwJ6xlMGuCsTo4T/p1gV2Slr4VN3KD0m5XT6otAMxc8kBqGKd23F65preivgNRTeeOVA096oNwyiNgLsFi/HUVaK9yoJdrh0uFrd/ij79Tk3PA+nCz+toyohziNvmF+btXtyCc65MzCVQfwF4itrqJJDH7lxQXdvkcHQvK7YgCnj6GXc3PGjW8Dxi60vdrAkWN8c1EQd5dQMM7otg62vi97tOK4SkXF3UpugKivte0IBQ6pPaOcXpSid6IZLsG0q9liRAkIj78DJFEyTdi8tbXF6FsULrU89mfitrQ+CWOLaOU4sI+Zmx43mafxsSXcAhiXdjDnTEYfxqru1eO+CFMxMCgw/fK4Fcnb5DITg7gKjpQ6lUH/gVEKLM2hjF6xBzCiu/HDAy+4EugWpLVKABzLVUymxBVr94+zXa+5IpwVswM2+IuzhmlU4KvMyds7oW8AM6w+ 2v/otybP 9iovE70tS/vrHwTqixuy9RH5QcSiYKt2GWzW3fACKaKhKa9CaJmyx4gjW44F9/Jn3O1L7GSZ1T/yEbrxSXpBjwktonkI6Unx7rPX9gxxh5yyXu+YY8Jn8sCp87yURd6hrAQZACJQb/JR3dwUrwVamtsl+xPFKjTuAadNrs8DbAkY6PfQI1LIUvHAxv0f8ZO9iE4zIo4c5ahHhmxYTunejtxxIvMoj6hfP0dNxTUYT1y/i56/G9sqo3BmM6RKwRQ2hBEwmWFxKVYMusHcApZ5fypwIAsSFfho2dAC+OIxpJoL/qh3EhG7Cc18/opmOeeQpJuhjkF7suvJAr8IhkPkuj2TfNzgA2QyCF9KxHjjDuyDu3+XRHU7YF+F0Jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 21, 2023 at 07:57:55AM +0100, Christoph Hellwig wrote: > Instead of returning NULL for all errors, distinguish between: > > - no entry found and not asked to allocated (-ENOENT) > - failed to allocate memory (-ENOMEM) > - would block (-EAGAIN) > > so that callers don't have to guess the error based on the passed > in flags. > > Also pass through the error through the direct callers: > filemap_get_folio, filemap_lock_folio filemap_grab_folio > and filemap_get_incore_folio. > > Signed-off-by: Christoph Hellwig > --- > fs/afs/dir.c | 10 +++++----- > fs/afs/dir_edit.c | 2 +- > fs/afs/write.c | 4 ++-- For > fs/btrfs/disk-io.c | 2 +- Acked-by: David Sterba