From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCA6C27C76 for ; Sat, 21 Jan 2023 14:28:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681F76B0072; Sat, 21 Jan 2023 09:28:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 631D36B0073; Sat, 21 Jan 2023 09:28:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520AF6B0074; Sat, 21 Jan 2023 09:28:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4200E6B0072 for ; Sat, 21 Jan 2023 09:28:23 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 06DF840642 for ; Sat, 21 Jan 2023 14:28:23 +0000 (UTC) X-FDA: 80379036486.29.1A0952B Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id 05A1B80018 for ; Sat, 21 Jan 2023 14:28:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674311301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AdXcQJG1XWVRa2csTvjE1zXSCuzDdrHU3NdMMnXHYA=; b=T4EIq/PfsiF82XAqId7yesQmQI3PihZ318aQfqSHyWBOtWngh9FFyRLEloOvqiefInPfk+ ihlCQgKH32YKhm6Sv5TvM+uE8hv7yQgdVC1pouxjA90Ra0NQnzXWpYMCk6PLLJgeCnrV89 /ohMmkklOzXpNyRm+3ghX4r72M7BwyA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674311301; a=rsa-sha256; cv=none; b=G3ictRlqu/kprZpuTPyHjq9g9eCxVXvvvH9RUqRtco8sqOXQTrubFPwssr5E22dmVE99Ke EseHl5E5c+eVi5nwCyhYFfoaMl6VkeWZxkNxjP4vwVmUSnNKPYGHTvsPWchhyBKKODE+75 ZMjwtR89TE5dImlxUzfvFwzNNhbQ63Q= Received: by verein.lst.de (Postfix, from userid 2407) id 70C3668CFE; Sat, 21 Jan 2023 15:28:16 +0100 (CET) Date: Sat, 21 Jan 2023 15:28:15 +0100 From: Christoph Hellwig To: kernel test robot Cc: Christoph Hellwig , Andrew Morton , Matthew Wilcox , Hugh Dickins , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Message-ID: <20230121142815.GA6786@lst.de> References: <20230121065755.1140136-8-hch@lst.de> <202301211944.5T9l1RgA-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202301211944.5T9l1RgA-lkp@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 05A1B80018 X-Stat-Signature: fos6r1zb9fx91pnk8jqpd1kefmdzkxwk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674311300-194986 X-HE-Meta: U2FsdGVkX18oQ1VVlVflBmiWUbP3lPiCQPbNOr91STx3Vxqar0DkwitjvPvU6+Yy3/vby5Px2D3ssxyUys6Us/ooXlRGq31PHpRqgtOh7xp/V+VHLe95pZivLFG1+YUPn1X8RfXLM6XTx/4o7aRSVhPsF1K/k5gePQPHlzfYYq1DRpQROyhVWWxSITNPcWPju6OkPCkMJ7uHCCXb1+nvjNgbwX31BQ34q1Cv7yqoulISNaahof53pp3y3BHLhGL9eULNdxdQmoiDiBxLGwHKWkh/azL1/kzNCYIn3hssPc7XmyqqOVlh19jQ/exMnWt3jkShukiNmzOgp04cIEHShz82uW4QZHZ+XxzAkIkfiSItr4iPslyE+Hhr0hIHSCXbmdNqLje+1pHhFQdg7nJgwrB99tH318aSR4Mqwjw3ErizhhZnl6FNCd4SnEcClrM9PRFcqvPYxkTJlqXRpliRndrDfoiFkkXBzcXxYjbBQb3aWB2qwb94x9Z9/l3jF5hXiTTwlDTxNkwAfAdKLO3PDaP+5cTopf3JmJyhS0x/mwP7HoyKe6+HYsKGeru2iuP12di80XU185GGWkM4oUFn+fOTD9qA3t3QOaLvmkR7ngCoC5plpTL6T9KuG1lox7LTe4p2584x3GErTGe4/g0/nTJbq008p1re5Gpq5YdiTKkPIa9qNypBHW7XgjBEvj4yEY+aDqGCyh1G9Dyb6/eX9UenmXJvnGRAG8Fp4VG7r386nthdtv4vQZIp9ak02cLvO4AHPPpZCmHaTqonjeuEn5rKH1QPrjPUFG4r5SFgmuxtbKwyIS44LibczxeMHkGnO2O/hX5yLWrGzuwmAEz2RTs28w9r/APq1AiPf6FMxyDD73HMd7sUkgYG6qs8JrMRm/H9qOB0EVqS6etestBUVB3VWUOwYq8W6zzkbiq8smGiofGURlakb2aOhYlXZ5Bio5SPrpxOI9QWWwS9AUX 6XwaeYjn Hw/f2Gj/q/IszifA5PuhVohGmCMzjXS3kY5t5xC+LFMV4lkhslzAJNGAsGmUOXTNN9kBrQB2htn1U6OvkVPUvfQnzVp4iK3h3a2bZDFvqkbtQ7iVmPZLJGDy5zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 21, 2023 at 07:52:54PM +0800, kernel test robot wrote: > Hi Christoph, > > I love your patch! Perhaps something to improve: And I don't love all this hugging when something doesn't work. It feels passive aggressive. That being said, in this case the error is becaue the series is against linux-next, so applying it to mainline won't work.