From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27ABC25B4E for ; Fri, 20 Jan 2023 17:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65BD26B0072; Fri, 20 Jan 2023 12:32:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C026B0073; Fri, 20 Jan 2023 12:32:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4386B0074; Fri, 20 Jan 2023 12:32:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 401706B0072 for ; Fri, 20 Jan 2023 12:32:09 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1E65D1A0EEC for ; Fri, 20 Jan 2023 17:32:09 +0000 (UTC) X-FDA: 80375870778.14.18BD93F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 4A1CB18000C for ; Fri, 20 Jan 2023 17:32:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kzGNUytQ; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674235927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HaUcZ55B8arNmp1X8CFvPgSjjgacvYdFWg48TpRfPos=; b=OtK6EZkoZNDYzPrh5VXz8TvWGcr2HkDPgxKbi+3WfEFAoyhSGPQGkSVfQ1FlmQwlI/W8v4 Pt4G4nkJWrTdJHetsI62xyrWDXqRueaHETYI6cxT9ct75fQDlNxA1DFF7EPZbe0ef8kn0e 2Q4YiOXnsONW91VCg1rmC3BiaprZAa4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kzGNUytQ; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674235927; a=rsa-sha256; cv=none; b=VbRx1olKs/q0n68AqQSpxRtK2N2JSMkOUk+p5+sYYtTcGvoCdux4U7qqtanlSr3ByEW0AA Hx7TnMD9/sr0BVJ62gNTJO44vnlcOVJTcxonsz0LUnibLImOJJlZlFsscwC0Udhi3AT+iv qmtwPStO+9BnUCEbARfbbiVoIRb//lw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55AB66202F; Fri, 20 Jan 2023 17:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80CBEC433EF; Fri, 20 Jan 2023 17:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674235926; bh=66lCwGr0kp2dV1EmIDVsi3nb8gKPsiT1pssRkZM63gw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzGNUytQ/EN25BaE3o4Jm9mc/FX9YNMeRuRbcyWs1Jw5BvNv2RtE+xsUd5EhH4Diu GIVavSCtdeqkvMya55jk7xkTGvZrfwSJQ8Jbz20rEq3IOhz185yqUSv8+LCzVo7rzZ Efoxx1SXEcEgqqqubUmXGTtBWVvnevdTvlH89qxTUhK32Tii1oNvZx1Nk9J/mksB4p Y9mB6jY1UcioeghSLXHW6iHTCv5VxkSYpQFQTxSAZQTudCkdu9h4kOwEL+9oFwWqgP zvxzakFDHuQgK0BNgqQtjaOCWD3C6T18Is34IdLOCRsn+r5mt1HvSyDvVwZ92A+16B k59IQez5f3GcA== From: SeongJae Park To: "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , maple-tree@lists.infradead.org, SeongJae Park , damon@lists.linux.dev, kernel test robot Subject: Re: [PATCH v4 30/49] mm/damon/vaddr-test.h: Stop using vma_mas_store() for maple tree store Date: Fri, 20 Jan 2023 17:32:03 +0000 Message-Id: <20230120173203.150532-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230120162650.984577-31-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4A1CB18000C X-Stat-Signature: n9nwpkh5xtxdpnr8dwkg88kptxuz7ydt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674235927-690477 X-HE-Meta: U2FsdGVkX18sB5qVjaaTNUnM82ee9KAxMLRMG+L8R6PK+HmFIUvBMlRvlqjXdkwe6KpXE3fXowxhO4dSHHMPKV4Frj1+28MFLkAWDqaPAOSVL/X4QP2zxeznxtevmNdXV5TBdbzHeZ9BmRrA+OXOIbykf100dHrdDYgwQtTfim7Yut+TveDK1H/eeOo5ZN89bo4HWEl8b06R3x6Fuvzi5/50Uf9U1SmffpFvqFQO4NRWIOwEqt8lSkmBc/Zt3nbfaO0EHRzj7r7sNSlih8OVWyfNJi/oz59l3scmnli8wHLrq5MuTrDm3tWpIacTK9Yvu4oSahrawYx2xkrDiH+tVmIHYmrxGUcKjPd353OXGjI94hkbTwx1yWm8u+WU7QOhmuOl60lR68j4z7MxPJ0C7cYvHivtGtJvrR1w3dxXtLLpZzQi/IMMrl9+u6mXLuTeNOzOOgJElDCsW9LWKrJli+1JNum36wfczOGJTPUDZF+WfYJLviVi5BhsguMagnRZcPD6jmKC1XYSRRWwg7lStbuW8FHByPyjgwvheODSsrfzJBm57mF9yq6ofJbOpLgC7m2XqJyaK07wArnQl+vAVLCUeZq2Dpt/X3nQQr6xA63TtmMhJ0oWr1n6hN2RZB85b5qQRjjWuTMT9EQffzoyZEAyyfulrOa2Z1Sp280osUb8/y287YwgeqPU+KneqGv/UfIVXwngPNMRZSmdVivyJauenFMLMeU/AQrTJaqrdIkSY+xo1TURXReX0FgQDEJph45sm1rp+1jTKijMh/6zsa268PEADr4XTjCVvtmEqZfdxME+aWao/EhA2ZSB8OlEX2evGLgD7oYcaHJKew6Nmu+tjhGS6ZiC06bB4joR/TQbrLcX9wVyK81I+hwvSpIcn7h9cyBGofcCL4hCktBpgRQkhWCVCFIxziJc9hSxma+gLUu1X9NsWwngV5xQniAHTQMIMl7i+Ypw/TFz/GY j7iEwj7o agWN8chW86+ZNt+c9+G+V9c5e+KpR4mxtfIw7P07jVrIAFxklLkYTJshGIh6F/07n/Fr53YevCpu507DFUYrFu0WLPOAeU5tMir78IDnz1p8Kv0LEvWMVQYFLLc6aefB0FqyYXQH8OWq/MCiot+6Yu0cCZ2dh6RDjKI0ffztNOhlSpbuOfppy2ERWVUvYTaRIBzbXfdYzYk3NO6Dk7n97+P+6xxDUKQtX162LVLL/Dy01Xpu47t1KSegiDmuhVB/MJrPVRGQwn0TTBbSHoQOcIkTtfXt7LDfhi7O9vCT7YPUTRtHEKN9bTwGJXSBdAvaxrHuRagWD5hcgLctRef8lQAw2gLuD1fqCeccBw4MAvhe6NGVUWUdourgTQSXre88Jy9HtJYCnkEt7iWiXrr//KJxgVM8mq+939KFfkvRrdlPU9Oax4HxjSdcOoLswfpYMoH3L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam, On Fri, 20 Jan 2023 11:26:31 -0500 "Liam R. Howlett" wrote: > Prepare for the removal of the vma_mas_store() function by open coding > the maple tree store in this test code. Set the range of the maple > state and call the store function directly. > > Cc: SeongJae Park > Cc: damon@lists.linux.dev > Reported-by: kernel test robot > Signed-off-by: Liam R. Howlett Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/vaddr-test.h | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > index bce37c487540..c4b455b5ee30 100644 > --- a/mm/damon/vaddr-test.h > +++ b/mm/damon/vaddr-test.h > @@ -14,19 +14,26 @@ > > #include > > -static void __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > +static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > ssize_t nr_vmas) > { > - int i; > + int i, ret = -ENOMEM; > MA_STATE(mas, mt, 0, 0); > > if (!nr_vmas) > - return; > + return 0; > > mas_lock(&mas); > - for (i = 0; i < nr_vmas; i++) > - vma_mas_store(&vmas[i], &mas); > + for (i = 0; i < nr_vmas; i++) { > + mas_set_range(&mas, vmas[i].vm_start, vmas[i].vm_end - 1); > + if (mas_store_gfp(&mas, &vmas[i], GFP_KERNEL)) > + goto failed; > + } > + > + ret = 0; > +failed: > mas_unlock(&mas); > + return ret; > } > > /* > @@ -71,7 +78,8 @@ static void damon_test_three_regions_in_vmas(struct kunit *test) > }; > > mt_init_flags(&mm.mm_mt, MM_MT_FLAGS); > - __link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)); > + if (__link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas))) > + kunit_skip(test, "Failed to create VMA tree"); > > __damon_va_three_regions(&mm, regions); > > -- > 2.35.1 > >