From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F45BC25B4E for ; Fri, 20 Jan 2023 07:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 922C56B0074; Fri, 20 Jan 2023 02:42:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D32B6B0075; Fri, 20 Jan 2023 02:42:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2136B0078; Fri, 20 Jan 2023 02:42:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70FB96B0074 for ; Fri, 20 Jan 2023 02:42:23 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C470AACD4 for ; Fri, 20 Jan 2023 07:42:23 +0000 (UTC) X-FDA: 80374384566.22.16DF028 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 7DDE840018 for ; Fri, 20 Jan 2023 07:42:21 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674200541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gjcpDcyYUGSlaROsmdnWDI6g8nD+TYvJTPiw5hj/hWM=; b=cP4Qa4uoutBI9P9ia2fBlNDMDfw0drwJ7ZPSUSkBcxiufGZvnSBckjjBgpJDP+brYCFDwl Sdyy/73EHvk7t79Ybx9O6tDVGXjzneKvGGnnDLkbpAWyFee5aZBbaunyw201YgxU5dIZkv mKhn5dGHJmf6qoWIpSxezzr9QXR1I2k= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674200541; a=rsa-sha256; cv=none; b=6lx07gdIlIkCJe1Xse5j3Jq66TbJH2l94iQ88SH10vf4G4ee3J+MC/cKkv+P+8o2Vxljob BP7sz7VMdXJVQ41fdGLHbP3gZW5gttAatkrSQxQdoXstJzoIvQQF7eMDSgFqaknaqMsbdi 4e/PBRfLw1+3ZsW218g5oHyfBwpTxwQ= Received: by verein.lst.de (Postfix, from userid 2407) id 7E85168D13; Fri, 20 Jan 2023 08:42:18 +0100 (CET) Date: Fri, 20 Jan 2023 08:42:17 +0100 From: Christoph Hellwig To: Uladzislau Rezki Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 09/10] mm: split __vunmap Message-ID: <20230120074217.GB26815@lst.de> References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1ttgnpyhyf17udoofngp3w6rp4t9ehz4 X-Rspamd-Queue-Id: 7DDE840018 X-HE-Tag: 1674200541-357273 X-HE-Meta: U2FsdGVkX1+lMaIdUrXjjjpQzAr+jzAdgqCvKk4HJbUb4h8adXWiYjddTJHeQvmkmHoT2gDr+QG2wOxbnuip/P8BfWAH6kXBmG3iXoipgTti8zp4yO2AG9Qy5juDB60pMQpbqc6sYSIXLU0bWafaorO5sn/EXCNBCBB80Q6l9PNYxG8AUmctbbAtfQDxnKlpZG+aA8XURGaFuuCcIjnHajVKD55REspuAxqilif4arZrC7ZkfJA5Y17pnkx3Z+RmaUijl7Ddj4Vrl9NPyXpQT/hb8JwoRzDPECWR9sheHeiqvofIARTAlqwCksxMUgrTZDsUzheVOgSp2scLjloH168q3pGfw0SZZUEmypmBrLJ9H0fvWDphR/PalGSB5tk7uVKN+YYiy1Et9MIhfSa12EIZsFGJ7mZxp/4ykBoIlvDgxespRKyolZDV4bErW80cjTc/FBTV8J832DcxSUPLWXAwF6527AaJP/3tg3Fd70iZFFw1XRFqNYNWVXr0NhhHU9y39OBEPPBP+26oxq1n/4EyLZZxvd61nFLhLxQSeglkdy7e0mFGgryqAdmr4d4V1QKU8gOp0FHeeHhIx1Y1zyYJMDT51+UiT6E6f2bBSW8P+jczA7gRhKRgvxFISBgRbkl8ZqsSCgHPVyWyyb8gTGLwfPw9EKwrmM/Z+IUU0u/hz+8+lCodOqmTkSjE8Jp/YExwHSKPL/AgT1ezkePkM9QqNN4zPmDm8LRCphGiia6DDOqPBy3L/QU/j4it4rVN4IdJBR8xYyu5t2abGThit0OEEFEKC6XzPksmDGCS9nUnICmZ5NCMlJpUgHN65Uyk3kRfHZOEAN5MzcDqAAVCkxFkmJBqW7NDs3qx6M4BZB7scrUNbY78wp0Gdir/FxY02lFncNX39nJClH4iHqeQkPQ3++HLJEWOoY5ulcEakqORcNy2kYicTsQrB10mnBNpwjlJk0AL87dvNAZeYA7 CaXGniSk OU97jXxTb3bzSBAbe8AaXDw5lbZbgVcQ554MtsOark/EZycZfET70KfuZJfwF9iTu/8ukkuWWqUn0BIe60kxxZh59wud3uUpgiGO0ab/MrfZN/1S2HyqMnwP5Dg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 07:50:09PM +0100, Uladzislau Rezki wrote: > After this patch same check in the end of the vunmap() becomes odd > because we fail a vmap() call on its entry if VM_FLUSH_RESET_PERMS > flag is set. See the [1] patch in this series. > > Is there any reason for such duplication? Mostly just documentation for me to explain why no flushing is needed. But I can drop it.