From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F9E7C25B4E for ; Fri, 20 Jan 2023 07:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1F3F6B0072; Fri, 20 Jan 2023 02:41:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACF896B0073; Fri, 20 Jan 2023 02:41:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE1E6B0074; Fri, 20 Jan 2023 02:41:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DD836B0072 for ; Fri, 20 Jan 2023 02:41:44 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 578E11A01B3 for ; Fri, 20 Jan 2023 07:41:44 +0000 (UTC) X-FDA: 80374382928.02.EC022B3 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id 62ECFC000E for ; Fri, 20 Jan 2023 07:41:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674200502; a=rsa-sha256; cv=none; b=63zNjPBSQfWS1lEesYs9i7cwM+GRttRuGILhhQPZUlMWzI6cC6jxXCU/qCwCVyGfm68dGp tDCojayUVux0fhusSAc8E4f0w3+xAZXPyUREd6NadqLqVXZu9bvhOz7FFlbCYXSko46fKR wod0CpAVj2fTGCTFS9a9p1ztn42heQI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674200502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FZBKsX5KZCtocSd9M1NbC4YJupcnA1nFpiaJTtrPUaY=; b=xCKR4ghFAhC8PJKS2fXjL6GoLzaEnidnNUIPaMPnHMghgdljaIiEDhRXNwwlyDE5p7jPbQ VljHNz2yCvGTgdX84Xuuob0jPqQzObnEHQW98+lKht+oKU1NTSi9PvdX75GymjtjZIJImE JGSykv1k0mo/oUFh+q+1LYFf4wivdls= Received: by verein.lst.de (Postfix, from userid 2407) id A62FD68D09; Fri, 20 Jan 2023 08:41:38 +0100 (CET) Date: Fri, 20 Jan 2023 08:41:37 +0100 From: Christoph Hellwig To: Uladzislau Rezki Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 06/10] mm: move __remove_vm_area out of va_remove_mappings Message-ID: <20230120074137.GA26815@lst.de> References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: 62ECFC000E X-Rspamd-Server: rspam01 X-Stat-Signature: tspcqmjg94uireq31e9w6yre8dyb1cxx X-HE-Tag: 1674200502-827670 X-HE-Meta: U2FsdGVkX1/NJtVBfOcagpRFLREv3opM9ipuYHrQtqgehJTBBOmUEsPBRJ1tPp3ODWFtrGSlZqyBjZVmUnIiSUzv2GfpBJ37h+nA4L2AA2Dbz0ECtmdOdvZE0YTL5HP7wqh2PGAM3hDYbuwtS65kXH1fbq8HS2HbY1QDR/caF3ousR5LK/yzLseyfCIBF1ukYmwckFwYp+FsO0OcCiHdFlfxBeqXaXbf8yJpcR9djhvWzcnWcMeyC7fD2iFK9T5cRVryS6qb8A6retReyvXoHqyGfoYl9bi50nb54KMSuvgTuXyCf2+UH8NuLfhS4n/wVSgoJUJnyu4Q97KWScwBq0L+Bga05d7Qto396GQDfBwwM3dMxy93xxBOYF+1mGwBIdQ3jRZsOY/l/NuZpEu5T/NiDmu5qjcXxhdgUGuIcF2wZWBr9/rXsD4OJdPJl/2BOdI3TSSIl6NzEBfqBS0eDeTpjGw6XizQ50PRUZhocAcyHcf1FCNUmSZ+fcKFETrMhLyR3RKKrWobKUHp2GlchnovRiui0RUthF1hxw4qZlzNVM9N4CmNCHbAPpm4rZ0t1bD6vre+d48uEgm3ioumnKfGr2I4J4ksFSbkGhnEVH5fyPeMoyH4rzqyREqmuK9Fcak4S1nOL6omrUkB1a3yfRsaWl36tLT/MeJIElAEtjWYa54pu9hB7Ps+fIJTTt4VMjKRox/Zq4dJUgxQZgtnvHDQhsbcRSe2bDXVFGe6q5vhMf7G191rHh97SMYdZ4rJbVm3jzG6GgbYvpfptri6BYnOesXU0PmMXDGY6ieFyGSnUzRwfiaKqb9lVDg6cX2DhF0ol48B2cOxS4zEla4jryCbCGyovrXnlNlkeO0ybzyt9uOrChTHns9PRuyUP5Uat+7bCIuELvsh5Pa8GjSRtmMJK59AeuBr9W8pyoMq0YCRyxegp/+tNv7QDq3BvO1bFx79kPjNo9wtg4FKhmM GUpwojse mLqo83rLf4L4s8AlWcOraBxu+PXXZuUczIgtxVScBLWOjahKhVAf19gvqhExm0KphfywhdXgakzT1K85NFnp+t03+DoayNZP8Ny4aH8J5nF3kZQArE8ZbOWkxbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 07:48:48PM +0100, Uladzislau Rezki wrote: > A small nit here. IMHO, a va_remove_mappings() should be > renamed back to vm_remove_mappings() since after this patch > it starts deal with "struct vm_struct". > > OK. After checking all patches this function will be renamed > anyway to vm_reset_perms(). І could rename it. It's not that much more churn given that the prototype is touched anyway.