From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8746C38142 for ; Fri, 20 Jan 2023 01:45:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A0396B0072; Thu, 19 Jan 2023 20:45:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 328A66B0073; Thu, 19 Jan 2023 20:45:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C96E6B0074; Thu, 19 Jan 2023 20:45:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 082546B0072 for ; Thu, 19 Jan 2023 20:45:29 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AEF17AB36F for ; Fri, 20 Jan 2023 01:45:28 +0000 (UTC) X-FDA: 80373485136.15.A9920A2 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by imf05.hostedemail.com (Postfix) with ESMTP id B574F100005 for ; Fri, 20 Jan 2023 01:45:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=n6Gfbji3; dmarc=pass (policy=quarantine) header.from=amazon.com; spf=pass (imf05.hostedemail.com: domain of "prvs=37723bdf7=kamatam@amazon.com" designates 52.95.49.90 as permitted sender) smtp.mailfrom="prvs=37723bdf7=kamatam@amazon.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674179126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/JE9hSVjD7t18bE2BYaRoBBydrD5mKkECHvxwn753Ns=; b=xRk7O3y/YUt76Jmyem+pIBxTsIE6CTCRNlLzFQeWoBZvn29GvbCuCF+dWuZulWnuxdHO5j r3FAkhhWRbx6p1IU6KdXAS/riUY/pvs7Ym591ItuWGAVaVQt20bCNRpvR7VRnLxd9FC0oa 6IGFXlsr0xdd1MWsgxn2iwigZ0jnRms= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=n6Gfbji3; dmarc=pass (policy=quarantine) header.from=amazon.com; spf=pass (imf05.hostedemail.com: domain of "prvs=37723bdf7=kamatam@amazon.com" designates 52.95.49.90 as permitted sender) smtp.mailfrom="prvs=37723bdf7=kamatam@amazon.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674179126; a=rsa-sha256; cv=none; b=2L5V8KkkE+/LSNAIlveeegPjetuZpTwYmx6gm8KmVF9DVmXoUpXHXmND+d0rc5SRUPeUZN dMCGoWXNG1Tf2tzjmW7x5HoeJaXMvOINGmN7t/xlYFjnAT4xN6zFboIFHCYbdDz+F0xXi4 FO+oc1oeiE2Y+qqT29CMX5bJ9SQXpkY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1674179126; x=1705715126; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/JE9hSVjD7t18bE2BYaRoBBydrD5mKkECHvxwn753Ns=; b=n6Gfbji3fVSGMPFCUnbAY8jGA++h3rTYgbAdFiLpLbJvMuPKnSe/qo48 XnruzUCm5gDQyi/Acx+XyDMP/yjFX4CzldqjKm+HkWlXlje7EEcz/vyb/ hCJoFmGvUZz+1cy1oNGR39F+fEXbu+JlTclmjKpm1XovDKAkiHjd28H7A k=; X-IronPort-AV: E=Sophos;i="5.97,230,1669075200"; d="scan'208";a="288474623" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-m6i4x-529f0975.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 01:45:26 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-m6i4x-529f0975.us-east-1.amazon.com (Postfix) with ESMTPS id 70466439BF; Fri, 20 Jan 2023 01:45:24 +0000 (UTC) Received: from EX19D010UWA004.ant.amazon.com (10.13.138.204) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Fri, 20 Jan 2023 01:45:23 +0000 Received: from u9aa42af9e4c55a.ant.amazon.com (10.43.160.120) by EX19D010UWA004.ant.amazon.com (10.13.138.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.7; Fri, 20 Jan 2023 01:45:23 +0000 From: Munehisa Kamata To: CC: , , , , , , , Subject: Re: another use-after-free in ep_remove_wait_queue() Date: Thu, 19 Jan 2023 17:45:07 -0800 Message-ID: <20230120014507.827289-1-kamatam@amazon.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.160.120] X-ClientProxiedBy: EX13D43UWC004.ant.amazon.com (10.43.162.42) To EX19D010UWA004.ant.amazon.com (10.13.138.204) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B574F100005 X-Stat-Signature: 3w3ayetmg8i14mjyco67b4b4hqeshkf1 X-HE-Tag: 1674179126-116294 X-HE-Meta: U2FsdGVkX18lPBRSSboPaW0K+Ju8sdxsIZIAalh1quSeiXIJxrDmTEt+4suQtqwsTRZ6D3B7e4BEMsXC9yAfbhVeUB+AxbAS97C2pisBsQ7JVA5Ame2gl8Jb1cX81E1nQ5HEuCZIHRIuVou812CzOjHWGqbTRPD1zTxs7u4awaKWlya12Yo4FbOiMn7LnuxRpqimb9c2wX1dmwfI082D+MxKC7qDDVrA/rgIlwv/nS3hDAMmZe+McvakQvl7QgfWKgOOQQxFRh2W73b/PvCaBVKKQOpFFAs6pvdbPRdyMh65MQcmZ3LazFlsuIhzZniXg1cTQ0YS1fX4ba8s0WyoCcFBJ3QYaK8+3HP91ja+nEznUrktYPLfNHr7COcvMBcYgrFQjvV+PqynDM2mNW/BW5BFeQoEJ+CIOk+w1U9/q3eAubmzycGDmnCxKMmA5JlccpB5oLBdHwGaka/ZlHjpbB60zRC1S3NcJs934FhrpdX68C8Oc4c1x5TFl3lSsrKwu8HFzXjsZDrN5RqkKNccEKPnb/9F3bozkwSf0GfY6PRhxxEqWlEHr8eV4JdA+p6uM8ChvOM9zlaUeVk0MgoIaUJXUvbRu0L5FYtYghgIFBJVFnT1go84y99DGDxTShHKcULdYNMtQNqwbhQzOKkZGWZRr+TmvsmSzj4APL4EWBM3qM5Yb0Orn4MjWll8mMeg1YEH06Gc3UW28o6MvZEEUgK95B+2VZIkYMAuYtD6jKYokz8kjp87eoUNhrknPN38zNXtH+cgqGcaM/24DjQu+egTxSls64AODUdKAuisvQvlCoRxpOE4FR1jI0p7jwVpEFLBbwyIbPLLLYyFetHkqg/MMdrgzXmEWtYGqcKqWHqUVOmVdq3ZiER5B6MWvbO1DfAML9hapPlqR2VevUg9evPFtAQA2flYCq5s0pti7uqeLs8/s3QE/urctZisYFhHzb3cGILf5SpihHxQGFg MJ78G838 Orf+5hqdfPYlnZk5oIBQR5szur+BPsrKS8k51pZTQzFfu1o2h/qnNwzpgkP9G941dKk7hghvxn6Yua+8bt3r3MX9cGdSHJuKxWqYlOM3MYiahMgYmyEpPUBWi1SBmu8BHZMtVvhHla1KBVghjtZ5PKKrDUpt36boYFRKb3PMmyuZUAKKvl1p7soRCI7WJS7nE+zmUMd0a5lx+o17FEPq94qydfuz0i8Ga1zv5ZfrovmsjKiA+zqnnDMTS1OGVycmvA4dyOPEdVdMdf8JMjjrJg0zv0gip9eKNYVtzzwo/R+ATg8Egy0cEJf0LZ2DxBebK97qBkZSDM2452B11nq9RCka+pWZJ0O1ptzIVz9wrCXJkTc6fbWTIT1FpmQ/605hJnj8Chb9DAwojkLJ5SvqFTR0tO4OGBEdkx//NMWQlB6BBZP35gVb18nN1iKtHrcSZPGkWmdeD26OUVrSUGf1TDfp1F0o3ckgWVukDmj7trvgcpivV2Q+viP75tcWNUQaixb7gMkAmgikY7HLkVCmhqqiiMmJY+jAXaph7ptI5mP2ZzE7HtI77Z9U0SJhi5mUnJKKhrhDXQZtbeofoxzYAbz7suD9qD6//LvUkJjkWLorHbEE0MkRYfSN0hOFmcPlO+4gjyKkVBLvI8b9l9GfuTtjP8chdRzqPaitxb0m0KHYDZX+PsutmVZzj2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-01-19 21:01:42 +0000, Suren Baghdasaryan wrote: > > Munehisha, if Tejun confirms this is all valid, could you please post > a patch replacing wake_up_interruptible() with wake_up_pollfree()? We > don't need to worry about wake_up_all() because we have a limitation > of one trigger per file descriptor: > https://elixir.bootlin.com/linux/latest/source/kernel/sched/psi.c#L1419, > so there can be only one waiter. Yes, will do (and will CC stable). Regards, Munehisa