From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 174CDC38142 for ; Fri, 20 Jan 2023 01:04:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DA736B0078; Thu, 19 Jan 2023 20:04:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 963D26B007B; Thu, 19 Jan 2023 20:04:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803BA6B007D; Thu, 19 Jan 2023 20:04:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E27A6B0078 for ; Thu, 19 Jan 2023 20:04:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 366471608B3 for ; Fri, 20 Jan 2023 01:04:05 +0000 (UTC) X-FDA: 80373380850.23.6F70787 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf29.hostedemail.com (Postfix) with ESMTP id 304D812000E for ; Fri, 20 Jan 2023 01:04:02 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="HNvX51O/"; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674176643; a=rsa-sha256; cv=none; b=SvvsUqUi3zRh7K1NnoMFib2GYG8xN29Xw2yH73smgPt0EP9sM1gHUtppmK+x+JJffRmaXF fXj1QNreu9v/VtUuMzP5N8LqfYiOOQv0DdKVrfbTkxmnLWldb8nr2vLb/ET2HrUpp1+xtU LW/SNiYrYKcqB+bWPwXI00FmeLAfa/Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="HNvX51O/"; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674176643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RMyK8TWBy/rCRY+f/CELnWHAsbOxEp5tJ/kKh7SlGrE=; b=loaeA+hpjjSW12CjHxPQS/Xirm4wI5X3VXwicx3mEGOpTzfXZrsgg0M3I+qbfF1klysOas 8GXr78Z5tcXGyku54Qt/sZ+x3v3QTgtTEQmggPdtA1SFRc5Gl6cA0Twgd8qOrAn00xlPzf mKqIsy5zNkLrRiSNLAfUGS7ZoOZ4s/s= Received: by mail-pf1-f175.google.com with SMTP id c26so2856082pfp.10 for ; Thu, 19 Jan 2023 17:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RMyK8TWBy/rCRY+f/CELnWHAsbOxEp5tJ/kKh7SlGrE=; b=HNvX51O/DEprXKflx7pWqaGjLOmylpOJlGBu4RvAtyIGoWOf8U7lNla8R/lxB/pY7w 6T9BXQ8lPsUoUa7unGyKu+xDkqDQjSGqhnaebMz/E+vQnvXwkiXITiJCSaQK4OMwelJd qDigrbkkGoU7L5umpJREXH5gQODW8jcOSvVTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RMyK8TWBy/rCRY+f/CELnWHAsbOxEp5tJ/kKh7SlGrE=; b=zSLnNMTDrOkBKvb4xuMYzHFNSesyo8v3d9xFWiXerOrx4RtHnv5q6E2+2Y27JePqAB OIqXx1PJUZWUVti6Uq2iZze2QEtTZCZcefNZUQacSx4MEdxtRvHBIZqPTo/D0N6ZMuHr ZirwmsTssqRG+YJ1ce1sh2MG1HqOY+uR9KWr6kXsGQivEx28bMb7OMU+rIFHy5HE2T7f pns4SWEUw+95/uXR05vETyLyrzJq/WcVrmd/QdgnY90/DKkyBuoRjLglE8WhzV0QYtdP 81fkusCHv2oiJdtU/ZhwIcBSYc78gAeCn5+nmNzsFpLcAesb+1NSwd0DYyJR85hgl7Wl a6nQ== X-Gm-Message-State: AFqh2krqXJ4F1XEzuji03DhyILuBaSbj/WQpzYWshQUxLcoEUCoysRCQ sXEqhaBkRfuemBKACwXsHFE8Rg== X-Google-Smtp-Source: AMrXdXtTKI2kkFnGFw4R9p4eZUplQk2pOiwojsYgvuPj7O8XWjxV8VJBE5XmixgDIcb3rYne6nRs3A== X-Received: by 2002:a05:6a00:bc8:b0:58d:97cd:b65a with SMTP id x8-20020a056a000bc800b0058d97cdb65amr13351335pfu.26.1674176642023; Thu, 19 Jan 2023 17:04:02 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 134-20020a62148c000000b0056bc30e618dsm24694079pfu.38.2023.01.19.17.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 17:04:01 -0800 (PST) Date: Thu, 19 Jan 2023 17:04:00 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com Subject: Re: [PATCH v5 26/39] x86: Introduce userspace API for shadow stack Message-ID: <202301191703.9E24A4E52@keescook> References: <20230119212317.8324-1-rick.p.edgecombe@intel.com> <20230119212317.8324-27-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119212317.8324-27-rick.p.edgecombe@intel.com> X-Rspam-User: X-Rspamd-Queue-Id: 304D812000E X-Rspamd-Server: rspam01 X-Stat-Signature: c9wmhwzsxdc5eide3d16wiwo18gps8yr X-HE-Tag: 1674176642-800241 X-HE-Meta: U2FsdGVkX1/hY5NTNbDSxKKp2rTRwPsHjuHd97hgUA00Lowf3MFrojfnqGnXBTFeFQ+W+6F/IGsjeHcxRBl1mW9SkP5k4o+c3xp+xmguY81pjMSOmhieSTs4CTVFHViQ2zN45af2CZlWcbMYSi6laQX5l9Dw3bCt4mDQVQDekHjtrgVr4OZXUNcLs8KchBquBTu/D7MXtPwzh3yGBIeUWypgk1BqagbQDhlQ1gSwn9d/hOD04qkFPsSRrE/uKog406aqyi1C4yQZV4yK7oWZLcLPDWgl4d4NlKT7jjvsYB8wXidHR2+rL+iuhQtNZu//TS5e+hDlzpMN/iAkFOCzevm9U+c9DbGhaBtNFt5+OT5OxjuTdTRmtV2Zz35Wk2FA4H8/4gakwvfPoSD51auqJlnCOEpQ80GmhahEM13fGRCqTkeM+DGQdCe5ctAQIQzaJfZFITgrRTDTNw2OKVzyXQiIR5cg6a7RP9KJR1DwR8bAzEjcV2SP1pnOHVYEoRZfOSEA6G7muPM5wFQPrYVsPPPCe6nsCmcws01wp2GYYOsEXHTJmfGtnWpIpdOawcC1Nt3GvOPzH2GFuHrltegRftILDYrnME+T33TwkMsjpcZIr/ZFYbpN0TP+KWQ78ZLaYKSKcfl+1iJLPHQO7cxK4ruJoyTbiQaGYYovsXyInOp4SmkIsBQeckQNEemPULPPawmxH+avOeH2JT/zFUS8STlXP05LUVUwV4I3gWedIPCTA5RXwfPhWc4Z35xbIwe4BSDmVVZkxfpS02tdJS0TyDFeeGVtKS1z4uEHvZZ992gZy9zEEAnjkjpN+lToVG73jmw7L+VBRbSADf6QAvy/WvEjypXlbWVWxNaBuzKAzOjAAJmYKbLXOVfpJJWUE03pCcJM9TGX3ACW8NHAgVE7lZlBC2K20NJfxCvnvRj6GkDI9JdU0VgGd6n0ICAYqrA6v3OUVOuyh3T0ohuWlsS RllyPlUv /oDWMetYGbHyqQw9B0lf5ygOhJTSrH/fny6pTUpBisvrNxEG29Sxi6uh79u7cKhmhSD8KL+1RVDDiej/6dJNPAeg5jYGKRP3RGnT71pKMcmGTIzpDcbiPuEshj50XLQ1H9sMBmFcKKd1w9Dj5iTtYvi+7pzAPIopOvhzBLQ6Gd0LCMNjZQL235Er13gPdBsFfDOKALsxwwY/zFm/rDRHBiehRWvkG0F2c2nYGf+rqzf+ZQE//z/1w1p4iq0DGzruhwHb91nE8Bp3+lAoi5uFzE/LvwsQf7fvBeCQ/rcsZS2+XS2uD4ycf3QAdJyP0Pn+lBoiqTNF7o2R3/oX6LKiYxh+73na7k4k/yOmLb/SpVxlPeu16ojJo6dl1F4GqK4b7e06wns1ftJrk1Yy3vIvsBmlptr54n0AeAy3WDuM2GWnMhdMvceyHGWuyyChPtCUrBblwDPq7OxbtbJjQHshLb11pC9XPuSyXQ3qOnbsUoPjkKas9BKIqZynXHxegElHNb7G+nWJdlrjU1Rgj/5kci5cVO8lvmlzbsF9jw213jd9AHLE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 01:23:04PM -0800, Rick Edgecombe wrote: > From: "Kirill A. Shutemov" > > Add three new arch_prctl() handles: > > - ARCH_SHSTK_ENABLE/DISABLE enables or disables the specified > feature. Returns 0 on success or an error. > > - ARCH_SHSTK_LOCK prevents future disabling or enabling of the > specified feature. Returns 0 on success or an error > > The features are handled per-thread and inherited over fork(2)/clone(2), > but reset on exec(). > > This is preparation patch. It does not implement any features. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Kirill A. Shutemov Reviewed-by: Kees Cook -- Kees Cook