From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C65FC46467 for ; Thu, 19 Jan 2023 22:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81ABD6B007B; Thu, 19 Jan 2023 17:42:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A35C6B007D; Thu, 19 Jan 2023 17:42:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66BA26B0080; Thu, 19 Jan 2023 17:42:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 531D06B007B for ; Thu, 19 Jan 2023 17:42:09 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3366D1601FE for ; Thu, 19 Jan 2023 22:42:09 +0000 (UTC) X-FDA: 80373023178.13.B811521 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 8B61012000F for ; Thu, 19 Jan 2023 22:42:06 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1KV80hcp; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674168126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jlNiFybnHxsz7LTX0a7jdZ2Wcl3BJJ/ksBKd6D3kTLc=; b=47hL+Hqe2JDuibLg4cA2Q6fveE3ad3aaa19BnooqbAQXEq7IR7lqSrrJ1znJpoy6F1ewRk uF9ny/icFnHzR1TsCebrvR4DJ/625Hp7ziaVMnz/ryqYw9DEknfbBdIqlguajrjJaEb8ym 03J4QQ2+PSC331DNqNhKFduNX7OAizY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1KV80hcp; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674168126; a=rsa-sha256; cv=none; b=F4ISiTYKQtFtgUKDuquy3DUpMuehrP6uMdabmaIybqHERPNUsnZik67hPhVfMAenz1XqkX Dgg+VJw1lfXpeBJ4GHOrHeEcxoWwss9tfP5bBlXYTDEDEhFxjf3sD/MZQBiRXCycUZthoc kUpuxJI7K9rV/bGDH0j0rAqLl4YVGns= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8CA5D61D8F; Thu, 19 Jan 2023 22:42:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 983C3C433F0; Thu, 19 Jan 2023 22:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674168125; bh=H9toCFN/mRX7/kvCHEF4NqPLWqqxgNLXk0255cj541U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1KV80hcpZAV1gzmTxGhDr/HNE4i1q4e6K+KrS+ZQ3aCNZ3Nd9S9x/HEZFMmse1r3X qNhS8yXZH7B032GI/Ift0yqauxHssIHvDDatp277PeUDqjcWox9AupR9+qNcBc/Dta C9dE6pqE2n1k/NDn8ICALv63/2OsfmHkt7llgzc0= Date: Thu, 19 Jan 2023 14:42:04 -0800 From: Andrew Morton To: Vlastimil Babka Cc: "zhaoyang.huang" , Catalin Marinas , Nathan Chancellor , Peter Zijlstra , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac Subject: Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak Message-Id: <20230119144204.a5a67be85544cd29cd656a5b@linux-foundation.org> In-Reply-To: <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz> References: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com> <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com> <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B61012000F X-Rspam-User: X-Stat-Signature: ftx7bs43b9ydzr6p4d79s4y8zwcwwcjw X-HE-Tag: 1674168126-747001 X-HE-Meta: U2FsdGVkX199bIYBp7jAr71htdHQ8BwhZQnS2k5MtU4oW88e/7KRHswVn6hW7X6UGlfOWgzRnn7Dvb8NHIxUq19Rt2xesySewj9oKvzhYVvzw9OUz3oa24XcIkq1eQUZcHhEsB+JnCgt52EPDTe73Bx2gdYBSBd4KMC6UAFJBseslgZlvHuC8ikzk8gCkiAvwN2IMhOdm1XtDBpBRZTU+NGPzT61hQcZlIVBUtYdYRx7Ei2J+0KY+ucveIJmsknraLd2nXVnwjUyUE6ZklAFLCteWZCMgfmvF8kKSZGSYFr5LsZGCQG9ox/qlL7fz/emSDkFwxcxTlM/ImGfKwn6oPIyFX6AIR49IxHE1MwLn38YMS2ZlBNz2z+puRPiVa+ffAHnnJfqOo+CvAnldqp1SxvYRmDupjxzeynQhcJG9dkzI5NhKuUg/Y51PvNyDpw7uSgVs1kMqygt/u4VcLCCa2Y4EF0e5YwHQHElJFSNweJCAH9uaRsyhFjuAxljHbEzCw3FOdM+JEkAnhV3DFmXEsIkvLfyPwWNxstYP0aad/ZkaFmQNWCAxsSZxUnGv/NBR0gEbF1oL3MbUs9be3fHZWusoX5+JBVDsunChWBq1kRBdEGaBDfyjmfe2C+42cXlbkdfBbakm401ERgyorQEgxJt8i+VMq+loQrMjhv3XeCKyJIW7XZzTdrIV5pWuE0d+dJfvd3UBwLo02qAnuQ19Q4qbLs9BsUymZwSAOEt6oMuDzLeNsoSOb2JkzFb4IXQ6srfervjocBrL3ytu/oJ/6iTPaWgfOZ+CKNe6cFs1PmUXx4xPDuD1mg0t4CWu/f7QM0NHeFNy11Uhr5Jh6EZ9b9b9Td8tm/T7Lr8P5GXx6Sfq89/2RYzfoVVSqsXA/xA+ZJLDZLabaauHtjkd2Cxz8r5i1B67umcwIl6QT6EErROpmfYg2AqvookbfDNHB7RsuKbfWc2ocKdDpVDDjS Jhf0igdh iuQX9xo2N0XhVjXiwNV3amHEGPXaJXcEOtoQh9YrYtpug+hD+EchBT013fiXU4orArnj6cjiVZDIHdPM2DhCRyA3e4LNpa5idtprONWOBlTR+tfYXMbO9mpGFewPqzY064qCIkiR59xbW38XbyKxcikluWLKXadV+fFxl8lg13sHX1s6wAtAI9ts04aAw3ABZAyOWv5OwG0nZNEaGDpgB2IW99xIXTq+5XKuNh3pLLIzl4IkIjq8l169Cf5/uKuJD3OtpzA70hd7NmEkujpPLzllys1/39YZdYQ8uaoUHkay7rnK3HbOW6sl4EhzCm6w2VLiU66uoN+yPkGPOXA+wPD3NqcbbCRMduAeFo6Dh9/IiIV+7+wNoj3GnvCU2qD2WC27pcNJomrrMTQg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 Jan 2023 11:32:36 +0100 Vlastimil Babka wrote: > But to be cleaner I'd also suggest Andrew adds the hunk below. The call > to stack_depot_init() becomes no-op after this patch so it's not a bug > to leave it there, but it's just misleading now. > > ---8<--- > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 91dda5c2753a..55dc8b8b0616 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void) > if (kmemleak_error) > return; > > - stack_depot_init(); > jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); > jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000); > I added your signoff to this. I used not to bother for such minor to-be-folded fixups, but now Stephen sends me automated nags when his scripts detect this.