From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A6AC32793 for ; Wed, 18 Jan 2023 16:44:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B1816B0072; Wed, 18 Jan 2023 11:44:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6622A6B0075; Wed, 18 Jan 2023 11:44:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5510F6B0078; Wed, 18 Jan 2023 11:44:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 49A986B0072 for ; Wed, 18 Jan 2023 11:44:04 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D728F4095A for ; Wed, 18 Jan 2023 16:44:03 +0000 (UTC) X-FDA: 80368491966.22.20B4848 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 3BC68140013 for ; Wed, 18 Jan 2023 16:44:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674060242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XTcn6EOmvdcaySj22rnAGZTgHq4wvd/ke03TGVcbMbc=; b=GaeVcgay9H9rSrzwE7QiRaJMdL4CtPsrgQqblRpkNxqhvi5cgxiHa+kYa38/IZThcjY2di eQWtRqbvK6o+v7Go+h+cl/8y58mji4y3FKvGjNEjbFLcYM1UEqfMG4gt+CE5b1SxPn5610 U4geDDk/e8nChehR2BmBbBX6Oa0G+f8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674060242; a=rsa-sha256; cv=none; b=YqcYJEO7+Flk8jQ8x6+zukknN9ezvq4YEy+HyoNtC7ix5RCT7uLqHGqEqBMDTbRviev14m gf65SFfkamhIrPVDcuDls0AQvDbGI6p6KrKTl8RPQvYIKBxf/k8Nvqk3ohaaTspQvOApY4 Hmee1kK9jHO2zqyvxLoOb29Y8azsYZA= Received: by verein.lst.de (Postfix, from userid 2407) id 6550568D17; Wed, 18 Jan 2023 17:43:59 +0100 (CET) Date: Wed, 18 Jan 2023 17:43:58 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 4/9] shmem: remove shmem_get_partial_folio Message-ID: <20230118164358.GD7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: xzx8f8sbxpje8u7otd1oahgg357mp186 X-Rspam-User: X-Rspamd-Queue-Id: 3BC68140013 X-Rspamd-Server: rspam06 X-HE-Tag: 1674060241-579487 X-HE-Meta: U2FsdGVkX1/1NPcCpFfZX9W+aGAaBNj32RbpzShgJpeIi/KJdtpQ5tR/YFG9paAni5ITK2Xoe3iKg9j7bA6jav+R8EzvSrXFAVSjwcalOX3DQMkMMVvTKrVjTCJhKfmRSg8xwBv81QlEyYl7cgD1xQ/SyccTffDa0ZoeYbKLyfUL4ZJakIVM1YyCI8hnKClIgjnjbbthHQ5fnJG/7nw3aVEKMSZAhmjDfgl5WmNBvM9BDlkPaTVoR2qT7UZ6MKfeWEhOg5/C3vDJJDbn7M2fdl3V5ZquUbOHSVrPzVZpQA3GMegrfRZPwrzVZUzx8iciyZbltIrsfEf63bouy7OZzNJ37zkq2D+nZyXnulAf8Ip3O3C9Iwt7LSDheope2RJFnky2H4+UM/Z7PmSQy5PPsLCBurxY1E0TKVGucBCs/gHpdoH8/S1vauUjvnqMCM9z9jrMuIXyrp0p455TjpD19cSs5BUokH6Q2jj8OD5s0ByniaqBY8V+43ZIUPY2v5ad1gC7deVxM0sV4AvRibEauMZnLsTa2i+DhL/mM03LfhNb6u69qtMwJSHfEYX4ggon8hFnYeetoSVfacl6dFSCS8w0Rq3BrDxbIeCIHYVekB4LJ+lLC8QNwOhC9KOHQ/aCNr2lZPki3wyAO3TOHZBZjWAyyC1gpUV8aYGiX6gt4nNxb/3LtsaRvM5Y35PXTwq1Y9UtNddUm8Y9tyWUaOVttRYlpzQcCNC1NCKnG5z4EYOglRAu4KtRQPy3cKKJBQH3C2wx5Jz3lfGL6qF4tv5rtRPPKNhj+MHYokbb3jQVpsoIXAZM8EywZp8U9JXwuJm2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > This all seems reasonable to me at a glance, FWIW, but I am a little > curious why this wouldn't split up into two changes. I.e., switch this > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency > without a behavior change, then (perhaps after the next patch) introduce > SGP_FIND in a separate patch. That makes it easier to review and > potentially undo if it happens to pose a problem in the future. Hm? The minimal change to filemap_get_entry would require to add the lock, check mapping and retry loop and thus add a fair amount of code. So I looked for ways to avoid that and came up with this version. But if there is a strong preference to first open code the logic and then later consolidate it I could do that.