From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65A5C54E76 for ; Tue, 17 Jan 2023 19:16:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60B5B6B0071; Tue, 17 Jan 2023 14:16:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BB1C6B0073; Tue, 17 Jan 2023 14:16:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 482DC6B0074; Tue, 17 Jan 2023 14:16:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 365C56B0071 for ; Tue, 17 Jan 2023 14:16:20 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E979A1A0B43 for ; Tue, 17 Jan 2023 19:16:19 +0000 (UTC) X-FDA: 80365246878.20.4A4A95C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id D76E2C000D for ; Tue, 17 Jan 2023 19:16:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SmT6EUBn; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673982978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gkr9G7bxpoF9SeYxWK0ky3ycJSU7j9uwmK5oXFyGYYg=; b=URwNrK8Nm9IX4JHU+2cYVVcKQmm5DTlvZskr8avj4SPPc0UG4KHqkKs2bspF6BaTTSScq7 TTQ3tpYeDa+F1tljtTV8GkOfwK2zaMCRk5eIAj5heFyyBTibW2iLVu99X1U/0n3xNtf+yF oUTcq/En6XjXm+JrNucCIbmuo53F2R8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SmT6EUBn; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673982978; a=rsa-sha256; cv=none; b=ZrXijUmmi/nv30FJv1B5PTiWEp/xuvggIXZq62vPjzi8DWHvWEVyPHkGuwBojlL2pG3BoV Rb2ccdJMqjjTxI16+DAdPlZOXlnXw3RHG7yGZAEdi297yduYG7hHmpalJ9xschmE+AHAHw GWFY+KaRMF3llrg7uqBNJSzDq75KknQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEFC16152F; Tue, 17 Jan 2023 19:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AEF1C433EF; Tue, 17 Jan 2023 19:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673982976; bh=aYhIaG8n5o0p/BBkpaMa18FYk6ylAOgNMDr8sc9WmPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SmT6EUBnqXvnF9/qA9QUrYikLol+V9f38rBhMO8+d3JYmfHgQb/QBhfFgWk30gB5T mIMBlMv9Tk2mGEKXbwFk2Y/tFaSk+CENtRIHyhNrL1AtuaCPkagw6tHWx7jCF39bJv 4u2rLBOi73ycfS3m1SZoe0YGQB67+IwT3CgUEQ8wM6MF25C3CigZYFpwKFAqfkd4Rf P+MCQgZUZmmpdo/sonOi+js5YEKH03CgxpValLwJY4s+A6iS8uXkpCo3rHjfJDHD23 2VHgugQ5T9bXuDs0ILM+XcFE9jgn0pVcQZXRa0Y4dW+ANgbx/ubxxcvw9Qtb2beM8B 0DvGIUS88Miqg== From: SeongJae Park To: SeongJae Park Cc: Liam Howlett , brendanhiggins@google.com, kunit-dev@googlegroups.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "maple-tree@lists.infradead.org" , "damon@lists.linux.dev" , kernel test robot Subject: Re: [PATCH v3 30/48] mm/damon: Stop using vma_mas_store() for maple tree store Date: Tue, 17 Jan 2023 19:16:14 +0000 Message-Id: <20230117191614.116521-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230117191109.116438-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D76E2C000D X-Stat-Signature: 4mxfb589453aujaa31ijk7soik8h7be4 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673982977-2932 X-HE-Meta: U2FsdGVkX1+RRlKwCBP8qBkVB5GUnEiayP+49FwbO+u6KQu4LCuLJJ1F0Ug7iXTYvWHCSGup57kZNhfi6prf4CBoD7OdRSvjGcUiWQcmVLzFVdXY7nCaeS1vHd4LE64HBLOyee66n8bO8H7spDBX3GsrYIETsBKmxSNgmk/ddMXc6dwdyfklk4GF+iLxJSAKkOXMMuInd3lSiylQ6kmECu8CRT4CpQsEMpvosxARoqfdE9gW9jQKK68lpxL2Zmx8kxsA9Z5TL1wAJPUaij6KAh4ayVHURB9CBr5BvQR9MMdYJj8Xkf/yCU1OIvpZlBsEo2XCRc6u8qELroszUeDfBIBwjEFD1N+psd2ALmGxqbzvg1TcW/1it07guf02VrGyG5X8qxyBmlZeI1/5QMd1yhbXoLk/GUZYjssCTdVrkFQRdvwdriKEnShTOuRyqOxkKo9F0LYcdY8CEkz+RpUvhVfi2Tl+9D1dbOCPXwLjFh+ZVju7PuYHET8khJS+EsmdAsd/SgIQxTIIDtUYVURWGAH5qBZvj46CH35rgT9VfIvnfE5mLiTRhg/8dn6hRi4St4EKvw61lqUO9NCCsTrV4J2yF5eNdyr9aHJ0fnqCfeSCZjAK7fFWTd2TRrcEhc81OGcysH2SiLEK4nzh/Y5ZEZBzFNvSKxJ8hFSdTnfynNFtBX01gdpbo07IJkPgOpqaDWVE4BTBcsxoyEuONwnILXCp/SucVIWURq1Sn7Y8DhdAP3P4J0WGyMVutxEN65Oy51jVFT7rprRm8cp1wWTDV5pDNqeNg74302g+oJreu2P55yQQBPk+jfHJb8E1w8oD2MiQZJGAz3ivhlG6UZ5fNWcum7kTu3jUGuXBWcRPbwMlwGFoH1G904AUY41r17MDY+hYbWtxQnfT7XKLghUhRCaIYQ9qO/RmYtpS0Feu6AJzCxzjFOiAI9zb+8ZHd8/AJBnSdFi4aC9KCyuzYcf sCJSdngv PMHZ9SxbdILxr20e+D/Gztv7C0v6GDusp+R380Xy1KRBFqNLlei5Qbn+V0pspSjGLQvMuc8CtIFpVmiGXF7NzF3RcjGQdOVqg2B8Ue1f9CrF+azzm3vNfFbH+k9hyKIhtAG44XOOA2po0s36QkqszbFWfA/n5ARtaj2Va X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Jan 2023 19:11:09 +0000 SeongJae Park wrote: > Cc-ing kunit people. > > Hi Liam, > > > Could we put touching file name on the summary? > E.g., mm/damon/vaddr-test: Stop using ... > > On Tue, 17 Jan 2023 02:34:19 +0000 Liam Howlett wrote: > > > From: "Liam R. Howlett" > > > > Prepare for the removal of the vma_mas_store() function by open coding > > the maple tree store in this test code. Set the range of the maple > > state and call the store function directly. > > > > Cc: SeongJae Park > > Cc: damon@lists.linux.dev > > Reported-by: kernel test robot > > Signed-off-by: Liam R. Howlett > > --- > > mm/damon/vaddr-test.h | 19 +++++++++++++------ > > 1 file changed, 13 insertions(+), 6 deletions(-) > > > > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > > index bce37c487540..6098933d3272 100644 > > --- a/mm/damon/vaddr-test.h > > +++ b/mm/damon/vaddr-test.h > > @@ -14,19 +14,26 @@ > > > > #include > > > > -static void __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > > +static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > > ssize_t nr_vmas) > > { > > - int i; > > + int i, ret = -ENOMEM; > > MA_STATE(mas, mt, 0, 0); > > > > if (!nr_vmas) > > - return; > > + return -ENOENT; Also I think it's ok to return zero here, as this function successfully linked zero vmas as requested. Thanks, SJ > > > > mas_lock(&mas); > > - for (i = 0; i < nr_vmas; i++) > > - vma_mas_store(&vmas[i], &mas); > > + for (i = 0; i < nr_vmas; i++) { > > + mas_set_range(&mas, vmas[i].vm_start, vmas[i].vm_end - 1); > > + if (mas_store_gfp(&mas, &vmas[i], GFP_KERNEL)) > > + goto failed; > > + } > > + ret = 0; > > + > > +failed: > > mas_unlock(&mas); > > + return ret; > > } > > > > /* > > @@ -71,7 +78,7 @@ static void damon_test_three_regions_in_vmas(struct kunit *test) > > }; > > > > mt_init_flags(&mm.mm_mt, MM_MT_FLAGS); > > - __link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)); > > + KUNIT_EXPECT_EQ(test, __link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)), 0); > > In case of the __link_vmas() failure, I think we should skip this test using > 'kunit_skip()', rather marking this test failed. > > > Thanks, > SJ > > > > > __damon_va_three_regions(&mm, regions); > > > > -- > > 2.35.1 >