From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44417C54E76 for ; Tue, 17 Jan 2023 19:11:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2D7B6B0072; Tue, 17 Jan 2023 14:11:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DD456B0073; Tue, 17 Jan 2023 14:11:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A55B6B0074; Tue, 17 Jan 2023 14:11:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7D34C6B0072 for ; Tue, 17 Jan 2023 14:11:18 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 174441A02C7 for ; Tue, 17 Jan 2023 19:11:18 +0000 (UTC) X-FDA: 80365234236.24.0558754 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id A3E61180016 for ; Tue, 17 Jan 2023 19:11:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IP2SlV7F; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673982674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IYjU49176LMBf3hQOAOunDC5N5eI2IhIohAk5oaz4M=; b=zhFMtvkzOpNfQVvt4nO2muYvEHLMzuOTEcF4M9bw67nR8aWz01Ve9E9Cio6HAi9XCu974R lnT5Ysi5qrRG4YSbilfsPFybbKWlImgOVpANlEZUfOst1u7OqHoA/mssaDHTPQ1xZOHg/j znwS3GZBqOpAH3zwatUyzrxyPYpq6LY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IP2SlV7F; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673982674; a=rsa-sha256; cv=none; b=2nwwzNufIxHr3wADBg2ibOF42idbDbr3/0LfRXviOGdEhFDLjTNXmuaRx99qJ+PjABIOvM 8z+tlgKCaE/UcRz9MWEBxEgLklEjWKXdVuWFgL8erkFmSbcbEiqCzEOCbu2kWbsHTan8R4 PxVXswAxDRXPL36m20g9EEGkL/yaOE8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1760BB81910; Tue, 17 Jan 2023 19:11:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00A0DC433EF; Tue, 17 Jan 2023 19:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673982671; bh=fF8gp2hSR6+JJn7LTuIwE4xKl7pKegt4qrFJr/3TmQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IP2SlV7FAbCxTKuKD83g0Aqt+q0bIf/PP1hl8zSoMy9ZG/zIaFVd4CCwkoS3XpZB9 7Cg4Dx+F4aAXVi5y19f6td9OMtAeakfR0YXpIUjPpj6gBuz76uPcbNN3XCFxFRiTEF RmpBuuU313btpOh/ZLYLDlUz8yu+aTBo9ammh2Q8dezChyC0XKSlhUN22S6NerjN/k M2HVcWKdzQ8a+2eIt/W+wBr9sYInx37oy9+B9zIpxLsBbxG1nGNdJOaHDhPNaq00DW 8n+Tb3Wtt7Tv1ANEhnfizKVm3cYVpGZDOeISB1IS7QKSU6wRhmoc6i7TU4gf4xKJga uoq9pm9B4M3YA== From: SeongJae Park To: Liam Howlett Cc: brendanhiggins@google.com, kunit-dev@googlegroups.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "maple-tree@lists.infradead.org" , SeongJae Park , "damon@lists.linux.dev" , kernel test robot Subject: Re: [PATCH v3 30/48] mm/damon: Stop using vma_mas_store() for maple tree store Date: Tue, 17 Jan 2023 19:11:09 +0000 Message-Id: <20230117191109.116438-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230117023335.1690727-31-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A3E61180016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: u7dzjtefpwncyd19mk4hm819z7jyjroy X-HE-Tag: 1673982674-95108 X-HE-Meta: U2FsdGVkX1+hHo7H2Wn4Q8beS8njv2tTA1peFC0zUd3QajruDgz4acEfUnOhO9g1ZBmQvgqTOlopFDInbsZpWIpvPhbu/ciMD1lX3G10gsSB2SI7bP0hUkesYDPB3XUBlIvROhJVpfh/gKe4X3pRJ9e+FGTiAIj+r3ss0tYtBWGo1nVSGtpNf9zi5HEqzsVHxffwq0P6Eki6INZadq2XlH3W/r6lTKQ08cWGVCOn+JC4P2OhzwvdN8GGvcgBndvZlmTusGJLq85WetQtgwRTqcdfmDTqMlV7JnGJ24kWqnciAWpkRCV0JyTWMWJVc0ITQtZzhxnA/0D07o9J3uhMghbAUK6kmwLs8tsAZ0pCuqqhg71uH2fo+oEToER5itz1BMRi//xPH0lcnXs9C5jFfNcBEDR1ZV2nV8bNPWYxc8VmlCwMinmlv0wgwrcm2+i60o+ebHCJAMAKqF079ALGedX0cbikb8S6vsnPaOTvT50CN4k5tAjqAMzgNuzXmwrC0cpTRTfgM/Kd2A1j1v/Ab2z5IbA9s/1T8+P6seeBnzJI94QfDuwxKFKNZu/32+L4x57ZeTb2SdYm95H5qdr1BVcPaimNjPe+7LgyxvseuTnQL/DJC5lmfX6ZRrYGggqk6itD+9hPZ6Z1mPlHsgz8xlUfeNhntLTuxOQStmEtSOTrW8vtpoXlTo+MraK4WTEkQMJ6eWH3sNTAAMmyqd0RBONCbKu6WLdoPJvl2FwTd60LZO0NhfZLDJtxF7E01KS0DSBEmJKRnb74QBWJF15fv6TM71kTIBN7982wd3HMhWVeTin687+SrhCl6Ot0xxSOAyj34/2VSJhL+ZHTwKwKS8c9/0C1DCAqtCvJRMX78LwLNP0ghnYk7563PraLSEqMDCePEhDecWcTcOfFPhj5oMDGtV9XCOUW/vrAG6DXydXRjtQfI2R2RacoO0/phUywXvVTh4Ox16VCvqW92KI ss9F/CWZ J6rBwzm8WAhqIOG0G7bLkqQchPQJREaZxOyvLAMJX+DxWLYUDXIdIGHDRsSDVdX7CNdUexDT4cSlnW6ZixOTd52XQfH2RJOcMXtxW8UhBsbt96Ec42ik7wbH52Zk/Bc4wgDK2NcRo/ILDX7Ww0iXGGObJgMb10o2lwcg6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Cc-ing kunit people. Hi Liam, Could we put touching file name on the summary? E.g., mm/damon/vaddr-test: Stop using ... On Tue, 17 Jan 2023 02:34:19 +0000 Liam Howlett wrote: > From: "Liam R. Howlett" > > Prepare for the removal of the vma_mas_store() function by open coding > the maple tree store in this test code. Set the range of the maple > state and call the store function directly. > > Cc: SeongJae Park > Cc: damon@lists.linux.dev > Reported-by: kernel test robot > Signed-off-by: Liam R. Howlett > --- > mm/damon/vaddr-test.h | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > index bce37c487540..6098933d3272 100644 > --- a/mm/damon/vaddr-test.h > +++ b/mm/damon/vaddr-test.h > @@ -14,19 +14,26 @@ > > #include > > -static void __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > +static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > ssize_t nr_vmas) > { > - int i; > + int i, ret = -ENOMEM; > MA_STATE(mas, mt, 0, 0); > > if (!nr_vmas) > - return; > + return -ENOENT; > > mas_lock(&mas); > - for (i = 0; i < nr_vmas; i++) > - vma_mas_store(&vmas[i], &mas); > + for (i = 0; i < nr_vmas; i++) { > + mas_set_range(&mas, vmas[i].vm_start, vmas[i].vm_end - 1); > + if (mas_store_gfp(&mas, &vmas[i], GFP_KERNEL)) > + goto failed; > + } > + ret = 0; > + > +failed: > mas_unlock(&mas); > + return ret; > } > > /* > @@ -71,7 +78,7 @@ static void damon_test_three_regions_in_vmas(struct kunit *test) > }; > > mt_init_flags(&mm.mm_mt, MM_MT_FLAGS); > - __link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)); > + KUNIT_EXPECT_EQ(test, __link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas)), 0); In case of the __link_vmas() failure, I think we should skip this test using 'kunit_skip()', rather marking this test failed. Thanks, SJ > > __damon_va_three_regions(&mm, regions); > > -- > 2.35.1