From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A55C38142 for ; Wed, 18 Jan 2023 01:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2B466B0072; Tue, 17 Jan 2023 20:31:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDB716B0074; Tue, 17 Jan 2023 20:31:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3C56B0075; Tue, 17 Jan 2023 20:31:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA24E6B0072 for ; Tue, 17 Jan 2023 20:31:51 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A3D38160BD1 for ; Wed, 18 Jan 2023 01:31:51 +0000 (UTC) X-FDA: 80366193222.03.AC5B949 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id E0AB94000C for ; Wed, 18 Jan 2023 01:31:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=txc0NC6a; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674005510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ICsscSYUs408wB+zIYBJmpt9z5C5dofV4xQ0SDQAKs8=; b=AmiO2NGxVqz7mEBxcwhIwygmy4i5YmuWoBMokcBLbqZwmwTMwpItL/c9NLeKdOPr+nppUR Cna6UZjgtVyPz5HKlwyLcwhYYs1S2xrZBb7ZV1cMZ0+QjqJvB2E4qW1xRbAHMXy8oowWkX F74aJY0GDXlM/zfxvRblhDTD9StiSI8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=txc0NC6a; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674005510; a=rsa-sha256; cv=none; b=t+C74EMB6BjW5NalP//kKoim5m1vy4/Ohb49GT11EuJgc86a2VYihVPxMX04/wrb3kQeGM UEHnUT40egkfciS5zu38zJErUOT5na40p0IeeFvrdgtUAQyk9bTNJKDkT5f1u9ULRa6T7q oXMxOil9vZDaxTe14bXU9YgssXcLtLU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2EDC3B80B49; Wed, 18 Jan 2023 01:31:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E07FC433D2; Wed, 18 Jan 2023 01:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674005506; bh=ORSqiiZq8cG14KquIYYw1lnGL7sTZSd7hbj0pDKiBNg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=txc0NC6aTXOuztOTLSjUuDpGgNWO5TrFsT3doh7lNjlZ3wODbE8XhyxM1Boc2Md+X IZ5qzsLLf5pGlxLnpuYR6+C59i6jp/T8uAKEQIG2q9bk/dOeoqOQ0jtkCtS21NN+31 VPoTYW6OI2Drn4LkM4wFl2WaD1tggrSEBsKn3Pgs= Date: Tue, 17 Jan 2023 17:31:45 -0800 From: Andrew Morton To: Zhaoyang Huang Cc: "zhaoyang.huang" , Catalin Marinas , Vlastimil Babka , Nathan Chancellor , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac Subject: Re: [PATCHv2] mm: use stack_depot_early_init for kmemleak Message-Id: <20230117173145.867a06c1585728da1e9b6a54@linux-foundation.org> In-Reply-To: References: <1673943112-8620-1-git-send-email-zhaoyang.huang@unisoc.com> <20230117161731.ab69c2352a62a0693570cf70@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: n678aiqjrjmmeky344coxpy4smp78xto X-Rspamd-Queue-Id: E0AB94000C X-HE-Tag: 1674005509-521289 X-HE-Meta: U2FsdGVkX18JuxIYkpZAoldevOUaHFcn6MifoWfYW8R+XamuxVzC5Xik+OSEFlCPBUvXC2WD8bETqJF0rycsi5z1yV67I+gZCBMvZy2Gaf+aVr6U5peLuCPUFg/j4frQuzLPj0LgttKxGgHIHuudOlFwVk305kdq5DWRjLK+7QS9/+Kjqrm7xiHcUoM/0caOrg2G2gMMNiX3bys7KyHjhOW19+YAK0EtXfyEP7zl764GY0Z0x4K7bcIoRwJRYNhjKYkshSHf0N67AV++FQ7avMJ+jJ0Nk4BrfLmzwKjQDEIk2k7CwljMTxEPt2VFMAh0c5ECas7LiSHZ/Refl6W5G2k86jLKuD7HVdbl/zsLiFzWt5sPYda1Xo4V4k/NvfMOBy4mnVHasWJzt0hHsNN+Dt7UorfW/45Vh+G/TPntZEo++y08ri39hSjELB+oTEBe2e3x1tudGJqiliQx2Gft9MCd17b5lsQ1Ffgeow1S/cf/MCTGCJN/Ker+HkY1x77LXRlZrkRvCDV/VgPPHjnzrnXvEZ/znvlv28Ai+xj9vE3bT6gDMazbr0dfpd4bvc2J34E6iOIo5zf6q6JZman0C16pRV9NRUsrZ6AcE2QpSwC+bVx+n5RaOXmL4HzbrsYr3I9z6YLW6k3vAJuxg5exwoDGMqO3l/UKhvIKe50WMVQlT38HvW3m1WPmXNBLSrUBSbzV5fE+AxRkRFJN1SpbbbLdjBj9v5lPFoE46drwBzhe34kcOME5MxmR1Xo5UkIIN0e4cWEzXDRoGuJSvtiwcVnKVfC3+oGOh3nuxTzNDdVKgEu/HsM9+ZoKoaiLJiv3jWgJOgVqpnhjvCl6YdHGHa+Rypis2+Km21Wn2sO353o5bm3P4nnjyrjM2UfxqAej6omGvGErgzb9VC0ZLicu65c4puTkIiV15bi4rqUi+kxoYXMuk1OYxvNrbpOeTuiabylqo0JWfWYDEPJGj4n JCyoxYak j5BdsU/aed2rM1zxexrn7yA3nFo1wWu4FWZbqDPlI3S4mejfxQyowdz8iWI446IgFOpl5GoxoRe1fcuSrXgdUZ38Qq/sqc3ncL82HR2+7ATadxKifTGiU8zWEgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 18 Jan 2023 09:25:48 +0800 Zhaoyang Huang wrote: > On Wed, Jan 18, 2023 at 8:17 AM Andrew Morton wrote: > > > > On Tue, 17 Jan 2023 16:11:52 +0800 "zhaoyang.huang" wrote: > > > > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc. > > > Solve this by having stackdepot use stack_depot_early_init. Extra Kconfig also > > > done by moving kmemleak stuff to mm/Kconfig.debug. > > > > I don't understand - what was the reason for the Kconfig change? > The items related to kmemleak are moved from lib/Kconfig.debug to > mm/Kconfig.debug Well yes, but why? Is that related to this bug fix? If not then please let's have that change in a separate patch.