From: Andrew Morton <akpm@linux-foundation.org>
To: Jann Horn <jannh@google.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Zach O'Keefe" <zokeefe@google.com>,
linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/khugepaged: Fix ->anon_vma race
Date: Tue, 17 Jan 2023 14:55:32 -0800 [thread overview]
Message-ID: <20230117145532.94132510f8bc538d5465fd43@linux-foundation.org> (raw)
In-Reply-To: <CAG48ez36Nio9GzU_m168AEJMXxtcNtdgq6YpAhLq-aKNQA_9fg@mail.gmail.com>
On Tue, 17 Jan 2023 20:12:49 +0100 Jann Horn <jannh@google.com> wrote:
> On Wed, Jan 11, 2023 at 2:33 PM Jann Horn <jannh@google.com> wrote:
> > If an ->anon_vma is attached to the VMA, collapse_and_free_pmd() requires
> > it to be locked. retract_page_tables() bails out if an ->anon_vma is
> > attached, but does this check before holding the mmap lock (as the comment
> > above the check explains).
>
> @akpm please replace the commit message with the following, and maybe
> also add a "Link:" entry pointing to
> https://lore.kernel.org/linux-mm/CAG48ez3434wZBKFFbdx4M9j6eUwSUVPd4dxhzW_k_POneSDF+A@mail.gmail.com/
> for the reproducer.
Done, thanks.
prev parent reply other threads:[~2023-01-17 22:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:33 Jann Horn
2023-01-12 1:06 ` Yang Shi
2023-01-13 19:36 ` Jann Horn
2023-01-12 8:56 ` Kirill A. Shutemov
2023-01-12 18:12 ` Yang Shi
2023-01-13 0:10 ` Kirill A. Shutemov
2023-01-13 3:22 ` Yang Shi
2023-01-13 19:28 ` Jann Horn
2023-01-15 19:06 ` Kirill A. Shutemov
2023-01-16 12:06 ` Jann Horn
2023-01-16 12:34 ` Kirill A. Shutemov
2023-01-16 12:54 ` Jann Horn
2023-01-16 13:07 ` David Hildenbrand
2023-01-16 13:47 ` Kirill A. Shutemov
2023-01-23 11:07 ` David Hildenbrand
2023-01-24 0:51 ` Kirill A. Shutemov
2023-01-24 10:19 ` David Hildenbrand
2023-01-17 18:57 ` Yang Shi
2023-01-17 19:12 ` Jann Horn
2023-01-17 22:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117145532.94132510f8bc538d5465fd43@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox