From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A27C46467 for ; Mon, 16 Jan 2023 17:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C624A6B0073; Mon, 16 Jan 2023 12:32:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C12BD6B0074; Mon, 16 Jan 2023 12:32:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADA736B0075; Mon, 16 Jan 2023 12:32:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9ABA06B0073 for ; Mon, 16 Jan 2023 12:32:06 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3F7201408CE for ; Mon, 16 Jan 2023 17:32:06 +0000 (UTC) X-FDA: 80361355452.20.538AE16 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 958361C001E for ; Mon, 16 Jan 2023 17:32:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B1T16ntP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673890324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SeLoHzDJjiEfQFnnYijGLXZqt1IPA2Yif9s4u/cIIiI=; b=58p5PfFSENDFp9Go/9w4olYgKRKsflXOm0bPgdvozhwgDhlJcmAhI/D6rjYd1XUQ7CScxl s5mWLmDK2m/Y0ZfsP5eMk+aEWc6dFdKkeZO3bEzP3aFisQ7ua1SKkjPoTy9oYLW8KE8049 AvjcVkFQCzU+NT4P0dkg7e5AFgyhObw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B1T16ntP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673890324; a=rsa-sha256; cv=none; b=jyL4sS2bp2KSq6nipFPRmkhxEis+v7R/+QS5sEzYA/yEyXs9NlqxQ1s0hmAbRpwm2SXW0x DF5AyQ1LNIfGdmhxHIbmI4Y9MLbU4XCK+caOuY0/DEYFtrIhP65EvROYR50Ku7vxFzn7tT B+T02CYvyhXYQs1uy+FAZnrGPfjCzsk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD421B81014; Mon, 16 Jan 2023 17:32:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBC23C433D2; Mon, 16 Jan 2023 17:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673890321; bh=2GR85MBuqs9vE7Za6dHRX2H1EOHPAUnhojuYunISfnI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B1T16ntPN+ehulGd9XjbKZ5eozUsdnpcrrfEM8xQQV+2T5M5tGfjj4O9XisV8ehJ9 yA7/04+JZc6Ln4Z4DhCGfQ6xm934Y92s4N+qFJCbvaBjqEBvpbbrWr0Dle05pL3BHv sEcrPeGxHx4tAnf7rjnv4wvDr+2pZetg9OZAFrhI4svhpgCROzotybTraN48gD72UO lUKP9eCRej5/5XDZF17GTPIG4pSqpcRHN48iRmYKE3c8QZeP/8EjM5kxSV0krvSCJL oYQTVMdpzXSBq/7OgMFwScaFXqbWiTQt/Jj0i+IMOWkPghhicYaWtvgPh3DSqi+qSD c0DsGbHuMlenQ== From: SeongJae Park To: Huaisheng Ye Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/core: skip apply schemes if empty Date: Mon, 16 Jan 2023 17:31:59 +0000 Message-Id: <20230116173159.23307-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230116062347.1148553-1-huaisheng.ye@intel.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 958361C001E X-Stat-Signature: 8q3jtjbcqb5k9cnxsnijcgj963w5751d X-HE-Tag: 1673890324-912724 X-HE-Meta: U2FsdGVkX19Yc/HNyB0PVYYO3vaSRxea7StrlBlTechMUO8iYS/f7QwIWvEQdphOAEDHhTyCplr+OI3ngC4vB03d7pXY9+q3rxP++/8S4DSPxGu3IjnEQRsyPuKkbZKGo2e6L8akOhL4T65pOxzWmIekHa7DK04fZ/m1dXEO2Ikqz0BmoPA0akt4v5ZT1doBtW7mOoycam4L8uQLHE2h+whiKnNW39erJaNobWiI6Byrq0QtF2DAaAsj+YzcM+3h9YjoMdfRuvz1FEppT4OHcUipOSg5v7UWe5RfLALL3liA2abXc+XgMgn3qvtHaLdN/k/6BiBnrniT3yV/sIflIuqhcD6eU6c/7UyJ5OxCQ8t3LDWIQsfFPxV4taSVR/SpWaBKZrrTQPeEtOzFl+JJ7XrzDkrodCFdNJiJswnzeJNvZWR0AdkOTD/jlUb6eO8pff6jqz77gROuudCKbt9ruWCUEDADUOM8x+MHU8GU9XXF3bQZo1xr3FmUw/ZqWy3N41LV4nBb8448CLG8rK52liLRHVrB5eMo22FY41JY9ye+68Qr9YYNSq35tpx7x7sUG1YCjVMKswoV+rPEYWeDt9EyJM7lEu+vdRz9tviby8URPMpJHRTOkYYcEDjprF4u9GeuYCJhBa/lhDAg4r9yoGVVNGSyaXUDQDzb5c2VkMpe42cnv1roz8hxzh++m754eniF9nvIF1VQQtWgBG+/aYs7Q7oMOQwQXLnHFPYZri4RVMGTYoM0Rw5f2xUYX6+SCP5oTyghwynO0z6ClMQRsZUoEHeWh5hsJKWCg+ucYTSH/W2BC4RIYKZyIqPkHaHLUdaJNh7igRlarUG6QQ8gCsDjU4bHrcspOJ/dDB8BkfK/OQSlmpUvayIrjmjX4Pa8lpNCuug56qkpPwSM7QnkXtmObktjZQ0S1e9a3vUSpOv8xzUhPbRL4CXsNsQVxfF40Lj4138ne2ZvAJfJfa5 9ZU3tcEh a2Zj/jkSP2cK6qfNhehgkRKLSYk585SYszbp/GIqjQv/x6o2DzfNOrnDqwc9EHKt32QJA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huaisheng, On Mon, 16 Jan 2023 14:23:47 +0800 Huaisheng Ye wrote: > Sometimes there is no scheme in damon's context, for example > just use damo record to monitor workload's data access pattern. > > If current damon context doesn't have any scheme in the list, > kdamond has no need to iterate over list of all targets and regions > but do nothing. > > So, skip apply schemes when ctx->schemes is empty. Good finding, thanks! > > Signed-off-by: Huaisheng Ye Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index ceec75b88ef9..f338691e4591 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1230,7 +1230,8 @@ static int kdamond_fn(void *data) > if (ctx->callback.after_aggregation && > ctx->callback.after_aggregation(ctx)) > break; > - kdamond_apply_schemes(ctx); > + if (!list_empty(&ctx->schemes)) > + kdamond_apply_schemes(ctx); > kdamond_reset_aggregated(ctx); > kdamond_split_regions(ctx); > if (ctx->ops.reset_aggregated) > -- > 2.31.1 > >