From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3E4C46467 for ; Mon, 16 Jan 2023 20:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B5B76B0073; Mon, 16 Jan 2023 15:16:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 865956B0074; Mon, 16 Jan 2023 15:16:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72E356B0075; Mon, 16 Jan 2023 15:16:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 648EA6B0073 for ; Mon, 16 Jan 2023 15:16:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2F2BA160976 for ; Mon, 16 Jan 2023 20:16:19 +0000 (UTC) X-FDA: 80361769278.15.43DFF34 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id 854F78000A for ; Mon, 16 Jan 2023 20:16:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oYSp4XUI; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673900177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sZNvLJOK8zFYRcRR66J5qmkBgYRLDNpkKKzVCU8NxsA=; b=K11bZGMD59yk8tg3xAJE9gWuK/9FumQoQtjVv4XLHM1SrajSplRbIVyRXcKJ6h+3XELTAk h/dn90cCRwRBEDoGv05EsodHsHg6ZRGOk2U7UMvMKGGiWqKo3hek3mi2DAb80EpNj86KBq 0VR9gPdsummFE4V9BGh7rzKmaGqNMnc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oYSp4XUI; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673900177; a=rsa-sha256; cv=none; b=yCaaIZ6JI/8iXsWNC2obOj84VE7Kk3QmbV/9AM5EL1FjtSxXVcGPtzmX1U6FFB+C1rOxmW pYBtp1JVuVkMKZYBzpACfc22KKgdVlwolAoKMN095innBoQ9QHt6Cun3HbJn17gG2FXxj2 1aPJjw6orMc0E74ZCy65mizJimVLvsI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2257FB80E1A; Mon, 16 Jan 2023 20:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A5C2C433EF; Mon, 16 Jan 2023 20:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673900174; bh=XifFO+wQEWBnwEGFwRSpc+GD0YgFt3GK+V+brSZueUo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oYSp4XUIZwc6NVjSk8MTm18e90jRzgSszwhy++1Eu+p9YS7D8EqMGuel1W2/SgW/I L57OxeOKTzRCNPFv91WVhFFvn+RbUA7KMLRWYSbOutL/uSI4GHBOc9oPowUTzzGjsa 0gab2bGcxtoxHtJb1h3lWjhXgSzQpM0obIbN3UHY= Date: Mon, 16 Jan 2023 12:16:13 -0800 From: Andrew Morton To: Jiaqi Yan Cc: tony.luck@intel.com, naoya.horiguchi@nec.com, duenwen@google.com, rientjes@google.com, linux-mm@kvack.org, shy828301@gmail.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v1 2/3] mm: memory-failure: Bump memory failure stats to pglist_data Message-Id: <20230116121613.234145e82988ca3e602dfce5@linux-foundation.org> In-Reply-To: <20230116193902.1315236-3-jiaqiyan@google.com> References: <20230116193902.1315236-1-jiaqiyan@google.com> <20230116193902.1315236-3-jiaqiyan@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: x7sz6nnhj9mbgg3ah4rcmau9t1btdue7 X-Rspam-User: X-Rspamd-Queue-Id: 854F78000A X-Rspamd-Server: rspam06 X-HE-Tag: 1673900177-340344 X-HE-Meta: U2FsdGVkX1/ANgV3Qk6Em7E4k0XNkjjMKe0Xmx12LcJ8tDwkpB0eiwJ573kTPSjz7HARQ0TyzzEbZ1dLGlSSJ6QEqkCH5jE8PON26SeQ8XDKTXYZtinsT8V9ry1Fs1oNiXySnDobDWY8tm3poQ8UfvEjw6CVTxj+uQGZGwxGBvwiEM25weZPxdDiNWljOsxmSuTdvQmBK6SJV8CsM5MYE6YQo0ZFuLO8eCxooP3iW13EyA9Vxf9RPTuy5Wjy3nKh1uCHavVMgBVF6Dw5ax8SxJbD9PijQQH6fEv7VRQ+BMHdn0ISqAkkowVimWBLA4eyoI8h9IPAHf3OzUNbdPN5Q8GfQCDCcQXDjdoYGrLwwXdH03pDPDPdl7ZEgvaVY/S9+e9KKE3Mk0Op8YJ6k7ww4M9Wuxvp+e+QsbR+rnxcgFnDLQIN1jI3wrifdiaUHAbklrtHthP1OrZhK1zLFD2o3dSgEaXZr/g27wZnxYg0i8XF1XIkoROmA99N4tSfzTbdJyJ0cW3gAGB/9kYvYKYF1GW0iTc4/v44rDtut0Ub5PTASSZKjBOd2nqjQiB8tkm5z5b3Ut704fAyAPKTQ9zVK3AiuSBX/Dvp1DLNjvbXqdln277NO89tlPq5HyEjZcQr+jCr5m/m9CFrXbyzjl1M7CNPr75wFulyz0dd/aN/3luREZyGPUTgGGp2YdMwj3bcIjCSFVcMoHjDB7Mbz2jvvoBYK71+BqG22X6cC2R4+txfXb5tEhRKBb0Pcyc/uzEQQ5C6vsWUIxXRyhU74XDLcTcoPfZ70vSwvVnWc3m20bWYcqXZH9SlZoF0DF9r3Dk971lbCc/kM0iRzV+YedMEy/mFnyWuFnD2kC7w9hBOT5xtHP9reQ10F09X8xef7ZBm4lRS3lkiQRyDZox7vqyL3vAnMhH/N7HZoSPojNIe9thUUJ5DsKDKr4NwSvktb7y6LAPpzxi5KuZfFbSsgHY rQgdqWJa yFahG5DKk7aCIVSigk9JhHnx1Z8OkRmD/o+NN2wYpEYvEPWe5hSNBvtNG5DdXEQbmRDnTchqLCnwBVbg9GaWf9jbaLXyNIADN/anTZmGRP7PvrT7SrAxwAwW4Gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Jan 2023 19:39:01 +0000 Jiaqi Yan wrote: > Right before memory_failure finishes its handling, accumulate poisoned > page's resolution counters to pglist_data's memory_failure_stats, so as > to update the corresponding sysfs entries. > > Tested: > 1) Start an application to allocate memory buffer chunks > 2) Convert random memory buffer addresses to physical addresses > 3) Inject memory errors using EINJ at chosen physical addresses > 4) Access poisoned memory buffer and recover from SIGBUS > 5) Check counter values under > /sys/devices/system/node/node*/memory_failure/pages_* > > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1227,6 +1227,39 @@ static struct page_state error_states[] = { > #undef slab > #undef reserved > > +static void update_per_node_mf_stats(unsigned long pfn, > + enum mf_result result) > +{ > + int nid = MAX_NUMNODES; > + struct memory_failure_stats *mf_stats = NULL; > + > + nid = pfn_to_nid(pfn); > + if (unlikely(nid < 0 || nid >= MAX_NUMNODES)) { > + WARN_ONCE(1, "Memory failure: pfn=%#lx, invalid nid=%d", pfn, nid); > + return; > + } > + > + mf_stats = &NODE_DATA(nid)->mf_stats; > + switch (result) { > + case MF_IGNORED: > + ++mf_stats->pages_ignored; What is the locking here, to prevent concurrent increments? > + break; > + case MF_FAILED: > + ++mf_stats->pages_failed; > + break; > + case MF_DELAYED: > + ++mf_stats->pages_delayed; > + break; > + case MF_RECOVERED: > + ++mf_stats->pages_recovered; > + break; > + default: > + WARN_ONCE(1, "Memory failure: mf_result=%d is not properly handled", result); > + break; > + } > + ++mf_stats->pages_poisoned; > +}