From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2385DC54EBE for ; Mon, 16 Jan 2023 20:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72FA66B0071; Mon, 16 Jan 2023 15:15:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DFFD6B0073; Mon, 16 Jan 2023 15:15:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A72F6B0074; Mon, 16 Jan 2023 15:15:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4420C6B0071 for ; Mon, 16 Jan 2023 15:15:40 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D459AABD0 for ; Mon, 16 Jan 2023 20:15:40 +0000 (UTC) X-FDA: 80361767640.18.4D4C6AB Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 6368540018 for ; Mon, 16 Jan 2023 20:15:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mBT43DxN; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673900138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bku9GEwnCdpo5OVEScypybpoGO+2zuJIdgnhYTAxUEA=; b=Pzd4L0omgyEnJQ1N30SGL/2j20SloYX76mR6KovCs/Mg1CnHKEWxSIV1UzbkuXzcPQ9mww R2uT4PU30I52TcfD/QeBCJ4rIaMIv9aJRr2maOZ2uB5PccdA3UmIZ/GGwwDs4A55wG+/xI Jq+9NNuC80vmEJUNNqv2J4MxC8/DEQg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mBT43DxN; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673900138; a=rsa-sha256; cv=none; b=bkMsoD416qmjDoKrKzzVRibXHZFitl3nejwvDjTjcz2ed6m9o9sm1nPLlZ82VVt3udmnCs 8rdo4CgDW4Y6pBLz1X6oY3GLVfl7MT+Sjil319spYblNQVp7sj8sNyqtSWAXvhsuhMh1G8 hyjPyk4hFaQiotBVeYEtVWpv77aOtho= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 734CEB810DE; Mon, 16 Jan 2023 20:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 629D1C433D2; Mon, 16 Jan 2023 20:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673900134; bh=oGEQ6kJLlRp6b8HK35h+o76sOU9Rl9zuJlS0BbpShSk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mBT43DxNaPMbZeVPK9A8QhzK3NZatzMv7djDLxudg4wc7eOjwD6WP10xdtViLnhOj WVAjDVySkwXnY7o2Oa2DBlHsLR4MTOxWnJzGVjH7tfL7GGwcAUpjueN9hViSoLzbHc 2IYhY2YpPKpBJZn/d1z1FVXyKOEkJ2AuzdVlp1vc= Date: Mon, 16 Jan 2023 12:15:33 -0800 From: Andrew Morton To: Jiaqi Yan Cc: tony.luck@intel.com, naoya.horiguchi@nec.com, duenwen@google.com, rientjes@google.com, linux-mm@kvack.org, shy828301@gmail.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v1 1/3] mm: memory-failure: Add memory failure stats to sysfs Message-Id: <20230116121533.2a8755f8c91b5e2978a1726f@linux-foundation.org> In-Reply-To: <20230116193902.1315236-2-jiaqiyan@google.com> References: <20230116193902.1315236-1-jiaqiyan@google.com> <20230116193902.1315236-2-jiaqiyan@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: mfcmcnd8w3xtknpjxgtsdnzgm3ym6511 X-Rspam-User: X-Rspamd-Queue-Id: 6368540018 X-Rspamd-Server: rspam06 X-HE-Tag: 1673900138-318578 X-HE-Meta: U2FsdGVkX18wzH9wJezLSxfFJtdNSBmJQAEtTjisdCaRh/j4FEExvlhW9yzTSgqn6mwRwUzDP9EbKxR0mCa7CI9MPpgIA1NPHGcQlgD7IdNTdNB/XUHptfpu7k9J87701gSn0766k4iizjjY1v0mqaVwNO3XKOx6ZZSSjo14+AiNNt3ahqifKyNFc25Yhcf/8qPXgvG0NneWJA6x/esR7LzCEYVyN1BxIAfkHU8Yj4jE5jumhD4Rp7lg1A6+HNJhxxNG/09eNLQrmR98N1XwS1t2DmR7Y+NJHj3CHnhZJE+QNfeDtrNNv+595mwTRGDayDUfREtfmfqx9Df+cBuYoJzkDJuBXw1Iqz6jVou1FiboL00/IhOIgL+bILz3nrSIbInRXcmpqp+wAl1hyIOyOjs4aBbzgsp8Gql9UN7cLnxeqgs4Lgb2f/wYgOF9rB57k4HAJT9qZf+GDigLSchMNP0AIzsZ37MaWHvl5TIzQt3L6sPz4QbvCQ5dUlltnJsZdwllozNnHibs3uDHFKsOKx+EKzDRfZJtMjZXZkrIVVJ3XUzREMCWGKNtLTLIyfR4GgL2hnpv+a++T2NSaizVDokKLaG0Reww5FQLPLDJugIl7dnf0Yjyi95QvXI7te0kYcsZjRbSxRFzigCMrUEC/Tkf8TcwfVo7Xf4hiX3RMVbnvhpzvD6T6Mn2E7Hk568uovSBzB0aFoRRNYAQGg2OgFgF7vJoLaAE9f9PRRo2AKdsdg32+pT0qZqTE5r1nkBaGp6iCI1mVCzhRaQmZVUucKHEA/yrVYnWHNXb/Spz3O7HLKp+2jbJmd9PlkdG/ebRAklm1cmSaK+V8vIRqChxv7rkQ2ehdwJG7KQL8IOI70J+58WGrG9YJ2T7CDrJNj+NroyMCv4HnOK/iKUIgNgFnykTdscY5P/NZ7lEcX29/U5B9xhNLOUV+EPgO+kLL8xkHTYDpBXqthJENkNX+PV 8pDalm6/ 7litBSxXL0pF3fqjAFBggWUJwBO5S6GkuLBO/vVGNBQ5irPVHaB4n2INWwC3sg+CcrOldHkAmWaeseno= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Jan 2023 19:39:00 +0000 Jiaqi Yan wrote: > +/* > + * Per NUMA node memory failure handling statistics. > + */ > +struct memory_failure_stats { > + /* > + * Number of pages poisoned. > + * Cases not accounted: memory outside kernel control, offline page, > + * arch-specific memory_failure (SGX), and hwpoison_filter() > + * filtered error events. > + */ > + unsigned long pages_poisoned; > + /* > + * Recovery results of poisoned pages handled by memory_failure, > + * in sync with mf_result. > + * pages_poisoned = pages_ignored + pages_failed + > + * pages_delayed + pages_recovered > + */ > + unsigned long pages_ignored; > + unsigned long pages_failed; > + unsigned long pages_delayed; > + unsigned long pages_recovered; > +}; I don't think the "pages_" here add much value - a simple code comment saying "everything counts in pages" should suffice. If you're feeling deprived of columnar space, maybe just remove? Or not ;)