From: Andrew Morton <akpm@linux-foundation.org>
To: Jiaqi Yan <jiaqiyan@google.com>
Cc: tony.luck@intel.com, naoya.horiguchi@nec.com, duenwen@google.com,
rientjes@google.com, linux-mm@kvack.org, shy828301@gmail.com,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH v1 1/3] mm: memory-failure: Add memory failure stats to sysfs
Date: Mon, 16 Jan 2023 12:15:33 -0800 [thread overview]
Message-ID: <20230116121533.2a8755f8c91b5e2978a1726f@linux-foundation.org> (raw)
In-Reply-To: <20230116193902.1315236-2-jiaqiyan@google.com>
On Mon, 16 Jan 2023 19:39:00 +0000 Jiaqi Yan <jiaqiyan@google.com> wrote:
> +/*
> + * Per NUMA node memory failure handling statistics.
> + */
> +struct memory_failure_stats {
> + /*
> + * Number of pages poisoned.
> + * Cases not accounted: memory outside kernel control, offline page,
> + * arch-specific memory_failure (SGX), and hwpoison_filter()
> + * filtered error events.
> + */
> + unsigned long pages_poisoned;
> + /*
> + * Recovery results of poisoned pages handled by memory_failure,
> + * in sync with mf_result.
> + * pages_poisoned = pages_ignored + pages_failed +
> + * pages_delayed + pages_recovered
> + */
> + unsigned long pages_ignored;
> + unsigned long pages_failed;
> + unsigned long pages_delayed;
> + unsigned long pages_recovered;
> +};
I don't think the "pages_" here add much value - a simple code comment
saying "everything counts in pages" should suffice. If you're feeling
deprived of columnar space, maybe just remove? Or not ;)
next prev parent reply other threads:[~2023-01-16 20:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 19:38 [PATCH v1 0/3] Introduce per NUMA node memory error statistics Jiaqi Yan
2023-01-16 19:39 ` [PATCH v1 1/3] mm: memory-failure: Add memory failure stats to sysfs Jiaqi Yan
2023-01-16 20:15 ` Andrew Morton [this message]
2023-01-17 9:14 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-19 21:16 ` Jiaqi Yan
2023-01-17 9:02 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-16 19:39 ` [PATCH v1 2/3] mm: memory-failure: Bump memory failure stats to pglist_data Jiaqi Yan
2023-01-16 20:16 ` Andrew Morton
2023-01-17 9:03 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-18 23:05 ` Jiaqi Yan
2023-01-19 6:40 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-19 18:05 ` Jiaqi Yan
2023-01-16 19:39 ` [PATCH v1 3/3] mm: memory-failure: Document memory failure stats Jiaqi Yan
2023-01-16 20:13 ` [PATCH v1 0/3] Introduce per NUMA node memory error statistics Andrew Morton
2023-01-16 21:52 ` Jiaqi Yan
2023-01-17 9:18 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-17 17:51 ` Jiaqi Yan
2023-01-17 18:33 ` Luck, Tony
2023-01-18 17:31 ` Jiaqi Yan
2023-01-18 17:50 ` Luck, Tony
2023-01-18 23:33 ` Jiaqi Yan
2023-01-19 4:52 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116121533.2a8755f8c91b5e2978a1726f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=duenwen@google.com \
--cc=jiaqiyan@google.com \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=tony.luck@intel.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox