From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B73C3DA78 for ; Sun, 15 Jan 2023 19:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BE366B0071; Sun, 15 Jan 2023 14:07:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46E766B0072; Sun, 15 Jan 2023 14:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F3B6B0073; Sun, 15 Jan 2023 14:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1E88E6B0071 for ; Sun, 15 Jan 2023 14:07:05 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DA9F4AAB73 for ; Sun, 15 Jan 2023 19:07:04 +0000 (UTC) X-FDA: 80357965968.26.3E6C0AB Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf11.hostedemail.com (Postfix) with ESMTP id CDF7E40009 for ; Sun, 15 Jan 2023 19:07:02 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b=KIkUMx5n; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=jxXle1w6; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673809623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vs0/04K1GIos3EULc9wcvjYIMqUKIQ9jTNF2u67vRqc=; b=qg9XNljqlktb2e1nnFEzfjcTYb+EJY/CtNi7fvZu5dhBsZEIUUWnTJqtyjiSVlyHFzQ4tq 2+pDhBm7JzXv6Goiw9FHkSKQguXIUSMOOq0CpbFPv1X9ibAPaXbQtOQz/iOogzro0k6Hks 7btfi9O10smvzXsWeLcCF6EgMnt+QU0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b=KIkUMx5n; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=jxXle1w6; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673809623; a=rsa-sha256; cv=none; b=8IVn0YGqA3eAJ1CXs5zrZ1Mr7PNkOMfdVirJxR0levOBIcvVV/yuX8FIXBlYBl0f5fUZjI ZZCqKFzatzANaHgb9J/Ntfil/y48G1R1ZIlB+IG7z0lp+ifSkZX4JGpQdmSzKPfaWiPG/h eHYKckZtcvQJAr4b+ReLPPVnrIHqrxU= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C33D632008FF; Sun, 15 Jan 2023 14:07:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 15 Jan 2023 14:07:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1673809620; x=1673896020; bh=vs 0/04K1GIos3EULc9wcvjYIMqUKIQ9jTNF2u67vRqc=; b=KIkUMx5nLlUKpDJhC6 +lhg0WierY3fIs1gAvNbRzY/0BNYGiR151XpaM1usQNjRaRr/s2iNCTST7Dduw9G oNrL9zztciY4PMeXma1IuhfQd0MsnivFtI4TTQS8ZPwUJ/50R8r8t9VZwTXhkfiW G9U41x6Dpt9cOriISUjpP/Qcqu1HummU8KcDUfRFMN16ZCmzkhcvh+lwlvSbcz1u HIM+uYzDrn48VF0Hy7E8h97YV+0hBpK5l+tZEJVJ2oAivM0hblG2ewfjrRDVSxqI wf77Mva9C27/nE8M1qH55vV+Y+y8xs4rrxbxJcBeQH8o/Rin5Gwm4I9bKAlpDnkH jFyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673809620; x=1673896020; bh=vs0/04K1GIos3EULc9wcvjYIMqUK IQ9jTNF2u67vRqc=; b=jxXle1w6tDVLVVtZUsl47klynlSdhnEwIHy9LAW6zGtT 1xEbJ+j+cZHlcrvdyAiiRJpDY8o9jhMqCuHfn7dgXzbUwbFI9PTymN2qP4ySGa9u cw5xCdVpfZqczjjKzlw9fEbZ9foAtyRO0MI7iXsKUdfu28e77Le2W+at6oNIw35Y ZL5wCWxdvRMzKTcaLwaM1RVi3ZbxXM8aCBAd8SLCZs1MEYS++q2Wm9MgXqrYcugv mdSDHVyevE7PrWi2775h3ZoI8bdF6WLeGDegKqEd62ArYk/clr6nLatmw+s8ynSU 66Od2/zxrY9Pui30ASw4XaUI8vJggAcPvq2ybSB8Wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtvddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttddttddttddvnecuhfhrohhmpedfmfhi rhhilhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrd hnrghmvgeqnecuggftrfgrthhtvghrnhephfeigefhtdefhedtfedthefghedutddvueeh tedttdehjeeukeejgeeuiedvkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 15 Jan 2023 14:06:59 -0500 (EST) Received: by box.shutemov.name (Postfix, from userid 1000) id 04B5B102D59; Sun, 15 Jan 2023 22:06:55 +0300 (+03) Date: Sun, 15 Jan 2023 22:06:54 +0300 From: "Kirill A. Shutemov" To: Jann Horn Cc: Andrew Morton , linux-mm@kvack.org, "Kirill A. Shutemov" , Zach O'Keefe , linux-kernel@vger.kernel.org, David Hildenbrand , Yang Shi Subject: Re: [PATCH] mm/khugepaged: Fix ->anon_vma race Message-ID: <20230115190654.mehtlyz2rxtg34sl@box.shutemov.name> References: <20230111133351.807024-1-jannh@google.com> <20230112085649.gvriasb2t5xwmxkm@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CDF7E40009 X-Rspam-User: X-Stat-Signature: rsqk6js8cdcneqnkccqtud7gfa93hozz X-HE-Tag: 1673809622-215592 X-HE-Meta: U2FsdGVkX1+rrZm9FoU7CCXhtteJ8CPmFWdMcpYxtfvk7G03cNIhQcylTbNhrrWRT+ruw6louJdTnR1qQjMLY6AiFlax/jQ75igLqC9OfusGqkM3Xrwe3hq0A5DG6i/we0jnCu7Eyby9rJRS4xbhf8nAW7GEICzcOBUlkCDo1WRweYkfOMgzHrLfrNM/gWYDrhXYpTJZDhUrxYjsVGOoroQOcJprScLU6yvjqzikmmkZ6lzujhCeQFYBJztlcBvzdA5HAudAFItit5oyzCghSW84I3Yeh/6ReJ0qdmDA4R0pgrCRV54Sh3jsY8Kb2YyHyCISPzWw/FmAYt31/WFZXPZrSLkJMhYTkuBGsu4NSJJSXVz2oHe0m07FLXHISWAjQZm66MD3gsUZ1aBWUU5+LQ9kkGoNubdFZB7N+N1ZCmSBJdM4VXidArUAF9/9XYFpKwmO63aWOErgsNoCwi0k0SrR4hxoZvPxFVxE7mP7XFpp07U9NpcXqq4FQyf68o4LaW/9qs0csGKsX9zuIzkBN39SVsJAxV+Qo1ogFO/MbiLOf/MjPdo1v1B7PdbCKWub09QcCyxco1x94f1XyY1oYJTexNR24rWMqK1f2fFSt6QfsUnjp2FvhiQcAHikf7iyxPzvToOGRVlM43UNM/jUeourEMQhQVCA7gSXkp83oVwBlWVxvrwFLRdz70hKlUkSm4BewsKMpf8kOKsuWwbJHIacESz9k69mBLhNUvElhrGpkWolVysCS/ir4d3aJMh76uaDB64LlvfZ1eRA/BqKeXEpab0/Ay6Mqieg4OUKY9Rcs7ueUTubkCbEYGjtTNHiO4I5XPR98P+qS5b7Grwb8lB6c8kDyNKrlTSWcKRHkzVob1HWBiB5LTpiZNn2sAFGBybxYBdk0Eat/myXhCB7TW9d51Pc2SfuUo83OPZ+bnMPVag6mIWOBo5pzD/V42Ae9KuXnjx4c5HaR8Euvng tr8+9CiA zjr5MdUf2yv6OcJlyeIoVRORUqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 08:28:59PM +0100, Jann Horn wrote: > No, that lockdep assert has to be there. Page table traversal is > allowed under any one of the mmap lock, the anon_vma lock (if the VMA > is associated with an anon_vma), and the mapping lock (if the VMA is > associated with a mapping); and so to be able to remove page tables, > we must hold all three of them. Okay, that's fair. I agree with the patch now. Maybe adjust the commit message a bit? Anyway: Acked-by: Kirill A. Shutemov BTW, I've noticied that you recently added tlb_remove_table_sync_one(). I'm not sure why it is needed. Why IPI in pmdp_collapse_flush() in not good enough to serialize against GUP fast? -- Kiryl Shutsemau / Kirill A. Shutemov