From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D6AC46467 for ; Sun, 15 Jan 2023 13:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5AFF6B0071; Sun, 15 Jan 2023 08:34:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0AC66B0072; Sun, 15 Jan 2023 08:34:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD2986B0073; Sun, 15 Jan 2023 08:34:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A8FBD6B0071 for ; Sun, 15 Jan 2023 08:34:28 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 790E6A8D30 for ; Sun, 15 Jan 2023 13:34:28 +0000 (UTC) X-FDA: 80357127816.30.3194014 Received: from hyperium.qtmlabs.xyz (hyperium.qtmlabs.xyz [194.163.182.183]) by imf03.hostedemail.com (Postfix) with ESMTP id D25CA2000D for ; Sun, 15 Jan 2023 13:34:25 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=qtmlabs.xyz header.s=syka header.b=XYBDUDlb; dmarc=pass (policy=reject) header.from=qtmlabs.xyz; spf=pass (imf03.hostedemail.com: domain of msizanoen@qtmlabs.xyz designates 194.163.182.183 as permitted sender) smtp.mailfrom=msizanoen@qtmlabs.xyz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673789666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=jjxt+FsgG+EBJq1B4OVQNkvSIphuNLp2z8Syfe3Ynng=; b=Nk+kxTnrHJ8G70AZnCy+24ec9ZF1JME4yxELFIFqmLOi9V1Va1x0lT03flChRiFEt5Pq9m 0WZ2JNOd/2MN56se7mExA5HRAKlpl1ugh679zTz0T4lONXO6aWNYhfs435ZtoPgDwZfRo0 bze32URaW9VyUsrlOxPwcChFBZ++g5E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=qtmlabs.xyz header.s=syka header.b=XYBDUDlb; dmarc=pass (policy=reject) header.from=qtmlabs.xyz; spf=pass (imf03.hostedemail.com: domain of msizanoen@qtmlabs.xyz designates 194.163.182.183 as permitted sender) smtp.mailfrom=msizanoen@qtmlabs.xyz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673789666; a=rsa-sha256; cv=none; b=2B/nUipNaNSHUkwlLvmQTMNHYUOlU/+q2Lh1hfzl8fK8cnnNLQ3n9Tc63Pq14skMrnsJOn lJbSTl4RvCB/nqIolAooF2BvnmuVxk4dyvvEEiF7Q7VwZRC4BAwgTWEzRkJ6kKoMHfQOWd g7YBqq7qwEOy80HxdgdyHiYJC4pqkt8= Received: from dong.kernal.eu (unknown [14.231.159.199]) by hyperium.qtmlabs.xyz (Postfix) with ESMTPSA id 7F35B82002E; Sun, 15 Jan 2023 14:34:23 +0100 (CET) Received: from localhost (unknown [27.67.17.21]) by dong.kernal.eu (Postfix) with ESMTPSA id 243FA44496AC; Sun, 15 Jan 2023 20:34:15 +0700 (+07) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtmlabs.xyz; s=syka; t=1673789655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jjxt+FsgG+EBJq1B4OVQNkvSIphuNLp2z8Syfe3Ynng=; b=XYBDUDlb3m3V/40fMSwJ7HgEDj9fNDCfOmFPu3VZ6PFeJ2qZsFB7Ufo9ErkL99R2dM8Ckp 9NBT9Saei/VXSOFPP2h9jSdaHyZbLMm55Y2J7w2rKTPzbEcPpeLlYvCK4ygueuUHVgkUHQ rRtnBlTypdUZGzTn1khCmhitbK6OB204VvA/nNua0KwlpWY/CC27gQqo8knZBmGbEuiomv yo2npnTETwwuxWUhcu9bMHKTBz/z/a2AfQx6oIvTHgUWTU/GKC4BkqLAFeekCRCugBoVB8 QrogIzN9JghUvyVwAhy7Gsm1PelvP2n4RctOTuoXrZb4E8OQNsgq2TLQwKzW9w== From: msizanoen1 To: Andrew Morton Cc: Yu Zhao , msizanoen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: do not try to migrate lru_gen if it's not associated with a memcg Date: Sun, 15 Jan 2023 20:33:31 +0700 Message-Id: <20230115133330.28420-1-msizanoen@qtmlabs.xyz> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D25CA2000D X-Stat-Signature: h8m44zyntmp3hpijkw4t335tbx8m8b8b X-HE-Tag: 1673789665-562963 X-HE-Meta: U2FsdGVkX1944DkCxuUZOkTS6akuM8T0uhCn4OMuLOtK4Zucm6FUAC7U3ocB/pl4CmlmOlE1eGnpbialh2qmYJtKjYPMYYcvUzlC+v/j6EdzaBfSU+8NOXI51CaiOYOqH6vZbyhKFsfqovtl1fwBh/O4N4a/joumuqLf1i5YxVM+k4ImM9ZBWZP9cBt5mQyT1yuLaHfPjym9u2F7lJhwAU3BX9AeDUSlufqOE92uZNasqBv+8kLl/Ksdy8bJZMgZrEC4ovsI+o2fNBF0G5LbtjyBNXYfbdfkL0hG06x71Vtn+saApgirFYkeay458ki+LGXXXiIEyD13nRo+ibMK6GcUJiF52Vk6zrwQJr4Hl/5vtS1T1+xlG8wAynPys5tsiliM1qzDmcf+koLjyw7FbCXIgnTYbA3V2QmpuQmmHGoRP+vbvyEC5RrxU4caBinfgYuneWP2pbV5vhih3rdYndIaijwKsHzh6buSd1eBNl7L8VDMKI3wrOzZpoMiPtJjdwwUqYPeXTEPvmLrwklq+2eC0d2pbsy5/ZAw/bq2Ro9sVkZw3Kc4wGazQuIckaO54DEyINYn/G+rnJaFAEaMlQpN2E/Pb+sdJjisU8HwCconruH7jrtc+DAz4Vm0dbuGrxUKj739kT52gRNZb8lA5PRNobUTuhNVGCAjJ4s/Z2EytSiE6VhT60T4R02CGDKSHNmDRRTTaqXzD2/mmxV6OoP+73R/0xYCwJjhT4bVjTm3iYBVJ2IsOl61ZrW2WgfZbBdxLJguB4a8733tMueupA9UWPpWbJyU/7u+Lpi6ymWpUGnigWfPT1bMRgYcq4KHwEHHThTX4UWKF62E/IVW1WPdNEiG7K+MTG+AqrZGzq6a709+EoyRH+TGqBfXqiwwqxxVjbMDXkIgWWGvn+d8a3pmiR+qQuc03kymN6Mj4RMLDGoVdXgf29b+piI1OcX6Uj/uWIQcDQZvYzQ9GY7 /aa6rD4A KH7kVn452UL1kEutW/ABl3t/YWJIR7j3jfwp40V0qSM9eJCfIThzMtZui+sjv4SltDtPrQsBzBahzvgLFk+LQJa5L5DbLSwLHvLq8N/eAG7webgsGFg8Tbj9AtQCSVC1YvrUBLQJbC7/6Zg7jTgD+LwrucZ8n+6jqDsun X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: msizanoen In some cases, memory cgroup migration can be initiated by userspace right after a process was created and right before `lru_gen_add_mm()` is called (e.g. by some program watching a cgroup and moving away any processes it detects[1]), which results in the following sequence of WARNs followed by an Oops as the kernel attempts to perform a `lru_gen_add_mm()` twice on the same `mm`: [26181.135304] ------------[ cut here ]------------ [26181.135309] WARNING: CPU: 0 PID: 57083 at mm/vmscan.c:3299 lru_gen_migrate_mm+0x76/0x80 [26181.135484] CPU: 0 PID: 57083 Comm: cgroupify Kdump: loaded Tainted: P OE 6.1.5-200.fc37.x86_64 #1 [26181.135489] RIP: 0010:lru_gen_migrate_mm+0x76/0x80 [26181.135518] Call Trace: [26181.135521] [26181.135525] mem_cgroup_attach+0x88/0x90 [26181.135531] cgroup_migrate_execute+0x213/0x470 [26181.135536] cgroup_attach_task+0x11c/0x1c0 [26181.135540] ? cgroup_attach_permissions+0x159/0x1c0 [26181.135545] __cgroup_procs_write+0x10e/0x140 [26181.135550] cgroup_procs_write+0x13/0x20 [26181.135553] kernfs_fop_write_iter+0x11e/0x1f0 [26181.135559] vfs_write+0x222/0x3e0 [26181.135565] ksys_write+0x5b/0xd0 [26181.135569] do_syscall_64+0x5b/0x80 [26181.135573] ? syscall_exit_to_user_mode+0x17/0x40 [26181.135578] ? do_syscall_64+0x67/0x80 [26181.135581] ? do_syscall_64+0x67/0x80 [26181.135584] ? exc_page_fault+0x70/0x170 [26181.135588] entry_SYSCALL_64_after_hwframe+0x63/0xcd [26181.135592] RIP: 0033:0x7fd18996a0c4 [26181.135633] [26181.135635] ---[ end trace 0000000000000000 ]--- [26181.135643] ------------[ cut here ]------------ [26181.135644] WARNING: CPU: 0 PID: 57083 at mm/vmscan.c:3300 lru_gen_migrate_mm+0x72/0x80 [26181.135804] CPU: 0 PID: 57083 Comm: cgroupify Kdump: loaded Tainted: P W OE 6.1.5-200.fc37.x86_64 #1 [26181.135808] RIP: 0010:lru_gen_migrate_mm+0x72/0x80 [26181.135835] Call Trace: [26181.135837] [26181.135838] mem_cgroup_attach+0x88/0x90 [26181.135844] cgroup_migrate_execute+0x213/0x470 [26181.135848] cgroup_attach_task+0x11c/0x1c0 [26181.135852] ? cgroup_attach_permissions+0x159/0x1c0 [26181.135857] __cgroup_procs_write+0x10e/0x140 [26181.135861] cgroup_procs_write+0x13/0x20 [26181.135864] kernfs_fop_write_iter+0x11e/0x1f0 [26181.135870] vfs_write+0x222/0x3e0 [26181.135876] ksys_write+0x5b/0xd0 [26181.135880] do_syscall_64+0x5b/0x80 [26181.135884] ? syscall_exit_to_user_mode+0x17/0x40 [26181.135889] ? do_syscall_64+0x67/0x80 [26181.135892] ? do_syscall_64+0x67/0x80 [26181.135895] ? exc_page_fault+0x70/0x170 [26181.135900] entry_SYSCALL_64_after_hwframe+0x63/0xcd [26181.135903] RIP: 0033:0x7fd18996a0c4 [26181.135985] [26181.135986] ---[ end trace 0000000000000000 ]--- [26181.143062] ------------[ cut here ]------------ [26181.143066] WARNING: CPU: 0 PID: 57554 at mm/vmscan.c:3211 lru_gen_add_mm+0x159/0x180 [26181.143240] CPU: 0 PID: 57554 Comm: xdg-mime Kdump: loaded Tainted: P W OE 6.1.5-200.fc37.x86_64 #1 [26181.143246] RIP: 0010:lru_gen_add_mm+0x159/0x180 [26181.143274] Call Trace: [26181.143277] [26181.143281] kernel_clone+0x20c/0x400 [26181.143285] ? wp_page_copy+0x36f/0x6f0 [26181.143290] __do_sys_clone+0x64/0x70 [26181.143295] do_syscall_64+0x5b/0x80 [26181.143299] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143303] ? do_syscall_64+0x67/0x80 [26181.143307] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143310] ? do_syscall_64+0x67/0x80 [26181.143314] ? handle_mm_fault+0xdb/0x2d0 [26181.143317] ? do_user_addr_fault+0x1ef/0x690 [26181.143322] ? _raw_spin_lock+0x13/0x40 [26181.143326] ? exc_page_fault+0x70/0x170 [26181.143330] entry_SYSCALL_64_after_hwframe+0x63/0xcd [26181.143333] RIP: 0033:0x7fa3b7131d47 [26181.143379] [26181.143380] ---[ end trace 0000000000000000 ]--- [26181.143387] ------------[ cut here ]------------ [26181.143388] WARNING: CPU: 0 PID: 57554 at mm/vmscan.c:3213 lru_gen_add_mm+0x16a/0x180 [26181.143535] CPU: 0 PID: 57554 Comm: xdg-mime Kdump: loaded Tainted: P W OE 6.1.5-200.fc37.x86_64 #1 [26181.143539] RIP: 0010:lru_gen_add_mm+0x16a/0x180 [26181.143564] Call Trace: [26181.143565] [26181.143567] kernel_clone+0x20c/0x400 [26181.143570] ? wp_page_copy+0x36f/0x6f0 [26181.143574] __do_sys_clone+0x64/0x70 [26181.143578] do_syscall_64+0x5b/0x80 [26181.143581] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143585] ? do_syscall_64+0x67/0x80 [26181.143588] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143592] ? do_syscall_64+0x67/0x80 [26181.143595] ? handle_mm_fault+0xdb/0x2d0 [26181.143599] ? do_user_addr_fault+0x1ef/0x690 [26181.143603] ? _raw_spin_lock+0x13/0x40 [26181.143606] ? exc_page_fault+0x70/0x170 [26181.143610] entry_SYSCALL_64_after_hwframe+0x63/0xcd [26181.143614] RIP: 0033:0x7fa3b7131d47 [26181.143638] [26181.143639] ---[ end trace 0000000000000000 ]--- [26181.143641] list_add double add: new=ffff91c15edec3d8, prev=ffff91c15edec3d8, next=ffff91c1e3f48878. [26181.143658] ------------[ cut here ]------------ [26181.143659] kernel BUG at lib/list_debug.c:33! [26181.143667] invalid opcode: 0000 [#1] PREEMPT SMP PTI [26181.143670] CPU: 0 PID: 57554 Comm: xdg-mime Kdump: loaded Tainted: P W OE 6.1.5-200.fc37.x86_64 #1 [26181.143675] RIP: 0010:__list_add_valid.cold+0x23/0x5b [26181.143707] Call Trace: [26181.143708] [26181.143710] lru_gen_add_mm+0x10a/0x180 [26181.143716] kernel_clone+0x20c/0x400 [26181.143719] ? wp_page_copy+0x36f/0x6f0 [26181.143723] __do_sys_clone+0x64/0x70 [26181.143728] do_syscall_64+0x5b/0x80 [26181.143732] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143736] ? do_syscall_64+0x67/0x80 [26181.143740] ? syscall_exit_to_user_mode+0x17/0x40 [26181.143744] ? do_syscall_64+0x67/0x80 [26181.143748] ? handle_mm_fault+0xdb/0x2d0 [26181.143753] ? do_user_addr_fault+0x1ef/0x690 [26181.143757] ? _raw_spin_lock+0x13/0x40 [26181.143761] ? exc_page_fault+0x70/0x170 [26181.143765] entry_SYSCALL_64_after_hwframe+0x63/0xcd [26181.143769] RIP: 0033:0x7fa3b7131d47 [26181.143796] Fix this by simply leaving the lru_gen alone if it has not been associated with a memcg yet, as it should eventually be assigned to the right cgroup anyway. [1]: https://gitlab.freedesktop.org/benzea/uresourced/-/blob/master/cgroupify/cgroupify.c Signed-off-by: N/A (patch should not be copyrightable) --- mm/vmscan.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index bd6637fcd8f9..0cac40e7484c 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3323,13 +3323,19 @@ void lru_gen_migrate_mm(struct mm_struct *mm) if (mem_cgroup_disabled()) return; + /* This could happen if cgroup migration is invoked before the process + * lru_gen is associated with a memcg (e.g. during process creation). + * Simply ignore it in this case as the lru_gen will get assigned the + * right cgroup later. */ + if (!mm->lru_gen.memcg) + return; + rcu_read_lock(); memcg = mem_cgroup_from_task(task); rcu_read_unlock(); if (memcg == mm->lru_gen.memcg) return; - VM_WARN_ON_ONCE(!mm->lru_gen.memcg); VM_WARN_ON_ONCE(list_empty(&mm->lru_gen.list)); lru_gen_del_mm(mm); -- 2.39.0