From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, linmiaohe@huawei.com,
naoya.horiguchi@nec.com, willy@infradead.org,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH mm-unstable 8/8] mm/memory-failure: convert unpoison_memory() to folios
Date: Thu, 12 Jan 2023 14:46:08 -0600 [thread overview]
Message-ID: <20230112204608.80136-9-sidhartha.kumar@oracle.com> (raw)
In-Reply-To: <20230112204608.80136-1-sidhartha.kumar@oracle.com>
Use a folio inside unpoison_memory which replaces a compound_head() call
with a call to page_folio().
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
mm/memory-failure.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index fb98652b211a..c53588ea5993 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2335,7 +2335,6 @@ core_initcall(memory_failure_init);
*/
int unpoison_memory(unsigned long pfn)
{
- struct page *page;
struct folio *folio;
struct page *p;
int ret = -EBUSY;
@@ -2348,7 +2347,6 @@ int unpoison_memory(unsigned long pfn)
return -ENXIO;
p = pfn_to_page(pfn);
- page = compound_head(p);
folio = page_folio(p);
mutex_lock(&mf_mutex);
@@ -2360,31 +2358,31 @@ int unpoison_memory(unsigned long pfn)
goto unlock_mutex;
}
- if (!PageHWPoison(p)) {
+ if (!folio_test_hwpoison(folio)) {
unpoison_pr_info("Unpoison: Page was already unpoisoned %#lx\n",
pfn, &unpoison_rs);
goto unlock_mutex;
}
- if (page_count(page) > 1) {
+ if (folio_ref_count(folio) > 1) {
unpoison_pr_info("Unpoison: Someone grabs the hwpoison page %#lx\n",
pfn, &unpoison_rs);
goto unlock_mutex;
}
- if (page_mapped(page)) {
+ if (folio_mapped(folio)) {
unpoison_pr_info("Unpoison: Someone maps the hwpoison page %#lx\n",
pfn, &unpoison_rs);
goto unlock_mutex;
}
- if (page_mapping(page)) {
+ if (folio_mapping(folio)) {
unpoison_pr_info("Unpoison: the hwpoison page has non-NULL mapping %#lx\n",
pfn, &unpoison_rs);
goto unlock_mutex;
}
- if (PageSlab(page) || PageTable(page) || PageReserved(page))
+ if (folio_test_slab(folio) || PageTable(&folio->page) || folio_test_reserved(folio))
goto unlock_mutex;
ret = get_hwpoison_page(p, MF_UNPOISON);
@@ -2397,7 +2395,7 @@ int unpoison_memory(unsigned long pfn)
goto unlock_mutex;
}
}
- ret = TestClearPageHWPoison(page) ? 0 : -EBUSY;
+ ret = folio_test_clear_hwpoison(folio) ? 0 : -EBUSY;
} else if (ret < 0) {
if (ret == -EHWPOISON) {
ret = put_page_back_buddy(p) ? 0 : -EBUSY;
@@ -2410,14 +2408,14 @@ int unpoison_memory(unsigned long pfn)
count = folio_free_raw_hwp(folio, false);
if (count == 0) {
ret = -EBUSY;
- put_page(page);
+ folio_put(folio);
goto unlock_mutex;
}
}
- put_page(page);
+ folio_put(folio);
if (TestClearPageHWPoison(p)) {
- put_page(page);
+ folio_put(folio);
ret = 0;
}
}
--
2.39.0
next prev parent reply other threads:[~2023-01-12 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 20:46 [PATCH mm-unstable 0/8] convert hugepage memory failure functions " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 1/8] mm/memory-failure: convert __get_huge_page_for_hwpoison() " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 2/8] mm/memory-failure: convert try_memory_failure_hugetlb() " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 3/8] mm/memory-failure: convert hugetlb_clear_page_hwpoison " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 4/8] mm/memory-failure: convert free_raw_hwp_pages() " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 5/8] mm/memory-failure: convert raw_hwp_list_head() " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 6/8] mm/memory-failure: convert __free_raw_hwp_pages() " Sidhartha Kumar
2023-01-12 20:46 ` [PATCH mm-unstable 7/8] mm/memory-failure: convert hugetlb_set_page_hwpoison() " Sidhartha Kumar
2023-01-12 20:46 ` Sidhartha Kumar [this message]
2023-07-15 4:07 ` [PATCH mm-unstable 8/8] mm/memory-failure: convert unpoison_memory() " Matthew Wilcox
2023-01-13 7:03 ` [PATCH mm-unstable 0/8] convert hugepage memory failure functions " HORIGUCHI NAOYA(堀口 直也)
2023-01-13 16:06 ` Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112204608.80136-9-sidhartha.kumar@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox