From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E611EC54EBC for ; Thu, 12 Jan 2023 09:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72A298E0002; Thu, 12 Jan 2023 04:38:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B3908E0001; Thu, 12 Jan 2023 04:38:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 553BF8E0002; Thu, 12 Jan 2023 04:38:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 414018E0001 for ; Thu, 12 Jan 2023 04:38:18 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00278C0865 for ; Thu, 12 Jan 2023 09:38:17 +0000 (UTC) X-FDA: 80345646234.24.2ACF183 Received: from outbound-smtp57.blacknight.com (outbound-smtp57.blacknight.com [46.22.136.241]) by imf11.hostedemail.com (Postfix) with ESMTP id 5A28240012 for ; Thu, 12 Jan 2023 09:38:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.241 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673516296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+zB7iY4dT6fnArSFfs6Exhy1Zz39jEh2Ip2A6+A1DLQ=; b=uHr0WtBEXmJKP+MFjHSG8Y2DGV5dPf7F5/BaOQkUfhuvuLlNUdd1QmSDsseAlKprmRLobe C+VhNnhdYUCN26qfbcr25sadNxVjbk5nk91u1FR3Wjqh272HX2xKtqJtmUgjScZhsP5OE0 UbIBzxnPNpMA4GL5VQXMK8gEvtHRkWY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.241 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673516296; a=rsa-sha256; cv=none; b=PYpQ2dQMqjefhFciLrbGVfU9IJXbjK4QqGmbX4DfN2dky7L0zMp4DPHuX44AocwVThmV5O WpfkEJhsDv2evTVFNhgsBU9TWOr4mdSztTnqSCR9sdf9T6mgWE44T76g76oXkn1BFtUVCC e3NfeVlt02hs9kE4aCleIerJXT4FUig= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp57.blacknight.com (Postfix) with ESMTPS id D73D3FABF3 for ; Thu, 12 Jan 2023 09:38:14 +0000 (GMT) Received: (qmail 25808 invoked from network); 12 Jan 2023 09:38:14 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 12 Jan 2023 09:38:14 -0000 Date: Thu, 12 Jan 2023 09:38:12 +0000 From: Mel Gorman To: Michal Hocko Cc: Linux-MM , Andrew Morton , NeilBrown , Thierry Reding , Matthew Wilcox , Vlastimil Babka , LKML Subject: Re: [PATCH 3/7] mm/page_alloc: Explicitly record high-order atomic allocations in alloc_flags Message-ID: <20230112093812.x7kgdgvyd2fzrwex@techsingularity.net> References: <20230109151631.24923-1-mgorman@techsingularity.net> <20230109151631.24923-4-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5A28240012 X-Stat-Signature: 84fqeb3znxpmhbrwb37qy51p3t8k9y5z X-Rspam-User: X-HE-Tag: 1673516296-688708 X-HE-Meta: U2FsdGVkX1/CG3TNx5MkCu6ZXq+sdlK02Rg1NWfpltIUcLVh5OetUekcxwmi15Vyhx3eaLKwjO4FBEA3j2lbpF4jUK8NNYaJc40jW5eV7VrTl/+qOKE4d9un/PAKRo0OvibUw+7VnslmYDRSAx3/zkd8C25JJXR7xzZjUmIdSxgwzBwS7j8z906oJWKjH6nO7hgQcd93GX5nw2Kw2FRUNo681ybzSKpAn1HD0kCIvwrHzbAX2rG5AgtNhU4gZsPLYSQs2HLMVTSH1wp8pydc3xt16lMeIBdydnajxGrVmUv6x0sdAV19hlHxsX/lm446I+/wvvW1bFFa6/3xTcy0meF9axzRsWksOzyG3fBoRMfMLqrJyVadRsjtbA1COcjoYS1A2OwwY2m9SV/tiHTL63ybEgc9IB3d++PTYHPfovy7/lKFEv7N6jrBjPpxOREo26tPIKSuzvIz/zcW0gR1R8fLaPoeTKzS70tmfDxhxQLIuFLf9bQvBC2RD41EwMj9PRuTUDeJPRtUHcSCUtwlPxVGkJsNa3G6GX1NbSOTZ3+jYi41PlJKJXq8NatEkJSL1udhL4uv9ZyCxHgf/eqRoUn96Hes8usI8uJ8ypF24Q5iKRQSFp8z7zQrtUfZrA04bbAlks4ozkRX0rNcnRNOEso+ColVASs3VXmL8cWA9RFofRkGduwkdUgQZVOZparjRW639OrevEjo9cYB8/hdT9EmmKwcwH6L6aftCiXuJfWzSa4miG4dVzToPxG1KCXB+5cEUT+ErKlr3GsDN2deswTttRljF314Ywrmzti4vm5M5y3K+FXoN6EeGpQClZu6avqTeNROybgUZps3HY9pth9wSNzi1d5rjc4z9WaSVlQxJCPv6gEFCIlrZ0zZoqbt4qRVsXYpL6078keKvsm9efFWZcTaum01laIPLh7mwKZ54MXURYZ8EhSPSpnrvPaF+Kh1sNSGUHYoLFXJP5/ nO3kxeXP A1+JMNUIoLJr9x8ZOHYMuCg3fxzgt/5OSIvjd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 04:36:01PM +0100, Michal Hocko wrote: > On Mon 09-01-23 15:16:27, Mel Gorman wrote: > > A high-order ALLOC_HARDER allocation is assumed to be atomic. While that > > is accurate, it changes later in the series. In preparation, explicitly > > record high-order atomic allocations in gfp_to_alloc_flags(). There is > > a slight functional change in that OOM handling avoids using high-order > > reserve until it has to. > > I do not follow the oom handling part. IIRC we are dropping highatomic > reserves before triggering oom. Something might have changed down the > path but I can still see unreserve_highatomic_pageblock in > should_reclaim_retry. > That comment is now stale and should be removed because I fixed up the OOM oddities. At this point, a series resubmission is needed because a few changelogs have to be updated. -- Mel Gorman SUSE Labs