From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90033C54EBD for ; Thu, 12 Jan 2023 09:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22B318E0002; Thu, 12 Jan 2023 04:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DB6E8E0001; Thu, 12 Jan 2023 04:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C9F38E0002; Thu, 12 Jan 2023 04:26:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F0EFB8E0001 for ; Thu, 12 Jan 2023 04:26:15 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3D8FC07A6 for ; Thu, 12 Jan 2023 09:26:15 +0000 (UTC) X-FDA: 80345615910.12.E72FDA1 Received: from outbound-smtp22.blacknight.com (outbound-smtp22.blacknight.com [81.17.249.190]) by imf21.hostedemail.com (Postfix) with ESMTP id 4494C1C0020 for ; Thu, 12 Jan 2023 09:26:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.190 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673515574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NR22Zv3/nAuKp+KUxiKuPNMnvCHmdOzb8gGyFvP59Bo=; b=U7+LAiNCh0Uvyl/gjy6bja054NjGF4kRw8RALgQsXpY5wIy4nHI1p2Rsdia9xbSvQlvWCg G6Fwifnx3od9WNxzrynaJYHAwE5AXkPySo5sC+VbT+rKjumF8CgGBr15qIOgXkaimL71aa dfLVHebYoKjrOEfpIg19u3yk/VznAyg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.190 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673515574; a=rsa-sha256; cv=none; b=S4NHr2VckrTI3P2Kn6nqPY8nvd5KKNV+tatPhREhFBdh/zcnjAkOPKypkhyBzpTxMxxZ1V G33lb5Qun9J8937kj4BDRwQf2fQKBgMShgv1+srJ/1443eAi8roYwfLFsGiHBFvq6LhUv1 BnDsEbM4P3Alcdz5Qy9Wv7hidlCJp18= Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp22.blacknight.com (Postfix) with ESMTPS id 7466BBAB84 for ; Thu, 12 Jan 2023 09:26:12 +0000 (GMT) Received: (qmail 26969 invoked from network); 12 Jan 2023 09:26:12 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 12 Jan 2023 09:26:12 -0000 Date: Thu, 12 Jan 2023 09:26:10 +0000 From: Mel Gorman To: Michal Hocko Cc: Linux-MM , Andrew Morton , NeilBrown , Thierry Reding , Matthew Wilcox , Vlastimil Babka , LKML Subject: Re: [PATCH 1/7] mm/page_alloc: Rename ALLOC_HIGH to ALLOC_MIN_RESERVE Message-ID: <20230112092610.msowgtidt2a7zo4w@techsingularity.net> References: <20230109151631.24923-1-mgorman@techsingularity.net> <20230109151631.24923-2-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4494C1C0020 X-Stat-Signature: ze4baaygzxg9xjcazcicskf7amx54r4s X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673515574-897859 X-HE-Meta: U2FsdGVkX19RANdiBAl8hgiTpj7QUuWOG6kV/7jW7DuGgmhYViQ49Lu9f88vAGry/f4fMgbfole+HTS8ZUjLqRbh/XX+7T6k0rI4LN/D+JPPdEY5CwZqQA2sENz4srB0Y5GUw3NcDsyZIUM1S+svLkH84q0+9CGEh9MylGrDC/fzLeJQcjGboN0MxoTfpo2R6f9SC8IW6iDvxtSiCpS4+li53WjtJy60ikIuGCmKtnhB81Agrb7kIIiXdSaH4yQJVctoH+u4A+yZ9p0pzQ7o/gwPwwaOnI/G8nNQaGD4w1XD6t/WeFBKwVh7V80XS33QnX/eqaiRagUXc4ZEHkEr3WVQ0pufD1DwyB6pw4BCWlBmZtCMgN5q7vRltTCFP3clw+wW0ilzayrA8GcTHV9dI3wwdzAqKHBYTr/WcxOiZfYFN/zQ6IzpwchqvHRKwlGxOrWL5TG6BR8s9JAkX2f7y0NRNZ+06xg+RrCQmp4IrZbBA96KxmvVlZCmHNfBTCbbh1orYOTjifpAJQASAaRATOAArTDUAK6YFS3gcC0a2iT7jTmYJshR22rdWHEJ8zeO/iQGzAWnPr5nRiCGZ3lKwLxOR2NU7KlyWgWEG8Rs9FjCEgrxhoYFoVrwgGdepMDUR1N412e1AC2vK+1PNR9j+4UT2m+CKlW6x5QaRYAq5dBM0MdcVJCEJUSLS1bJfUOR7NQ74kzggNVZFtehkxUYYo+XerUnA4yvvplvDDakpXhWXgzJ+AF++FBQl6po4VjF9O9EvRrYqcB+4+a+sUnUQixk3DZDCZ856/Whw8pwI25iEM7Zjj1wMmvHEZwYLSn17jGbnq2BMOEOtD1xQuNFa7Jl5T13AC7XEdzaZNEy5rpaohRRPmO1HHkMirbF59876ZNKZDBvQBipQHY4oDGelSdKZH+I8PMwGxgUspaIWxM9CgE9KnUhp8zVRCm8Mitr8OMfG6gZboGchvqY5+J louWi0rB TxrnbCp7WVsYL1jeivPBs2RGGwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 04:18:50PM +0100, Michal Hocko wrote: > On Mon 09-01-23 15:16:25, Mel Gorman wrote: > > __GFP_HIGH aliases to ALLOC_HIGH but the name does not really hint > > what it means. As ALLOC_HIGH is internal to the allocator, rename > > it to ALLOC_MIN_RESERVE to document that the min reserves can > > be depleted. > > > > Signed-off-by: Mel Gorman > > Acked-by: Vlastimil Babka > > Naming is hard but ALLOC_HIGH is definitely much more confusing as it > can collide with high watermark. ALLOC_MIN_RESERVE says that some > reserves are involved. ALl the reserves are below min watermark by > defition but I cannot really come up with a better name. I do not think > we want to encode the amount of reserves into the name. > It's internal to the page allocator so I didn't sweat about it too much. Access to the reserves currently means "allow pages to be allocated below the min reserve". Even if that changes in the future, the name can change with it. > Acked-by: Michal Hocko > Thanks! -- Mel Gorman SUSE Labs