From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: <akpm@linux-foundation.org>, <willy@infradead.org>, <linux-mm@kvack.org>
Cc: <linux-kernel@vger.kernel.org>, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH -next 3/7] mm: memory: convert do_cow_fault to use folios
Date: Thu, 12 Jan 2023 16:30:02 +0800 [thread overview]
Message-ID: <20230112083006.163393-4-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20230112083006.163393-1-wangkefeng.wang@huawei.com>
The page functions are converted to corresponding folio functions in
do_cow_fault().
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/memory.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 1cfdb0fd8d79..f29bca499e0d 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -4507,22 +4507,24 @@ static vm_fault_t do_read_fault(struct vm_fault *vmf)
static vm_fault_t do_cow_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
+ struct folio *cow_folio, *folio;
vm_fault_t ret;
if (unlikely(anon_vma_prepare(vma)))
return VM_FAULT_OOM;
- vmf->cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);
- if (!vmf->cow_page)
+ cow_folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, vmf->address,
+ false);
+ if (!cow_folio)
return VM_FAULT_OOM;
- if (mem_cgroup_charge(page_folio(vmf->cow_page), vma->vm_mm,
- GFP_KERNEL)) {
- put_page(vmf->cow_page);
+ if (mem_cgroup_charge(cow_folio, vma->vm_mm, GFP_KERNEL)) {
+ folio_put(cow_folio);
return VM_FAULT_OOM;
}
- cgroup_throttle_swaprate(vmf->cow_page, GFP_KERNEL);
+ folio_throttle_swaprate(cow_folio, GFP_KERNEL);
+ vmf->cow_page = &cow_folio->page;
ret = __do_fault(vmf);
if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
goto uncharge_out;
@@ -4530,16 +4532,17 @@ static vm_fault_t do_cow_fault(struct vm_fault *vmf)
return ret;
copy_user_highpage(vmf->cow_page, vmf->page, vmf->address, vma);
- __SetPageUptodate(vmf->cow_page);
+ __folio_mark_uptodate(cow_folio);
ret |= finish_fault(vmf);
- unlock_page(vmf->page);
- put_page(vmf->page);
+ folio = page_folio(vmf->page);
+ folio_unlock(folio);
+ folio_put(folio);
if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
goto uncharge_out;
return ret;
uncharge_out:
- put_page(vmf->cow_page);
+ folio_put(cow_folio);
return ret;
}
--
2.35.3
next prev parent reply other threads:[~2023-01-12 8:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 8:29 [PATCH -next 0/7] mm: remove cgroup_throttle_swaprate() completely Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 1/7] mm: huge_memory: make __do_huge_pmd_anonymous_page() to take a folio Kefeng Wang
2023-01-13 14:25 ` Matthew Wilcox
2023-01-16 11:09 ` Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 2/7] mm: memory: convert do_anonymous_page() to use " Kefeng Wang
2023-01-13 15:33 ` Matthew Wilcox
2023-01-16 11:11 ` Kefeng Wang
2023-01-12 8:30 ` Kefeng Wang [this message]
2023-01-13 15:37 ` [PATCH -next 3/7] mm: memory: convert do_cow_fault to use folios Matthew Wilcox
2023-01-16 11:31 ` Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 4/7] mm: memory: convert page_copy_prealloc() to use a folio Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 5/7] mm: memory: convert wp_page_copy() to use folios Kefeng Wang
[not found] ` <CGME20230113130136eucas1p18a54a3812792e500a02079ee890e5ecb@eucas1p1.samsung.com>
2023-01-13 13:01 ` Marek Szyprowski
2023-01-13 13:08 ` David Hildenbrand
2023-01-13 19:04 ` Lorenzo Stoakes
2023-01-13 22:16 ` SeongJae Park
2023-01-16 11:35 ` Kefeng Wang
2023-01-13 17:45 ` Daniel Thompson
2023-01-15 16:01 ` kernel test robot
2023-01-12 8:30 ` [PATCH -next 6/7] mm: memory: use folio_throttle_swaprate() in do_swap_page() Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate() Kefeng Wang
2023-01-13 15:50 ` Matthew Wilcox
2023-01-16 11:37 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112083006.163393-4-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox