From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A09AC54EBD for ; Thu, 12 Jan 2023 07:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E053A8E0003; Thu, 12 Jan 2023 02:56:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB58C8E0001; Thu, 12 Jan 2023 02:56:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7E5D8E0003; Thu, 12 Jan 2023 02:56:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B5A558E0001 for ; Thu, 12 Jan 2023 02:56:37 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8715180826 for ; Thu, 12 Jan 2023 07:56:37 +0000 (UTC) X-FDA: 80345390034.10.E245AD9 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf24.hostedemail.com (Postfix) with ESMTP id EB5AB180007 for ; Thu, 12 Jan 2023 07:56:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kL0UvQit; spf=pass (imf24.hostedemail.com: domain of 3Mr2_YwgKCM8D2v5zz6w19916z.x97638FI-775Gvx5.9C1@flex--shakeelb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3Mr2_YwgKCM8D2v5zz6w19916z.x97638FI-775Gvx5.9C1@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673510196; a=rsa-sha256; cv=none; b=btgrObm7sfxRZocuodPZBSz+mNAHpPo0I+Dgliiyn1L/exyrpP32WqODliUlL1+6n3oc8Q tsfR3IsI6niUneKtUEQLpgkchKUoc07mbej2nwKw30yq5rbmgr8wA4T3c5IAffAQlzd/f4 9yNwkFuyLXcPSHPHnL7UiodDi3bBNEk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kL0UvQit; spf=pass (imf24.hostedemail.com: domain of 3Mr2_YwgKCM8D2v5zz6w19916z.x97638FI-775Gvx5.9C1@flex--shakeelb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3Mr2_YwgKCM8D2v5zz6w19916z.x97638FI-775Gvx5.9C1@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673510196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vg6nAgYjZ4wYYlTqMF3jbo791ipG8SuFLzs8v41dmTI=; b=R+SgJ8tCUjTD3/QiiX46ghU00+w1mKtUt/NVZ9O7Br+RpAFPU2k7M4As4Lnr0ApoFYzXyk vk6V+/E8/mWqBq3aqPbVEsKITQsYMaaeD1yRRCYubwxRc9DPkZAqVomPzkxHPRezjtY8iH uy/f4zUCfaKTyAEkybDmTY0b8XuhwhY= Received: by mail-pl1-f202.google.com with SMTP id b14-20020a170903228e00b00192a8ae9df5so12156895plh.7 for ; Wed, 11 Jan 2023 23:56:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Vg6nAgYjZ4wYYlTqMF3jbo791ipG8SuFLzs8v41dmTI=; b=kL0UvQite/urbN7Yp3NlzfzFTECRjRM1K7T5g4ZxG3zHylBlslAyzr6qxrAi9aysJM RDeACOZIgRrgriXoR4Pb3FUm6siAnl76A15BakL+7xmzzyJYvBrIKvFGmqzOdrHuLyHw eLCWL5a84U7mTNiiuZkhyyW//9BsTntHFbTMWG3xqNxmoxumrT4tac24HiqQmCacQxb7 hWUb45XPnPy09DrO6jQeVMIxbVjfhO/QXKCL83ehtKjjTMjBps8fFK6gPa75SmpeTyw8 vcf4DzdsP5Yv5ETLXzCGGp7Lotol2entUVESDqjWMyWKfU3XQsKSss8PleO3BkZomuWi ioIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vg6nAgYjZ4wYYlTqMF3jbo791ipG8SuFLzs8v41dmTI=; b=x6tCUfTmC1vuquEzhZavRYD9M/eFqqZL73KePd4dfnrqI0ekFJrkUmmAmVc1emqnBF f84wNbOA3/cjfOyi5MNK7imZjWHEET1BR+8jV4WV+KMOkY2rCYsMS7XInMkMcE+GmFJm xLIi3rNYZ0MAPm8eLmvbmidWYY9U62DXAygzDNRQcKbFDU5ZkCl+pvWfilLugYHdDcaA x0hcvj0QZ00+AJz7/bWT8qDMEnPKJHZZwLdKhOS8xVMEgInViYvYus0QiIeXOLazT2QD 2N3N3ZxJnTie8fxm6nrTIZehnhjAWt2gYyHoQQ/FNOA8MjBnVXBim3kUgm8ITpd9wHLg NXKw== X-Gm-Message-State: AFqh2ko1HpZtzaYQxbbuLjtD0ZrXtvkQcSytWnKvsR40JAMuPGVET62g Q2an5GP5SEiWpOWvFT16+utl8qLSo5yuKg== X-Google-Smtp-Source: AMrXdXv29WhmagcsXxW5VJTVWoRrJdV9U6Gev8NYUGOd+PwEKkvAbufkJGb0qU84S3rueo4liZ5Ei6F1OKpY1Q== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a62:1488:0:b0:581:85ab:16b3 with SMTP id 130-20020a621488000000b0058185ab16b3mr4558933pfu.67.1673510194669; Wed, 11 Jan 2023 23:56:34 -0800 (PST) Date: Thu, 12 Jan 2023 07:56:31 +0000 In-Reply-To: Mime-Version: 1.0 References: <20230109213809.418135-1-tjmercier@google.com> Message-ID: <20230112075631.wc6fd54ci55drhkp@google.com> Subject: Re: [PATCH 0/4] Track exported dma-buffers with memcg From: Shakeel Butt To: "T.J. Mercier" , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Sumit Semwal , "Christian =?utf-8?B?S8O2bmln?=" , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , android-mm@google.com, jstultz@google.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EB5AB180007 X-Stat-Signature: ddj7rkz3p6ddigza81knmuq8a9e9c1th X-HE-Tag: 1673510195-266381 X-HE-Meta: U2FsdGVkX18nrYcCTdvZFTyIlL/xyAcShr6ejjO3SruPIz06yhV4ybpcTBqbtKNl3hL/ov5BqSEArA4vbrwSaGLdcOcEBZ3p0iVGqnh/jXmDWbAxx+3DzfBxNiKpgydxZcGcUUeZC+s2IrqZS0XNtUHUiiQZTmHVM259GsJz16ucMKwrATFA33E2wSvJ5IlqcSF2MnSmNuWm7J4suKL6MH13DSFZXSF89hKCtOVLT106mfqsMGjBAQZ/Xwegzt2b2Gxb2YRW4C8ERttToq4tKAg/FCiEHDErNIF5xHdutoe4w6o+P8eCqEaB0kJt0gN823arYAoVe+b6CyuTO1fUZltZEeACLzLurHmyfPFob0nfLIldCpjHZVo3Cj334k6AE1ojWsZjGNQ8yuJoWVBYXcGspmVEzy+B4ZWjBeTBXbwCSZuISueFXnc4ebb1gwR0lfO46or1qp453sItlBYSrDcXYprvua64mwAh5TLM7HzBCCoRpMzR4HlndxImnZyjkKcFooqk1zv3Q3JmW5LZed+8U1kgBiq0NP+Z7tefKkOq6zNnrjRbebH7BWq/OHb4k4zQND4LGkT2uWYIM3ysXaGawacXgCmqXM9GOGFukecZEBY+VZ6F7cjGpe679ryivwHHr4q4rwdaRAtGMZMEflOVFdNZ4IQR5EZmYNz0XWGSSpsLbQ6UzF324fM/qjUQE5amzVg74/021M29w60GrQ9xVpYvXTnp/iGA3AyExUgBCdlJ/+osLjeYHnZoDTAZHszNG/ZADucZ2UCYHPoAcsVY8lr4PQox7VKW1YJoJ3J6GzgA4pgADH5OTqnCSck6gStvk8ce+siKwRBbQes2z+GMGMtDSMF2WzOvH9RBciYraZnbV+5nXwBH27vgUlDBzD84DoeVHkvk8Av6BHryl+G6gyr5dnzKXrmC09G6nUtdkVqR+/z7gwR5gFddvSRRBw9v920eJrbfLm5blsd i/O0D+Di VxCAFZu5oNEyMea+NVCVPuPO0ujAg0NCuDlfi/8N1K7jG+Mg3JvaVMvgEABAvNSA7rlKqqpOlzJVLXC6I3jXL28QOodFrZdDyeEaZ1//Ps3AE0BQ+AshiHmXvGgbZgqw4/WTwtNaD/LhS/ZZlNeOnkP31/Spdss6BZc9gB3onCZ/J2D3PS/LomjoKDOghMFcrpX9LoXOL9YPyMNi/UOBdMy8eZHRTY0jb/lsKIatTOXPddYa7rmsPJ/Q6JVivpgMPSBPDtcY1P71b9VWpQiQtABelBozWCkrnbH1KmJdhSOxItwy7rNaBQUXnkjPO2u/cLn3R6QNSC9QGlXOViAVr9iRFuU86LV76IRHX34CyoIHm+MPWR5f+z2pftu1yIRO9JcvDm8/WdQMl7zfvMj1pWDo6U3O35O3bEQ6D693nr5ildIOFuk7Yvzenx3ji1xLqn4fV5WYECIQAQ5w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 11:56:45PM +0100, Daniel Vetter wrote: > [...] > I think eventually, at least for other "account gpu stuff in cgroups" use > case we do want to actually charge the memory. > > The problem is a bit that with gpu allocations reclaim is essentially "we > pass the error to userspace and they get to sort the mess out". There are > some exceptions (some gpu drivers to have shrinkers) would we need to make > sure these shrinkers are tied into the cgroup stuff before we could enable > charging for them? > No, there is no requirement to have shrinkers or making such memory reclaimable before charging it. Though existing shrinkers and the possible future shrinkers would need to be converted into memcg aware shrinkers. Though there will be a need to update user expectations that if they use memcgs with hard limits, they may start seeing memcg OOMs after the charging of dmabuf. > Also note that at least from the gpu driver side this is all a huge > endeavour, so if we can split up the steps as much as possible (and get > something interim useable that doesn't break stuff ofc), that is > practically need to make headway here. This sounds reasonable to me.