From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C557C5479D for ; Wed, 11 Jan 2023 20:19:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A41AA8E0003; Wed, 11 Jan 2023 15:19:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F11F8E0001; Wed, 11 Jan 2023 15:19:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86AFF8E0003; Wed, 11 Jan 2023 15:19:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 755908E0001 for ; Wed, 11 Jan 2023 15:19:02 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 523CE1A04FC for ; Wed, 11 Jan 2023 20:19:02 +0000 (UTC) X-FDA: 80343632082.13.64EEFD9 Received: from earwig.ash.relay.mailchannels.net (earwig.ash.relay.mailchannels.net [23.83.222.54]) by imf04.hostedemail.com (Postfix) with ESMTP id 7112A40025 for ; Wed, 11 Jan 2023 20:18:57 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=TaLEus5K; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf04.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.54 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673468339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wS+GmrFpvGE25kGRXu4cr712LGdTZyedIO8N8BIAZig=; b=3fVMe6ncDi4UHhyjA6MFkBDJX1nKv8WIEozNm4A2Ols7XVDLyPKHsnwkAvXL0LqoG3c+qU pEUE8hsvkSFifOnlfTVuW4ne7TCFGOqkz2qrq9f/hkr59ZIzBSm4rr3uOBcDu3HfHW+Eyo ZWdC18OZSWkm1y8NZsR2lFYGiD2rGPM= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=TaLEus5K; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf04.hostedemail.com: domain of dave@stgolabs.net designates 23.83.222.54 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1673468339; a=rsa-sha256; cv=pass; b=3ozi6HAfec36v/Idy+Y1+gcz4iT6U6vEV0PjOivlRsQGFeZVPJZJ9K9O+53y2uOn4u3N1d dKO6dJ2ZY/BxH8IjOObLj1Qk/A9JkzHvCoVRMwi9eCvHjodaVZHTjfQfHrOR3siqWBi63e fU4+E4lRX3Yu+TVSzSmbyskox1Jj26A= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 632623C0F4C; Wed, 11 Jan 2023 20:18:54 +0000 (UTC) Received: from pdx1-sub0-mail-a292.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D4E573C11B1; Wed, 11 Jan 2023 20:18:52 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1673468333; a=rsa-sha256; cv=none; b=o1bQ0SlWXjhpUMKJqMY++h4yREFBaCy0k2PvwXuAG4DrW1ePtRtSfUHKgUVtCEi7WmtBm1 K8LJstY7q4J9lkTMSkrlDtFxz2URtHnCMulJzWyHywRklCbvHwq3l7cB1v9Us1lk9knA6O j5DXed8U13miKm/nBWvuG4L/DdedVLuIzyfm/vDZ5MpNEfhCMxa2yYfOHrNwDZ0LiS/5pX oDxplhKMvj7qd5oNlYmzaZbgZazs1md5VqHFAbmttlIaf9ci7IYNjmjHh2XrnONnRyKMV2 uCWagx6IWpE2LoeEHzSiL10ss5NmpmrpjEaea/sZqd0SCHkhQ4IOSh+eM2j8eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1673468333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wS+GmrFpvGE25kGRXu4cr712LGdTZyedIO8N8BIAZig=; b=H2ZwOVFAek61HzxEZRCNoRGEE3TpYPeKeGa0IA69wusZLobsCkJ1AtQ2+tjkJaDhAi7zOo LbSf+vFGJSg1k2GwlqgIHTbJDKFNdbt3AlJL1RFo8DYO2uz0/m+/08aPY77Y31m4S0qBbv 4MCfRc3iYiP6cfvakD8UwW3PCyMR12fN1G/aCltT8A1awF0+n6eu1tdNAm28zBPNix02sY bnGimyZGhYs7QXBFFFFPuoXli3Yfw01sYBSFWLImeOP0gE+YIO9KnidAWfWuYBRvhvGQfu xURvDIuIDDDbmcNXzJg9wbar6skAsdpq6EcPZcolQ58aC/D5UW79rzGR0JAZug== ARC-Authentication-Results: i=1; rspamd-6f569fcb69-64672; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Plucky-Reign: 1875abcc38b9467a_1673468333974_2650156361 X-MC-Loop-Signature: 1673468333974:760517353 X-MC-Ingress-Time: 1673468333974 Received: from pdx1-sub0-mail-a292.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.229.59 (trex/6.7.1); Wed, 11 Jan 2023 20:18:53 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a292.dreamhost.com (Postfix) with ESMTPSA id 4NsfCD1FpdzBR; Wed, 11 Jan 2023 12:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1673468331; bh=wS+GmrFpvGE25kGRXu4cr712LGdTZyedIO8N8BIAZig=; h=Date:From:To:Cc:Subject:Content-Type; b=TaLEus5Kxs4Xgc7EFqEAlAtzzYTJ5Ns/cPdthJRVyguJMTXO22OiW4rUNoNV+jYft MP/2MMYkp0ThoDJyLDqGUOnh0yCFasMO62DOBsGuNoJGZ5IrSxev/cRsPVvLbzqObC dgPbP3psGAjHX83NlTwPhHUjOImqFGW22izEgF06mr4IzxI9GVmAEjwi+ATAQMbJGa VoHJUBiUAd6BgFmPomIsoyyiDr9nV6YhCh1M2ftpXxiLnB4oB+VfaNNTtSVJWPqhoN x3RU+K3bNgNwCDLw3fSHcMpIaP/lxT1tXjlql6EzObb+ULQjwk/xfdmcwEFX2Dbbbn WfXRzd2RzPlaw== Date: Wed, 11 Jan 2023 11:52:50 -0800 From: Davidlohr Bueso To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 13/41] mm: introduce vma->vm_flags modifier functions Message-ID: <20230111195250.cj27sg4yoslbdjdp@offworld> Mail-Followup-To: Suren Baghdasaryan , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-14-surenb@google.com> <20230111154726.stadwtzicabwh5u5@offworld> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7112A40025 X-Stat-Signature: 8wx6mhdmtodh8n4pg858u48dnz8ahomw X-Rspam-User: X-HE-Tag: 1673468337-206321 X-HE-Meta: U2FsdGVkX18GGn9kiuYHlhoh/4zDlAYGBkJMO1MeEsToobrT5HKXJXb8Zjn68P/e+H+ONG8CBD+1aYShwZH752Gx/Nl8bZ8b22fKBBmRNEJjrhCLUm8pl3Qdjgx/AHlI2hRUOgUZCXiKRH+MvXa36uQVjopuSG5mmDDIWh+3BVISTlcU91p6NDnjrGh2OklEKLT7NOhem8HYK/hABUAZhbDwoekYOw9N2V1cS4hA/eVEr7upAMTuwsLrfY+4xnQpVXqs1vr1KuBLK1UgcaTePexVPExCeYuM9djPc7VdUUqvuSMp+bQJJNXVqGqxa2x1sSKWW9i8gACN8zbxbvuBREhyTKyzlzoQ/sprBqNbh/z7r1dDsxSVWcGovKVj1klWvhuFTy5Eauiv8du4SuuhIR/MTdNHPC5UPFJEOihzruOwwZuDonLlqSS7Nlw6A8+E2C6H97fYwyo0tZoIWmKYOHzZFYr/w4TRDYQXfgJHsQKmdeCOD90CJ2VTiVLGlNDzBsFZFC+1GCcaDsTm6i7hkSGtj7tVz9gx2jDM2YY5F+rFLcUjW99ckSUx8UD1PYviO5w4nhZ+eqvg5vkKEE6kO0iJ229hPMrUse5yABHoJhK0cokqtHPuOZtWphiqbR62bFcznt3pCE8N1BJXa7qEd2kg9Z54u79V1OP/laaQhlIae5cgS4gDZEPduGtP7ANw9D7y12PtHCpBmlC7rxwMZhrHuA4cMMsnKsdtsNXUCi+CDBcM7qtmZO5ZkmYJflsgGO49u1MMEwj3h+m5yNk3+Vurr9RwYdx2xHgGQ2easBnj0S+FuHxS8HtzD8Q+nvfUg5FmRkIe1lJEBikYTgABQGg5JAIQHWcZR3e/jg2njHpwrnF/t1USg4IPG+7BXn5By86srOebslAZ1DiMIMV/M+Sdr6sv5GxTiSMFgjJBce0Q6uYedLmQPT2fimh5jgunsJj1xypsmFsLsUafWaD hBh6HzbR oEbZwszgSwmgyiK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Jan 2023, Suren Baghdasaryan wrote: >On Wed, Jan 11, 2023 at 8:13 AM Davidlohr Bueso wrote: >> >> On Mon, 09 Jan 2023, Suren Baghdasaryan wrote: >> >> >To keep vma locking correctness when vm_flags are modified, add modifier >> >functions to be used whenever flags are updated. >> >> How about moving this patch and the ones that follow out of this series, >> into a preliminary patchset? It would reduce the amount of noise in the >> per-vma lock changes, which would then only be adding the needed >> vma_write_lock()ing. > >How about moving those prerequisite patches to the beginning of the >patchset (before maple_tree RCU changes)? I feel like they do belong >in the patchset because as a standalone patchset it would be unclear >why I'm adding all these accessor functions and introducing this >churn. Would that be acceptable? imo the abstraction of vm_flags handling is worth being standalone and is easier to be picked up before a more complex locking scheme change. But either way, it's up to you. Thanks, Davidlohr