From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA6AC46467 for ; Wed, 11 Jan 2023 14:19:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33D4B8E0008; Wed, 11 Jan 2023 09:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ED6C8E0001; Wed, 11 Jan 2023 09:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18E9D8E0008; Wed, 11 Jan 2023 09:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF8D98E0001 for ; Wed, 11 Jan 2023 09:19:33 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B71FBA030B for ; Wed, 11 Jan 2023 14:19:33 +0000 (UTC) X-FDA: 80342726226.20.590827D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 175B81C000C for ; Wed, 11 Jan 2023 14:19:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=to8kz4be; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673446772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aKKeQDX5M27cS/Y9GBuMn/99ULlrTykEwpfkno661Kc=; b=i4QnVpwSo19lzZzHHtMoYhCrgL101djtvuwl3lE+fti1boIecgf94hjpqeobm7XLrsHtS5 hy/pkIAxb4jl7bKIXB4YFO/JzSVt4Fhkxa3K5H49TXFohuCl8XkvUjnuNBG5U1Z1NDJjZ2 EbNX7doO6lbbnvtoqETUcNZ4owhDfYw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=to8kz4be; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673446772; a=rsa-sha256; cv=none; b=0fqzKX4joAEcjga4d2KRKCmPD7CYyRqOiANhIQXFAaWUH1btP7fdbcCvA1lkC5sR16yBDw l0H9dxyyWfc/KhG0A2mXsgFu+fqJyl0W49jJvMV5CyGZNUgpcRTfXjlPmNSyfhkJSdYCDT iZgrlZLI6PQgbSfGpL/2axGvJ5RBtNA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9A73817BA9; Wed, 11 Jan 2023 14:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673446770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aKKeQDX5M27cS/Y9GBuMn/99ULlrTykEwpfkno661Kc=; b=to8kz4beF0J5+Jua7QNB8vFl6GUJjWv2r5Gk4VJFgzU5OoWyXI6qVdVJVqfLsAHAwBIpd+ JcW/8PLRwK64v0/VdyJlj2HPas1hD2siFx/d3EnLP/Rsu3Zr5OxTrjTLp9kkNvY1vFT5Jj Psify++zY792qbyISArVvzllMunvKnM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6905313591; Wed, 11 Jan 2023 14:19:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id giKtGHLFvmPKCwAAMHmgww (envelope-from ); Wed, 11 Jan 2023 14:19:30 +0000 Date: Wed, 11 Jan 2023 15:19:29 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Yuanchu Xie Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Yu Zhao , Andrew Morton , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 2/2] mm: multi-gen LRU: cgroup working set stats Message-ID: <20230111141929.GB14685@blackbody.suse.cz> References: <20221214225123.2770216-1-yuanchu@google.com> <20221214225123.2770216-3-yuanchu@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <20221214225123.2770216-3-yuanchu@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 9zihicj978eh16fggurbeum8d7itenr3 X-Rspam-User: X-Rspamd-Queue-Id: 175B81C000C X-Rspamd-Server: rspam06 X-HE-Tag: 1673446771-338103 X-HE-Meta: U2FsdGVkX1/Uoc4vQf5VYjrj4O0nhcj0+a861AZeLKasCNnQHWfrj53bwfWSCfe8Z2+vY44QXGFUdlnzRgXavg0WCWS9KO/OWXMm2xCas88uPk570B+bxFWzw2MefAaR7dJqRW9u6Vp3+30zWVoNzLnLb9nlq2jicp3Zdj3UEv+RtZMWkhJXhottGw+bNQBWAB2lvvPyxEI7w3Y6fLWVLps23m71n2X14/5Hwa+PwFMWO01DPtG+t2APVV2c/I+HcU10slkcVllZIrxLJE4HWYDaQRvmRPLt5nZ/48aKiXRnzhrfZrHe8QQWeWIMGI0mGuH0ItHYSXpg6AurKyGKAP84HD6VlXcxNwuJYlD8MM0q0qsltyEbwMIkdobfKENTJPojKROyrHmpYZTLf2yi7A8Q6p3NhK/lnk+H7x5Hu53xN+6n7F7vKVaVsiEwpOo0S27AFPD5F3DN2EAFr6TAvpo1aibJV/swj61UgAq/4WR2wUHMtsE645A+R91ZlpnlaC32v9meSFI1rQV+WmCi6aOnZ+HW+AbFz7Ajp77O7rISRsF1WZmsmls0hWefMpwOK+kun54bgBLqDU/74rv2xVp/mMKuMwFCKwukYvzZlnKVYH7lsaGpQD8pelh1IwE1CL7UV+Q/vVfF44o9KymaC9DwyFzhQgqFsKdIB827sezOLo+SphgeuQfwuyex8pwfRfij2Q8XsI9Qvm4tN2ld7HBCu449ddRHtejNkxpl5YkdRF5FjKrYZ9cf620DrkmFh0EmJTKNganIsqJt6XsJZ6f6pCVgLbnpcnMtQVhGvC5taBlVVJWv5lP4Urc3GnpoSfgUpcE7zzXWahtDmDZyoeDC/d6hj/z4keDilhRxIPzdggE3S8qfEUuFvtfYSudUBEypapqEnkGSrCl8vz5q35yCzVIPmwU82ghSIKdZWOAZm7tea8kbiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 14, 2022 at 02:51:23PM -0800, Yuanchu Xie wrote: > +static int memory_page_idle_age_format(struct mem_cgroup *root, > + struct seq_file *m) > +{ > + struct mem_cgroup *memcg; > + unsigned long *table; [...] > + table = kmalloc_array(PAGE_IDLE_AGE_NR_RANGES * nr_node_ids * > + ANON_AND_FILE, > + sizeof(*table), __GFP_ZERO | GFP_KERNEL); > + [...] > + memory_page_idle_age_print(m, table); > + return 0; FTR, the table seems leaked here. Michal --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY77FbgAKCRAkDQmsBEOq uYurAP9JGeUGRS6AfrMninhvfGTvmei8qAImveRp13FIRINKGwEAlYRvprpP/hbL IvrnjwZQ0UVS9+oYjQTsbbZbJVGfhgE= =qQ2L -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--