From: "Michal Koutný" <mkoutny@suse.com>
To: Yuanchu Xie <yuanchu@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Yu Zhao <yuzhao@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <songmuchun@bytedance.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] mm: multi-gen LRU: cgroup working set stats
Date: Wed, 11 Jan 2023 15:19:29 +0100 [thread overview]
Message-ID: <20230111141929.GB14685@blackbody.suse.cz> (raw)
In-Reply-To: <20221214225123.2770216-3-yuanchu@google.com>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On Wed, Dec 14, 2022 at 02:51:23PM -0800, Yuanchu Xie <yuanchu@google.com> wrote:
> +static int memory_page_idle_age_format(struct mem_cgroup *root,
> + struct seq_file *m)
> +{
> + struct mem_cgroup *memcg;
> + unsigned long *table;
[...]
> + table = kmalloc_array(PAGE_IDLE_AGE_NR_RANGES * nr_node_ids *
> + ANON_AND_FILE,
> + sizeof(*table), __GFP_ZERO | GFP_KERNEL);
> +
[...]
> + memory_page_idle_age_print(m, table);
> + return 0;
FTR, the table seems leaked here.
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-11 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 22:51 [RFC PATCH 0/2] mm: multi-gen LRU: working set extensions Yuanchu Xie
2022-12-14 22:51 ` [RFC PATCH 1/2] mm: multi-gen LRU: periodic aging Yuanchu Xie
2022-12-14 22:51 ` [RFC PATCH 2/2] mm: multi-gen LRU: cgroup working set stats Yuanchu Xie
2023-01-11 14:19 ` Michal Koutný [this message]
2023-01-10 6:25 ` [RFC PATCH 0/2] mm: multi-gen LRU: working set extensions Aneesh Kumar K.V
2023-01-12 1:50 ` Yuanchu Xie
2023-01-11 14:17 ` Michal Koutný
2023-01-12 1:38 ` Yuanchu Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111141929.GB14685@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=yuanchu@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox