From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8509C5479D for ; Wed, 11 Jan 2023 04:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D2868E0002; Tue, 10 Jan 2023 23:29:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481F88E0001; Tue, 10 Jan 2023 23:29:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 349A48E0002; Tue, 10 Jan 2023 23:29:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25F958E0001 for ; Tue, 10 Jan 2023 23:29:41 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EE908A02E8 for ; Wed, 11 Jan 2023 04:29:40 +0000 (UTC) X-FDA: 80341239720.29.870F684 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 5FDD7180002 for ; Wed, 11 Jan 2023 04:29:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="OKBEjY/b"; spf=pass (imf24.hostedemail.com: domain of error27@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673411379; a=rsa-sha256; cv=none; b=EL/WS3hEFDaxIb7iZT7Of0w5b7ma2cAserumw3Tx0Mpt3B6JBnegrVawE2gcg0ISDmM0C5 sR9zIVI/uJmvWEvpls9wcj+apDcBE08im7w/s9yyk52WztvvjJGCY8SCN21+QpWaeUmDYM eH3LSyUpduBII61QPlCsVBDJG4AYFio= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="OKBEjY/b"; spf=pass (imf24.hostedemail.com: domain of error27@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673411379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ActnDnEMNIJcjx6Fcc4BvA+ksPG0xbjSPfDABpliDI0=; b=MnaaUNBU77rs9GaGGtVowWP/UZkDQzOe3hxLQKpvcl98ZscMKxOBaYfUPizfkjZXYwo3X6 691WuYsI+gzWkgbrriGiQlIaMF3gICaQNJLBmR6NhjjxfVd6m2t+tOEL1gbYcSyCtPAdFS jtCQmXDU5zHFB1e/xI0SPGHzAtpdhv0= Received: by mail-wr1-f43.google.com with SMTP id e3so4643645wru.13 for ; Tue, 10 Jan 2023 20:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ActnDnEMNIJcjx6Fcc4BvA+ksPG0xbjSPfDABpliDI0=; b=OKBEjY/bn+xjPermKEeUaqLp/DXKKvGIF3vK0zJystn+Rp0dPWImUNfTtmmM3pS+AG rR9sLB7h1zkQUopoJ9wzUan+zXiiujLnjuZ/5YRAIcrI5oH6wSbKEAjTuF35IVTwvntY tc82pRamtNzOHdAVmxFvJf/df9u1g+cAQgnEkTrGsNit6XLoTS7LjNcwX0OuqkgdMsyl ELECvyUuFVJav0HBLiqE6Co7bG5yy2kRA8tyaOt2URmzPgUBdARfu5AZ8ONDmil1hils EysqhvKQg4ybylYiZINIcujBPTS5SbzmPL2vlkcHq37N8n/3jKwc+ddve+avwkZ4uoky avmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ActnDnEMNIJcjx6Fcc4BvA+ksPG0xbjSPfDABpliDI0=; b=BVrctSitixwWj0kLetjwfrdRuHzWxTksdHNfVyNNAHhEihjABFdqLmh03WU0czUSW/ +ds1c0cC9PpuW+K9ZkJRN3r4XnJnOV/fczbD7zBYwqCm4c9bB8svxZ+5HMFmHZ1F56e6 0ElMB+7gGR0yxOIwL14aHfrR6H6ka9lymp9IMgA7q+82a23r54ClhJkfzVO197nuKhKn S0MxInXgxtkIeJyvS2yJrdrGUyMhVfJXnuX+etY92Xp7/0MrLQ0EqbYG7+Ddh9LHAqX2 fbdv21meeLYDgcvBRoFVHBgmj+IlUJCWAhceIg3Fb0gPW7OqIZjQmu4UcP7lRIyTgQrJ 1TkQ== X-Gm-Message-State: AFqh2krXokpZaiGEc8hMJUD7pcBPRSiAHnjZbXftU3kBAAzil0wmcklC hlB/vt7/i6gmVUson41MF3I= X-Google-Smtp-Source: AMrXdXtecgQRGjTyuOiuOgaJtePQEqMUWk7VW2nMFUQVtmEvmMSD/Do1XBBi5drfYAMbccCj/UARoA== X-Received: by 2002:a05:6000:1e1a:b0:290:968:f1ac with SMTP id bj26-20020a0560001e1a00b002900968f1acmr29698592wrb.33.1673411377966; Tue, 10 Jan 2023 20:29:37 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bt19-20020a056000081300b002bdc3f5945dsm325237wrb.89.2023.01.10.20.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 20:29:37 -0800 (PST) Date: Wed, 11 Jan 2023 07:29:34 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, David Howells Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:pending-fixes 135/296] net/rxrpc/call_object.c:303 rxrpc_connect_call() warn: missing error code 'ret' Message-ID: <202301111153.9eZRYLf1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5FDD7180002 X-Stat-Signature: n9dg7rikyp165zz3956b3wph3ooe5nfb X-HE-Tag: 1673411379-78941 X-HE-Meta: U2FsdGVkX1+fy0R3oeTQ0jsU8SAhQIu70D1Od7moKfrlu0mpbdKKqdi1veqtxmkqZo5CzJqzvfe67wvOOJ+lUE+ddzWhX85KrRHODqyrD1GsnFSFo7HXQT2lHG7lMh2khxd47tLdNQkOJTzbpFZLnAvKTUf1KBXWKJQ1ae0wA/6Jjv8DkpDYB8m+x2yAABIVqKAQkX8z2gTH+yg/fX0iR0/4QCy/BrFn6hERNZ7IMvDdrfQQyTtH3jNM+dj7MRPHXJYc8plNClVevhrjoe6QU6q0c5EjpHkGG9CIPIGPP1JDROQlo3Sih32A8hNfLLwSgwGyup+YIKU+jFYZDUdsDSvy6olTapkbpFtabLBryza02azgE3AfVYzNN59qNV5YBGtjJ8UV4/mJ0cF+B+mblVmiyxMIoyOkkRcI3vaexMrx/c28P+RYFU/Ol1kxqRkMwyFy0EwhhPc/SE1FNg1YLYMsutqp0x49lq1036+xNy3clPCmhWuCOeNzQ+0SOuMzGoP4+7NU5hgB+2Vtq3FFvK8aInY/PDWX4K/qKO28Z78PFSgaY5Vyz9e4Rg3DxpJWN3YImMltnSA8adl55mU7K2ufT+sDBuBQ5BzMcYcK6tHAZ3m1okef6Zn4jEHpxFXM+CNX620jGkFI/kmCORql/kdoBwtscKV84hCJxX67RTWpnZLGVWCOH5M/vd8kiHXy6RpS41WKZ8Jf7l58lwnA0mkqnRIvTQJTRfzBvn/kLzbYw9o7/RHu5Db80NeAflql+ZWCl4nFTqckNgJ78XEiUhcOuWfHkg6rmA2W0uEffUgLczxnOVTip/IqNBeRLahVM3cB6oIEkX+GFzhmvxtJyzrqjDO9cPetBmjPiHTeeSVmSfk42V8g0EoFhyGY9KmNpe93daq1VCknVPJrLvp4eE6N790HxEHl5Jz8OYNNEyw/sGah8QnzNYPxb99rZT43Il8ElROJjqlVkZTj7ws zwRcNczj qCdvJlfERCqkPHg/EXjP0oUC+R4mE5Coka1DMDcsy6yAuZf4JdaaVVRhA2vemvyjdpRQIt26pkGN/l3aqrKKg5JpnWSvbdmQudOL2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git pending-fixes head: 79fa898551af3fa16837f16294fdc8724b405762 commit: 9d35d880e0e4a3ab32d8c12f9e4d76198aadd42d [135/296] rxrpc: Move client call connection to the I/O thread config: x86_64-randconfig-m001-20230109 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: net/rxrpc/call_object.c:303 rxrpc_connect_call() warn: missing error code 'ret' vim +/ret +303 net/rxrpc/call_object.c 9d35d880e0e4a3 David Howells 2022-10-19 294 static int rxrpc_connect_call(struct rxrpc_call *call, gfp_t gfp) 9d35d880e0e4a3 David Howells 2022-10-19 295 { 9d35d880e0e4a3 David Howells 2022-10-19 296 struct rxrpc_local *local = call->local; 9d35d880e0e4a3 David Howells 2022-10-19 297 int ret = 0; 9d35d880e0e4a3 David Howells 2022-10-19 298 9d35d880e0e4a3 David Howells 2022-10-19 299 _enter("{%d,%lx},", call->debug_id, call->user_call_ID); 9d35d880e0e4a3 David Howells 2022-10-19 300 9d35d880e0e4a3 David Howells 2022-10-19 301 call->peer = rxrpc_lookup_peer(local, &call->dest_srx, gfp); 9d35d880e0e4a3 David Howells 2022-10-19 302 if (!call->peer) 9d35d880e0e4a3 David Howells 2022-10-19 @303 goto error; It looks like returning zero is intentional here, but I'm not 100% sure. 9d35d880e0e4a3 David Howells 2022-10-19 304 9d35d880e0e4a3 David Howells 2022-10-19 305 ret = rxrpc_look_up_bundle(call, gfp); 9d35d880e0e4a3 David Howells 2022-10-19 306 if (ret < 0) 9d35d880e0e4a3 David Howells 2022-10-19 307 goto error; 9d35d880e0e4a3 David Howells 2022-10-19 308 9d35d880e0e4a3 David Howells 2022-10-19 309 trace_rxrpc_client(NULL, -1, rxrpc_client_queue_new_call); 9d35d880e0e4a3 David Howells 2022-10-19 310 rxrpc_get_call(call, rxrpc_call_get_io_thread); 9d35d880e0e4a3 David Howells 2022-10-19 311 spin_lock(&local->client_call_lock); 9d35d880e0e4a3 David Howells 2022-10-19 312 list_add_tail(&call->wait_link, &local->new_client_calls); 9d35d880e0e4a3 David Howells 2022-10-19 313 spin_unlock(&local->client_call_lock); 9d35d880e0e4a3 David Howells 2022-10-19 314 rxrpc_wake_up_io_thread(local); 9d35d880e0e4a3 David Howells 2022-10-19 315 return 0; 9d35d880e0e4a3 David Howells 2022-10-19 316 9d35d880e0e4a3 David Howells 2022-10-19 317 error: 9d35d880e0e4a3 David Howells 2022-10-19 318 __set_bit(RXRPC_CALL_DISCONNECTED, &call->flags); 9d35d880e0e4a3 David Howells 2022-10-19 319 return ret; 9d35d880e0e4a3 David Howells 2022-10-19 320 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests