From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Yishai Hadas <yishaih@nvidia.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, jgg@nvidia.com, logang@deltatee.com,
hch@lst.de, alex.williamson@redhat.com, leonro@nvidia.com,
maorg@nvidia.com
Subject: Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly
Date: Tue, 10 Jan 2023 16:03:47 -0800 [thread overview]
Message-ID: <20230110160347.c1d771e4ea21e4b95bfa8477@linux-foundation.org> (raw)
In-Reply-To: <f37f8e60-d580-0b7c-0fa5-a26ab49c9781@kernel.dk>
On Mon, 9 Jan 2023 20:18:39 -0700 Jens Axboe <axboe@kernel.dk> wrote:
> On 1/9/23 7:47 AM, Yishai Hadas wrote:
> > The last_pg is wrong, it is actually the first page of the last
> > scatterlist element. To get the last page of the last scatterlist
> > element we have to add prv->length. So it is checking mergability
> > against the wrong page, Further, a SG element is not guaranteed to end
> > on a page boundary, so we have to check the sub page location also for
> > merge eligibility.
> >
> > Fix the above by checking physical contiguity, compute the actual last
> > page and then call pages_are_mergable().
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>
> Andrew, can you pick this one up?
This patch is against Yishai's
CommitDate: Thu Jan 5 16:01:05 2023 -0400
lib/scatterlist: Fix to merge contiguous pages into the last SG properly
which is in -next, apparently via a tree of Jason's. So I'll assume
that Jason will handleit?
next prev parent reply other threads:[~2023-01-11 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:47 Yishai Hadas
2023-01-09 18:08 ` Logan Gunthorpe
2023-01-10 3:18 ` Jens Axboe
2023-01-11 0:03 ` Andrew Morton [this message]
2023-01-11 13:28 ` Jason Gunthorpe
2023-01-10 5:08 ` Matthew Wilcox
2023-01-10 8:01 ` Yishai Hadas
2023-01-10 13:53 ` Jason Gunthorpe
2023-01-10 15:05 ` Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110160347.c1d771e4ea21e4b95bfa8477@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=maorg@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox