From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC131C46467 for ; Tue, 10 Jan 2023 23:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03E3B8E0002; Tue, 10 Jan 2023 18:18:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F06968E0001; Tue, 10 Jan 2023 18:18:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA82A8E0002; Tue, 10 Jan 2023 18:18:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C52A18E0001 for ; Tue, 10 Jan 2023 18:18:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9BEB61210CC for ; Tue, 10 Jan 2023 23:18:45 +0000 (UTC) X-FDA: 80340456210.21.1E8306F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id E40DB40014 for ; Tue, 10 Jan 2023 23:18:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=syzxvEG3; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673392724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lLdl4WVOaoFufveIzKd2WoV5JXBLLKx2viavyLAWLzg=; b=47o6pqiAL6G0fhDbPuV9E0A2vONA7homYz1Wc3MV38ATp7tsY6pcs01sCVw1Hqy+3hQ1Gz JKIYGD9Rnx3hKTFdjlcV9uxGFaidyTk7B7qH33OPbn3zx5BnmprUImST0WDCWcEJPI9FmB 6/av92eetI58K+RDREwHpWfdYddZzDQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=syzxvEG3; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673392724; a=rsa-sha256; cv=none; b=8BpWFi39B2d9W25IWDwLVxqzEtt47PAedz2L+UIlLmMuFFE3eHOniFbXH1oE3RpvO3bAjB 0y05aoVJuDQgn53ExCLlN4II+WmgMIKIDrhV8n2L20s3w7Ll1YIOQqh42GRKirkxRp2kY3 aoUp60VaqV+gKK5wKX0YMYDbk2ap03A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A653561964; Tue, 10 Jan 2023 23:18:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42723C433EF; Tue, 10 Jan 2023 23:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673392722; bh=1FrDLc773XkQj+lO8Vh4muEBRRgPkXtE/hqrdxursgo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=syzxvEG3JVxdj2XSfnkR3ErqWix6EtLHHPHXoEY/wK4F97qafATMOvbdx3Ea0QrRH Lcd0PEYmHht3egw7ziC6S3WNl+V155qeZ898xCYFNWoTt3YcNwdQIDzHp66TEADkpJ 6TmTTfGS24C0FPxVO7hgyADewLZp8f2A86FrpUF8= Date: Tue, 10 Jan 2023 15:18:41 -0800 From: Andrew Morton To: Liam Howlett Cc: SeongJae Park , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "maple-tree@lists.infradead.org" Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup() Message-Id: <20230110151841.149f2bd34dcc7ebcdd6bbaad@linux-foundation.org> In-Reply-To: <20230110142109.gphhirh7jo67br6x@revolver> References: <20230109154012.3342cbb91defbc485db641c1@linux-foundation.org> <20230109234317.1408-1-sj@kernel.org> <20230110142109.gphhirh7jo67br6x@revolver> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E40DB40014 X-Stat-Signature: mrcwaowas3faqideoco4oktkmheupncu X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673392723-851445 X-HE-Meta: U2FsdGVkX198jgTfTZ04UvKHUeIXgndg1tAD0rBIEJfWzvGJsI+sN1BJygdE/IwUwPR5IQbMi56bmSwjUjf+vXEtI4aJYTyNzYA+sDs/vgmfw5AxAEtAmXlMnuHBVIcMUkELP7ZC9+8vRkoTMmpddzLipDGjaTXNiGV3old7d7nmv/fcPGBrsBIvnYFIG9vHu9HHpT3gsTvDYHu9HUmHuf6NeYybgo8SLhgb/tekxBcmfTE2CcR/nqYni0hG3g9chLrKeaq0EQuBz/bcN4Eyhfz/Wfi60jZuX5VLOs4HI+2Fiq/3DfkkIuhGc4u66AtRKZ+iPaf/nj7sdlac5yLbbNM7ng4NE8Ck6PZHPeD/ac2BVXhxaga0yYVnoL2nYx3MRcbqzZPyxIF8LpYKI41N6cKj2Dsf4lRBOULoySzw7i56BXqbEbpwoTSnvxx7G6yv225s76wucKzKe9sOQxIotCoHZx8RqSkjbY+ko/fZPsNlCJWJRlMyEJuVEMRAvY5qbU9+lgX94u0JGbD0vjYIjAnhMKahW509Jr2F49hAfvjw2cW7LONJVkppbLYZoR3zIRI7hePpi9KljEaFbwmfhlJSBhd3uPr2hiaUKNrJ8jIhExu3J6Gh2nZnldVOBkxEnryXLsA+V6TTCAafk2MUOcNw+kC1Cug9cGW5TpXTQAAoCdD8xooiAYIO24qmHbJO76xoNGfKvpTTCF3GMmtupGHtAJEyiZoySd6M1Iyso0fzrTSkkE5DGwLrB4ibqEyeUVV8YDO/Ro/iff1u4nBixg/RCG3Ao9UYvRAwv4nd7TlNzJwrl/PU8E5v4oqIZugQelX9Y5Ho7XPQtQgPqKyTRsFyBnuti2hD0cG1Z9qhbSfe0sulX+GMFacZyMCdCoQpA6L4kDIv9xx1Y5NhEOeWpJGYoE4HXPOOor5Am6Fce4UaZfJAJsxrE7YrUTk7f8y/i//uMf3MR3PakYKaULq 9H0pk5pm DvEswypGczUrjdzUnwl4PZVVctDam0NjaM76f0g+1DHDFIyJsvduEg3kgy0GoOiH/px81BjwHYErmRGOm3cknZpHIY09ocwHS+Cyq7WL15YPav1/SAigB5tLHLDk8L7kXi0c6eGJe9RlFY+D9h+FNUOWip9F4U0ss0OZe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Jan 2023 14:21:15 +0000 Liam Howlett wrote: > * SeongJae Park [230109 18:43]: > > Hi Andrew, > > > > On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton wrote: > > > > > On Mon, 9 Jan 2023 19:22:48 +0000 SeongJae Park wrote: > > > > > > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett wrote: > > > > > > > > > If an invalidated maple state is encountered during write, reset the > > > > > maple state to MAS_START. This will result in a re-walk of the tree to > > > > > the correct location for the write. > > > > > > Can we think of a Fixes: for this? > > It wasn't really an issue until I wrote the vma iterator store > function. > > You can put this before (mm-unstable git id..) > 9df3d25a97ec ("mm: expand vma iterator interface") I have dropped "mm: expand vma iterator interface"'s series. Should we retain this patch as a standalone thing and is the changelog still appropriate?