* [PATCH] userfaultfd: Fix vma iterator conversion.
@ 2023-01-10 18:43 Liam Howlett
2023-01-10 22:43 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Liam Howlett @ 2023-01-10 18:43 UTC (permalink / raw)
To: linux-mm, linux-kernel, Andrew Morton, maple-tree; +Cc: Liam Howlett
An extra vma_iter_set() was added to one of the loops over the VMAs.
Remove this set as it is suboptimal and unnecessary.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
This is an mm-unstable hash
Fixes: c6fc05242a09 ("userfaultfd: use vma iterator")
Please squash this patch.
fs/userfaultfd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index e60f86d6b91c..55f3af6689b8 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -1620,7 +1620,6 @@ static int userfaultfd_unregister(struct userfaultfd_ctx *ctx,
break;
}
if (vma->vm_end > end) {
- vma_iter_set(&vmi, vma->vm_end);
ret = split_vma(&vmi, vma, end, 0);
if (ret)
break;
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] userfaultfd: Fix vma iterator conversion.
2023-01-10 18:43 [PATCH] userfaultfd: Fix vma iterator conversion Liam Howlett
@ 2023-01-10 22:43 ` Andrew Morton
2023-01-11 1:06 ` Liam Howlett
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2023-01-10 22:43 UTC (permalink / raw)
To: Liam Howlett; +Cc: linux-mm, linux-kernel, maple-tree
On Tue, 10 Jan 2023 18:43:03 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
> Please squash this patch.
It throws a reject.
This series is getting pretty mauled. I think I'll drop it and ask for a v2, please.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] userfaultfd: Fix vma iterator conversion.
2023-01-10 22:43 ` Andrew Morton
@ 2023-01-11 1:06 ` Liam Howlett
0 siblings, 0 replies; 3+ messages in thread
From: Liam Howlett @ 2023-01-11 1:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel, maple-tree
* Andrew Morton <akpm@linux-foundation.org> [230110 17:43]:
> On Tue, 10 Jan 2023 18:43:03 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
>
> > Please squash this patch.
>
> It throws a reject.
>
> This series is getting pretty mauled. I think I'll drop it and ask for a v2, please.
Sounds good. I'll send out a v3 after squashing & cleaning things up.
Regards,
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-11 1:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 18:43 [PATCH] userfaultfd: Fix vma iterator conversion Liam Howlett
2023-01-10 22:43 ` Andrew Morton
2023-01-11 1:06 ` Liam Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox