From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E058C46467 for ; Tue, 10 Jan 2023 08:24:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7FDA8E0002; Tue, 10 Jan 2023 03:24:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E0D8E0001; Tue, 10 Jan 2023 03:24:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C3E8E0002; Tue, 10 Jan 2023 03:24:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 815B78E0001 for ; Tue, 10 Jan 2023 03:24:37 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 52419A0102 for ; Tue, 10 Jan 2023 08:24:37 +0000 (UTC) X-FDA: 80338202994.18.0B7AB6C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id BD26740002 for ; Tue, 10 Jan 2023 08:24:35 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673339076; a=rsa-sha256; cv=none; b=SDAA8oORzgDfuuFahOUlK1Jg45tMfMDI6n++EdTlL56oLOgZYgVKVcMadAW7zy9YO34uEu 0S35XoqwlPF5ap3Ge0FYr2LafHf28XjSyb5KFhWeynYPMit4jSF+AMDLDi4KTlQ6yj5fNl 8da16HexN5zuicoQrpf1k8JhGZdOyjY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673339075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LuMYbQ+c/eNEEG6OnFpz8MeGm4gJCpDK1EeG/X8I5VM=; b=mcjDnrBVNLH+SiBSLSZj9I10LhdRIPzmroMoOl6JP0GvSnQL1fsdz3lKJ5xUNsP5Gu3toc hNgw1fLfApOjA6XPw0WiFhb6cvkHuw2ZzNZu7sKtGlbOHObi8ksKZBwff9jyViCAGB15gw zgEFJg6vl3J7RPhRYzfOnLD5kqujaPs= Received: by verein.lst.de (Postfix, from userid 2407) id 4A99F68AFE; Tue, 10 Jan 2023 09:24:29 +0100 (CET) Date: Tue, 10 Jan 2023 09:24:28 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/7] sysv: don't flush page immediately for DIRSYNC directories Message-ID: <20230110082428.GC11947@lst.de> References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: BD26740002 X-Rspamd-Server: rspam01 X-Stat-Signature: ksidd8gyuskoxdg9cpcrefxuubfm5xgq X-HE-Tag: 1673339075-791068 X-HE-Meta: U2FsdGVkX1/kbSbgvJ4HpYX5LhgKu4rpKpzVY9HThIbgf/Jta2675jhYS4Q2iiAdZbgZrBfHcGKs1aYuZKBawcjGxYEEZsMhrBs6edfj0ZL1fLF1Aao77bqnFzDKqs0FHO4UMI5WNq0vO1v4C3V6Bb9MafjDUqd7e1fVAF3s9T7acsAnpvWn/IUmBopAuKeh3cW8imRS8i3gfo6J9Qj6QXgYTmT3imUX1KJLIdp3Elv/wY0isQ8JjXKZdqyixUNeJHFtCWEmeJVyJQQ9kd8ink9ArakT7MuwdVKe6Vh+4n0TawWy1pnO/bRhYsoMXvsPfPPalTO0ynHnBTIS1EMyNKeomHm4yV3bq5zDOAdZktCWylPyPwPccuz8e235+R4QjFY+RROIJpUjGBFEzK5PpziqnwhoYcXN2czJoSkLxgtbrp1Xtb8uKdJah1PGkMjHwCnojDt6qDKwiIK8NUWk/xVJAQogEdjigXgE9XZYxvq0GfMz9RPbhm2Yokg6FhNKPsdtWjdm0PTGNgqb9UXs5mA5drlOaROHqlSG4JRV4VHmiiaR2is6kPhmzdnFDyw4GLi18iUdft0DAiKfcHZF+rHpfnVnJEusbipTUYfL34D52ZP6VUyBKY9OVRLrjad0tKQB/ch5jLDSATXkFoVng5hT1XaythWMIhSE8HTo4UJRFvDWtJ99QIOoQhhZEk6ajlY5k34hhxB7an8TRXgt2i6QtL18a48aQK6wfzu+QbZMHeOl5VQkBpz3Kqo/q1y+x9jJgp9g4xf6HTChSel6OA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 09:19:22PM +0000, Matthew Wilcox wrote: > On Sun, Jan 08, 2023 at 05:56:42PM +0100, Christoph Hellwig wrote: > > We do not need to writeout modified directory blocks immediately when > > modifying them while the page is locked. It is enough to do the flush > > somewhat later which has the added benefit that inode times can be > > flushed as well. It also allows us to stop depending on > > write_one_page() function. > > Similar concerns to the minix patch here ... missing assignments to > 'err'. Fixed.