From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842C2C54EBE for ; Tue, 10 Jan 2023 08:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E4438E0002; Tue, 10 Jan 2023 03:22:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0931B8E0001; Tue, 10 Jan 2023 03:22:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC3D68E0002; Tue, 10 Jan 2023 03:22:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D8FED8E0001 for ; Tue, 10 Jan 2023 03:22:31 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AE6E5C0620 for ; Tue, 10 Jan 2023 08:22:31 +0000 (UTC) X-FDA: 80338197702.11.178E00A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 22B71A0009 for ; Tue, 10 Jan 2023 08:22:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673338950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6Q685JpN2BmZ6cybFrDhyVWNToJ/u3DRxYMK0X6EnM=; b=c8JkoM0VBg6TcmnGg2F8V9zhooAFOcm+Bawpt6rkhM5TdI1bQ/s66GvjzTYeddETGGyBqP R+Ruvwqt0lQ+4AtK5Y5oHoBX/zs2fw6tcPd1OvmqKmGAtDi4yfmLecJwA38tGEYSLrowhH 9/VI7hhPMZ6b1hUuolBen6u82JnY21o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673338950; a=rsa-sha256; cv=none; b=YmfabEESAxNEwJeB3wPesgqAHYiYCKLxxawklrWoEm95fTsXKyIZHNdvkldQjI6fsVUrQ8 GZr/BqyNoweoNppAmZfjTpZww1Z30r1Lo+E5n+kfpRTNaSTv76qJGd1APo5+i/ZA6PQgFr S1G+f6jcMwHWFvJVXp3h3FElmhyMpU8= Received: by verein.lst.de (Postfix, from userid 2407) id 5B94068AFE; Tue, 10 Jan 2023 09:22:25 +0100 (CET) Date: Tue, 10 Jan 2023 09:22:25 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Message-ID: <20230110082225.GB11947@lst.de> References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 22B71A0009 X-Stat-Signature: su47sz3pdj6xzpk71hj1yj4in9zwtwoo X-HE-Tag: 1673338949-423962 X-HE-Meta: U2FsdGVkX1+qBt8JLOb269ZNRmmGX4koGvYJErIDFFlXkQ7vNPyoR9U0jZkk7YBZi/AMM9dI+5Z0XRorc/KZYRdx5zWgYGdlN8NHp2A1Kxb7JPahdCUS3RPbrVUB3zk5hUecrgA9ybEpGpRu+J45jahNbUj+v5dS+Xv2ErBaIrJRhiKlwd0kNbeAF78CNwR+Tq7Hl3s9KbXjn8tZnYMut9fHCcTuiBOzH/Mmyk6NQ+metT2crnU628kb5l6dj3Xt+2JT3zh9H8/OxWrPW+ZasBicbpi3STkaJA5ujTzPLCAS2bE85M30FMDW/S2ng3/rPTmueGAtC5LpmsSDfIyJKeYXCQ6YJRLyVwxxO2/blFOCLSlXcZLFwH6f35WMN+5dNTyat5o9LcoddllHzEPmreQCu4AQ97Cn6ONdhQhYZlunEG9/OTHAfJ6yV6IVs1/wf4AlOfmF0mmfpY7amSnDiGKaqBlytOucr+/z3R4xq+9YDihyw3lM1/wTiIRihJv2z4j40bSt5llg4BITuxBH4Wxr5CKkRebU+2xsWOU3ak0AsqBtlpQAjZ5u7T3atWs5z5ubAZ3Pj+5bzoD8bCH+HVJ/FFUwu/Di+McFYfZoi3aziriaGaeLVZHYyZ1W7Iwaw3+fVN0CJmMr7AABLdrsfkYt+WrMDKSovn68DxHk3JZdyE+27I8Rs+bRWstAQd0NVP/EXORur39GmLbhHh6Yre+lYtxkxKP0kprBnlTXDSnQfD27mKtEQu78HQNkxLIb9iknUBtxsDiCBTURYqarPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 09:17:26PM +0000, Matthew Wilcox wrote: > > + dir_commit_chunk(page, pos, sbi->s_dirsize); > > dir->i_mtime = dir->i_ctime = current_time(dir); > > mark_inode_dirty(dir); > > + minix_handle_dirsync(dir); > > Doesn't this need to be: > > err = minix_handle_dirsync(dir); Yes, fixed. > > > @@ -426,7 +436,7 @@ void minix_set_link(struct minix_dir_entry *de, struct page *page, > > ((minix3_dirent *) de)->inode = inode->i_ino; > > else > > de->inode = inode->i_ino; > > - err = dir_commit_chunk(page, pos, sbi->s_dirsize); > > + dir_commit_chunk(page, pos, sbi->s_dirsize); > > } else { > > unlock_page(page); > > } > > -- > > Aren't you missing a call to minix_handle_dirsync() in this function? Yes, fixed.