From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E372C5479D for ; Mon, 9 Jan 2023 19:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56A98E0002; Mon, 9 Jan 2023 14:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDFAB8E0001; Mon, 9 Jan 2023 14:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80D38E0002; Mon, 9 Jan 2023 14:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B50D28E0001 for ; Mon, 9 Jan 2023 14:58:48 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6EDA8C0F0F for ; Mon, 9 Jan 2023 19:58:48 +0000 (UTC) X-FDA: 80336323536.20.0D50DD1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id A855C40002 for ; Mon, 9 Jan 2023 19:58:45 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=r7nHWucU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Qo1EnZ1K; dmarc=none; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673294325; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uqf4EYPtaa7qRzGaumggMD5PgDktxPAtMHctMr6gLGM=; b=cF7id4SHrD62uP3/TfykYY9qxZQkYNx186aGiCV8tUOEwrbU+pI263SoTe/0evVVIIeqmv hGHWr0vwTIXb4OnrMts+qzbWqWVMBZnjt1L9Wocdq0J8k5cVgEndGUKXP7j+NYSeLff1Nt MoXRWuhF0jkvIKie+ylmxqYMOtUKrVM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=r7nHWucU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Qo1EnZ1K; dmarc=none; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673294325; a=rsa-sha256; cv=none; b=uXCZ34hDbnYy0Sokewypt8CuGBYYBU3XBhnm9rM3b07HjwxQBeFTdrSLx2zYk/V9NRWio/ mfjmEXDThS3D9bajsYSE5J8EgNMN6Y0TFyd1T2Mvx4VS1SepACCR1bLHqT087qikfMYcKY lejexi+uNDw7MU+h94t2XEH6rhJvteM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D39605BFED; Mon, 9 Jan 2023 19:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673294323; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uqf4EYPtaa7qRzGaumggMD5PgDktxPAtMHctMr6gLGM=; b=r7nHWucU7ucFRP3fhs/qdJJmi8IWTyjhS5HquIk9+er3pou1slI3Tziz1P0gwQy7fLoZWn pNhRpAn8fAwQwTWe0YhXV5w9A+rV5vlxyfEnw9PEInj1Ui6ywzhAWlFuJMzVZzgC6gUYUR 59kJnDFifOqb8cczNf6njyjHHZ3gf90= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673294323; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uqf4EYPtaa7qRzGaumggMD5PgDktxPAtMHctMr6gLGM=; b=Qo1EnZ1KxOKENH934JGqVsVzwnwFxxdUsqzwmMD8z8C/qM1N9F6aNZ26bkr587ylrLisjp sEHRddTliaeafDCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6ADCD134AD; Mon, 9 Jan 2023 19:58:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gEfeGPNxvGN0XAAAMHmgww (envelope-from ); Mon, 09 Jan 2023 19:58:43 +0000 Date: Mon, 9 Jan 2023 20:53:09 +0100 From: David Sterba To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: remove write_one_page / folio_write_one Message-ID: <20230109195309.GU11562@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230108165645.381077-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-1-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Queue-Id: A855C40002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i8d81xq87yxdioqwku14j3q1fkhess1a X-HE-Tag: 1673294325-807467 X-HE-Meta: U2FsdGVkX1/R3gljhKw2Rr8yFqYX+6cKb1vhZi0t22ozRZCXktQ5QyfZZmn8tx8hFGvj2IoY1V+9qBv0T5mxoh09TiWWN0Ig3rCOK16Km9cLueM1rnI5NtMHQUN7KhEEH5ngwLVrKGdvWRbiVd6JXobBEQB3j//kKoZfvO/CJPV8c4I5euFEO1QWWubZh5/3l8EpNNBZ9zolVKwfo5T809syk2fEo5wL26m/+FAM3xQsyOBBeJ7vcnwG7jkyycS3t20dipULFTX4jJU3BvDBoNzUCS7/1dDV8gTGuJul+hnCxlXaEVYTwj6Yos1uViL3tFuvntM4ZYOPGBXTik0tTj7Im4YqF4ZuAxPRSbuqXMr5EhKTkBGdEfpUOzcly5VpsSKKXA3wyoNrKXgkvZ5t6TiasZOmKgKebZOyfpa3/kukNisrlNiPPVM3ZTwkWipAY7QIjCqTkbMEw3znqEGuf5Uf41qJ+yg1pqBxy96vzkHdxaU4EbLPzLoEuCpSmf9Dmvxgdbvq6Bp8bbsqgY6lsWFoGvbq3l21sSNCyGxMkCWrpodGQ4R8rlO9pT2016Jezh+RxOPXB2QyAK/e9BSMeWzVOt3hcKBNoTvyWHCOis8qFCksW71bugYCqnUI9970OKTiN25rMk9SJRSL4uLtL6ifvlohMN3Koq7RYc4TCJtYT6TqSs33LzX8EX8KITwoTK5cU1ak8HPZcygKVnIvsjQPGxBiJTNxBlnXI/y/XTRSrPy59Y9rTsI0+hWyPuHv0niEx26xwW02JUOa4JhNKpDwSl0Ylor2V/Nx3v3rveBO7pJYv5DjpfvIR9TWyneeoIMCkwUwoBusmbTlR4aV4X26L1nZnQHme2lTvJZrSuFvd2OZTL8PlYQ2TfENQkeLUcWEajMe4FvwSG6ZdBsSdL/r8MGNUeWbCqpcrjYyezhJKEoUH3c7RWXUzobLcLLyqYZoYY7YbP9b7w/kAiA KzuCwJKa fcIADJkzSqJ+m7W9sXjpOutMCfAjgP2dajBc25fcuP5zlAps= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 08, 2023 at 05:56:38PM +0100, Christoph Hellwig wrote: > Hi all, > > this series removes the write_one_page API, and it's folioized > implementation as folio_write_one. These helpers internally call > ->writepage which we are gradually removing from the kernel. > > For most callers there are better APIs to use, and this cleans them up. > The big questionmark is jfs, where the metapage abstraction uses the > pagecache in a bit of an odd way, and which would probably benefit from > not using the page cache at all like the XFS buffer cache, but given > that jfs has been in minimum maintaince mode for a long time that might > not be worth it. So for now it just moves the implementation of > write_one_page into jfs instead. > > Diffstat: > fs/btrfs/volumes.c | 50 ++++++++++++++++++++++++------------------------ The btrfs patches were sent separately some time ago, now merged to misc-next with updated changelogs and with the suggested switch to folio API in the 2nd patch.