From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5CCC5479D for ; Mon, 9 Jan 2023 19:22:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4867D8E0002; Mon, 9 Jan 2023 14:22:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 437218E0001; Mon, 9 Jan 2023 14:22:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325838E0002; Mon, 9 Jan 2023 14:22:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2518A8E0001 for ; Mon, 9 Jan 2023 14:22:56 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D175AAB0E6 for ; Mon, 9 Jan 2023 19:22:55 +0000 (UTC) X-FDA: 80336233110.14.A430AD0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 3726F1C000B for ; Mon, 9 Jan 2023 19:22:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Eo/wJqgq"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673292174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJbY4hjvKSrIb1Z+aJ+N5rYxnKVh6YpPVZu/7RQrhgs=; b=ryemhV4GfGF1E0Gkw9jnxKyA7pfuniNE4AL8NqDKPWVO8V7r8asLBrFHiFDDcnSkwIWnL3 8uRc8wa8ybxLFRnuwQnjtK9es3xnwLN5+ufi4meYqiKZhHt73kf90uPoqKNbyJN0JXHifV 1M+XZBMHEHjCkQj2y+goPpdRIJC8fXY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Eo/wJqgq"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673292174; a=rsa-sha256; cv=none; b=P9ZOrQXJm0qQtVuGw8azRtA9Yp6onisAee+LwFZS20XEaELt1nlTp9UJ/QU7NQd/P4hxeh 1fT13fMElKx1W4G0mNaa1O4FIn8cjXgWA0XUx4AFLxkXdBIGMWX5wqtsOheDtqCYZ3ibTY e105nHU1TYjCiRuTL2v0vsMxdh8V9vg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3E475B80F99; Mon, 9 Jan 2023 19:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2AFC433EF; Mon, 9 Jan 2023 19:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673292170; bh=1nN5+8vpW7IEZWlJ5SAxUljzv4o1B741QRXt26soY7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eo/wJqgqrCF9C+wRp8CP4a9/NTfNfcMNw8C9PYuDJIrA4CBH+FD6MEXmbE0+67ifY FzsJOhpsDklYmeRTVQw5S0rFZP/E7R9Nvljj29dg305NaNcgZeXDXBO2DWJ2Tcq7Jl bdb5Fm0PtOuf4r+dwBCH7f5Rs00GlGId75Z66JbdxHLy74WkjeL+1teLIKAaqeC8Uk aV6U+N8PNPEH0eKoaMsDWpF9mYwwIuwxqYE2fdApA8oW50k3YJC9jMJRbOS3l8AahX WiHoGiFkkPn/XSdDSf0PbkLx4lfcFGCfljJ3/9CClzlf5jl5c8amuN0EYAcV+Y2oA3 irnGHYGgrbjsg== From: SeongJae Park To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "maple-tree@lists.infradead.org" , SeongJae Park Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup() Date: Mon, 9 Jan 2023 19:22:48 +0000 Message-Id: <20230109192248.55694-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230109165455.647400-1-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3726F1C000B X-Stat-Signature: rtr7oikboodqouoxh9dbgdubenp5fwaf X-HE-Tag: 1673292173-821291 X-HE-Meta: U2FsdGVkX18aDvtA0IbT6SpJMrkSkYGGLpJmHRs1WTYJwhtSGb4XCMi5cu4Q1PBGwJzoE5ZdpsjZRdlNOLvQQiEM4ihEhqyNagyvlazwg1ltabcsW8oczuwvYlCbIGyZim85Kj4MhyFMLhtANgtwrsWiKkAvzADcEDB6vvEE1DfSFikg4Z0kMOo/8QZe5bcikp1DiJxR+c6FAN81e+fyxjaQaXCguxNr+NNyifhcRVYfq6EtFyFmAfzuTBTxnnhdxasw7HSPbDeh6Lap02sd/7iYdzvPGIVpfOIXHDrQq24hssz0erLgNS5QMXXK6mJ64We4B/1l/Lo+MxLJk7zhcYe5ZDqSqns3uJUTXA7uCBVl27RymMuXHHxsFmxhCMdVKNTzbhfUDYgXxbME0VCBQsSjnhGRVmk2elOeFlP1pKN0VpNb17V9ww5MiAD5Cs91lbOFBb1mPlwX6h0peJxQUGXP8Y9Dt+6tsyJcOOPxlnf2CMM6vJpA+uCEYDg5ZIxCInl89TIvtT6nnleRsGjlcLdwDE8dE0c8hA/HMJKpvWOIlwlU3OAdueFI0vWFs0PB3gYodTw39wCjDy1QUFYv43RHdfEmZ/gPkDdjv2Bkn1bm5URpHUBLnExoEmHRA+KNrMqifXBx8b8SZcUnpO+wvza6hAQx+T5HN/hwjiq0U66LG9tRsERFJk9OpVghzcrahWaFAMnMM7LU6N24EZUnyc41aSdGXM9084oiu4f9ehXNLcC9ej9sHkZ5/pcVrJkpPb9IhNYbZjn4ytppFebAUOVsEBj6Djq2acVPUMZBi0Q5VaPFcrfoL9B3IlwPP5oc3fFetVdRAtsnAPUqcKLzxDGpKTcBa08ZzubX4nJRF81kjJWMhu993Aw4T/NTsLmAZv3BcLaVWrCIU8+pG7mM8Fn0HlQBHf2TOZJs6SKj3Fnytacp/AB/EaWzgb6EvRwd41MRLp8RdC2RFiSES2m HhLp1lUa lS4jePg8VleFxRFTlFi5QA5sqV67jwUOQpVgt1U2OutOI6joeA6G60/ijy5nqfvp1FHEQvdBFRYNZ/Fx3kVMCRLfEEA1D9PovyxG+930xe+yQCO7DfXajm0vaLd/PbPCSQ4nPL1NxdGR+Xpwo/sPcp4EWsZRA9NqVYqkf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett wrote: > If an invalidated maple state is encountered during write, reset the > maple state to MAS_START. This will result in a re-walk of the tree to > the correct location for the write. > > Link: https://lore.kernel.org/all/20230107020126.1627-1-sj@kernel.org/ > Reported-by: SeongJae Park > Signed-off-by: Liam R. Howlett Tested-by: SeongJae Park I confirmed this patch fixes the boot failure issue. Nevertheless, the 'make install' issue on my system is still not fixed. Thanks, SJ > --- > lib/maple_tree.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 14cff87cf058..59c4879ac714 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -5620,6 +5620,9 @@ static inline void mte_destroy_walk(struct maple_enode *enode, > > static void mas_wr_store_setup(struct ma_wr_state *wr_mas) > { > + if (unlikely(mas_is_paused(wr_mas->mas))) > + mas_reset(wr_mas->mas); > + > if (!mas_is_start(wr_mas->mas)) { > if (mas_is_none(wr_mas->mas)) { > mas_reset(wr_mas->mas); > -- > 2.35.1 >