* [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy()
@ 2023-01-09 11:46 yang.yang29
2023-01-09 18:30 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2023-01-09 11:46 UTC (permalink / raw)
To: sj; +Cc: akpm, damon, linux-mm, linux-kernel, xu.panda, yang.yang29
From: Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
---
mm/damon/sysfs-schemes.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index f0dabe3e2dc0..86edca66aab1 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj,
if (!path)
return -ENOMEM;
- strncpy(path, buf, count);
- path[count] = '\0';
+ strscpy(path, buf, count + 1);
filter->memcg_path = path;
return count;
}
--
2.15.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy()
2023-01-09 11:46 [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy() yang.yang29
@ 2023-01-09 18:30 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2023-01-09 18:30 UTC (permalink / raw)
To: yang.yang29; +Cc: sj, akpm, damon, linux-mm, linux-kernel, xu.panda
Hello Xu,
Thank you for this patch.
On Mon, 9 Jan 2023 19:46:55 +0800 (CST) <yang.yang29@zte.com.cn> wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/sysfs-schemes.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
> index f0dabe3e2dc0..86edca66aab1 100644
> --- a/mm/damon/sysfs-schemes.c
> +++ b/mm/damon/sysfs-schemes.c
> @@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj,
> if (!path)
> return -ENOMEM;
>
> - strncpy(path, buf, count);
> - path[count] = '\0';
> + strscpy(path, buf, count + 1);
> filter->memcg_path = path;
> return count;
> }
> --
> 2.15.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-09 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 11:46 [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy() yang.yang29
2023-01-09 18:30 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox