From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4741DC54EBD for ; Mon, 9 Jan 2023 18:30:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7E108E0003; Mon, 9 Jan 2023 13:30:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2B668E0001; Mon, 9 Jan 2023 13:30:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91A328E0003; Mon, 9 Jan 2023 13:30:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8445D8E0001 for ; Mon, 9 Jan 2023 13:30:35 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 56C4AAAF35 for ; Mon, 9 Jan 2023 18:30:35 +0000 (UTC) X-FDA: 80336101230.13.D7F5303 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 0F1D12000D for ; Mon, 9 Jan 2023 18:30:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ekvh4iIs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673289032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Y6EWm8R0UHPXhm0X/WKB274TniC72HXOsdghwIdvhc=; b=Rluoj9ghc0MUEt4rFJVPMRi2j7umIPmfjoVkLbDMpNaHVooFypiGzfoAsXpFV+83NMq1Zh dGK+TfIRa9nAVfH73WREB+JT3Lgreg3AX3Obu3gi93MLik9enyiLVEyVanaJ9JlKtUashL /zcHMQeSTxKud/3eHr2L9dZOI7utgUs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ekvh4iIs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673289032; a=rsa-sha256; cv=none; b=06Sg1+IMr690ZhE19DkPhkcpvJvSAKt1F3VvVsnml/CR7hyavUDEsvdipOeKlKly6UrJCg PduZZCpB0ORRMFLzFO0I8QSyTDmZQB122nzr395WgHpTWrcdxGGhqRD3UIXQilPavH3oc4 FvrqvYXAcG9DGi7sdgmJHzJtMzpNaIc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 70A77B80EE4; Mon, 9 Jan 2023 18:30:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8720BC433EF; Mon, 9 Jan 2023 18:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673289029; bh=HQCfjExHsVNbVU5V07LRXzsNiZRcHQX4rgcNmgWNn+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ekvh4iIsqIQ6GVoHVm4thN3+73pRDwghhkwnJMdooRgauK2v8ypGCA8euo1Hdwuy+ odwUC+onI9Vz3U5pqKaxD7TfvgPVoStViH1Aj8MXlJAjPvHyAaMbCegJ/neqtzAkQX DC2nPYGcYA4MZG6QNROSn+xKL+5wn3d12jFlsNOZM9TKviXEiyDt9qj3/jAVYciPH9 rFu+UUDJMewoERsuNkRS9z7TcDyHXfCBrwI4XLHtz/8SnZk9u+JkSaEXUJWJqcRCtU tE/zEAmdovsr4vYJLvseGqVf1JKFK92T6sHu79sj3d9nIeSV2UZVKG2KkDFVfC5P1F Ft9kUMud2Qvdg== From: SeongJae Park To: yang.yang29@zte.com.cn Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xu.panda@zte.com.cn Subject: Re: [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy() Date: Mon, 9 Jan 2023 18:30:26 +0000 Message-Id: <20230109183026.157393-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202301091946553770006@zte.com.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0F1D12000D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 7w5bsab54ceks7pgzoyqrr6xfeexaa65 X-HE-Tag: 1673289031-637363 X-HE-Meta: U2FsdGVkX19jSkmOBTwfm8/WYJErB9a/7NvzYS+RDP+OIt2zbFwGmsEKpuHLHcsJoYQgSmNpHir9mE87o4G2uve6T9dUKeTQduu279kS61lyfsSzBS6FoE0g1rtIwP4bL2hFRGJNpqrmWZmPvM71vmi283BasynJQofVkEb4ejTWP4iBNfPJEsU3/LN6NVfNfR4gww5TEpJM6tZS6jMVjQhni6fK5HIctxJLXQFvTSPe5CEH5VbBzQ/EvVR/3ttTKD5n13NzP2DcJKCdQnVlvkZg5vauuj4j/YE1z7p+QloSpMAhJ29V56s1w7c33pKdgdrDaOm1Cu4yvbdFmTnDB/LNeZuKfdqSyolIZPt4Xb6cLvrYzd+VlAabKx88gNLXB2ivZAzozNco8MLkrmcO3eg0Dfn8Fz3S8vPHZC1ygDq9hfhqjdg1PgyoRHb8DOMsj2KxLZFA2iOrIqtlGpAxl3U3UqGkMRzK4rDsVb4YHebhCfPoweo/LXcBQXdtS6XGPObKKb9zlT7P36E6zk4lYkeFsmCCrcZ0z+gBI89eqiWBFNtNvgD9O074dALhus9aJ0vL8wkr+Krw+2QjsTCLXArcuPZAg3MfoPmRd0VqO1ru88Ju1CFDJ3d4ebE/QTyZwzqkGo9SDhwa95iHv3EuofnM4wcAAjAiEZrM74dY4o2+DdJfuw4gzXlpJnPSoORfBy4hjKOfTDE8PV/yigyzElCnsha7fijgyfJr+alAkmAPKCsyjmPjd5c/mFYpLqHTENrVNvulNS2H6gtCHNudN1SWyBVodRKpqp+8AHWE8ZQyDHIFe9xGBcGEWHu9N9z3ehe0Gwcuattf5L2xN4PKuoUbffdCiFrxNuwjT6HEVesi69hOYFnjyAV971K64VhjvRSpOlpv5mZUZVb4XcPL12cJI9Xbrvi2SU7k4SYZCppnP05IalZcOhUrkWwmA1hioLR5M7SXOofyUrc/Y8l wnF+oyAm H4DV0aPVJ93oHvAwhlPSUOF/n/RrpzZPQ08/42GURCA03/IH/n4lhmOfKkQt6uKLUWfvm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Xu, Thank you for this patch. On Mon, 9 Jan 2023 19:46:55 +0800 (CST) wrote: > From: Xu Panda > > The implementation of strscpy() is more robust and safer. > That's now the recommended way to copy NUL-terminated strings. > > Signed-off-by: Xu Panda > Signed-off-by: Yang Yang Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs-schemes.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index f0dabe3e2dc0..86edca66aab1 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj, > if (!path) > return -ENOMEM; > > - strncpy(path, buf, count); > - path[count] = '\0'; > + strscpy(path, buf, count + 1); > filter->memcg_path = path; > return count; > } > -- > 2.15.2