From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF6DC5479D for ; Mon, 9 Jan 2023 17:03:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1E858E0007; Mon, 9 Jan 2023 12:03:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7A18E0001; Mon, 9 Jan 2023 12:03:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821618E0007; Mon, 9 Jan 2023 12:03:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 744D78E0001 for ; Mon, 9 Jan 2023 12:03:46 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2C604AAEE7 for ; Mon, 9 Jan 2023 17:03:46 +0000 (UTC) X-FDA: 80335882452.24.04FD088 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 05BADC0031 for ; Mon, 9 Jan 2023 17:03:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QkYv4aUK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tdnpLblf; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673283823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uVmmyHC2Ssr+zx9dA/TPpe6nT2qb9V4pzC/Myf+9t60=; b=aT19JyVg8LvMgXEVp0kNWLmwJYlHPYPTPxrGssP5IKZP1P1xBmLTR+lKdDtVvyEWrFnoCf T7Mmr4N1Be+llD0VhFE51uBeJ98ewa/HKRZXzDM3IaR1LJSwnAt831gYSZpYuM42IsXeg4 mowgcnHpFOdnbUvyy4K5qxn+eTcpZKw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QkYv4aUK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tdnpLblf; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673283823; a=rsa-sha256; cv=none; b=qW7j16FwJZWd7CmOKQ7o7EyBMhMA6Jll1823f5RA1TOwcBIdzOsKXKcUOr9aFzW+vJlvzv PUjBBwZu/ZDHOvikazYB2to/apgoMwxbCrEvYeQUb39BNr69UIO4xMR49CaalN/ouZNEWW 9MkNgd4aY/XlnXuUFe23gDkMftDE0A4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 18BB01FE65; Mon, 9 Jan 2023 17:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673283821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uVmmyHC2Ssr+zx9dA/TPpe6nT2qb9V4pzC/Myf+9t60=; b=QkYv4aUKGJ76GDlIUsX9im95mOqzYiwom90V2EDMZ1guLuNLcFfh48IN3G0yoVYjp2vCwY FduqnCISStQRMWi0qInfa6E9c+LEBqvbeejMt01w/4TmPTcJL7hJEu147k2cHqKAG2JdYK ccPdLNsia7DeM1Mf9UHFiLD97ofvFoI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673283821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uVmmyHC2Ssr+zx9dA/TPpe6nT2qb9V4pzC/Myf+9t60=; b=tdnpLblfvKPQhFhRVgTdsKRz4lLQCddch2je6NGSKR6Va5Fc3eHdnV6vlNB9C4r0omorSS Xomtp1YWRUEdx5Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0808A134AD; Mon, 9 Jan 2023 17:03:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ULXwAe1IvGMICQAAMHmgww (envelope-from ); Mon, 09 Jan 2023 17:03:41 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6EE40A0749; Mon, 9 Jan 2023 18:03:40 +0100 (CET) Date: Mon, 9 Jan 2023 18:03:40 +0100 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/7] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Message-ID: <20230109170340.quwwjkte6c467vfp@quack3> References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230108165645.381077-7-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 05BADC0031 X-Stat-Signature: tdtm85rxjkjpgtxwye74rqn5rkhhagy4 X-HE-Tag: 1673283822-899816 X-HE-Meta: U2FsdGVkX1+kZIcCepY/aSJMI8QyoyGbQUCGOodMqhFLUWh6JaLdbnE+zrlr4Hs2gAeiaSFWVVPfDncinkz88dewhSKnPfJuz1CMQX3Z4oWC6LlfBotCGR2d5eKjuTW7YRGWCd/F9wSxc4e2QGzZRCcYhDkUigsKSZ5tDjnRV/uMJxfXfjqpl+nGhoGC62bQFVMiE4yCLney7tQnS/hanKrJ2JMbe8JkWfZDryipiG94uaC3kDPq/Sejo2YNH9FI7k9DTfcPeH9WZEoUwPPc/pS/PfoAAi1supZnXku3ROmRkLtAzJ3U06KMCDQddgmsXyAuSFIs+2TrOvHMd8CXNd6K7B5eeSnzd03Gz6OcSWe1bJ7RUHdUQABgTsoBhRSh/tfs8Dst+6Sx5KabmB0hgj3bDpAwFua0DzkSQmj5uLvnWhmaDPqv5Yc+9IHiMp95NFLru2G2iaucOttL/DPE03id3e7B6XeJIyCoVtiU9pEgeF6lQ8S+IZE6jfyD34DnWiTh7MZw6mpxNIFfIcS61kTbAeVDfu9e0etyovIJZYY9s1SE3XFUstDM5f1rEQh9GoId8xFoHfHFeRhWqU6N+xvjtDAByw9AgYH9U8DZk70fX/4hx1Jc2QhPgZh5klTxjPx1ms4bYxFAR5Xh4B7B39Wkly74IHxL9Mn0aikZ/bkuHq4rINlE2FHlfSurIaSravHWqZdt7DupQA8NxljS5MqHB8zIt7/HO9mPyaSjApLkQdjJXZviXhtS03ZZYpHeYRpDQD3MeoDKWq4zQaWBFOYmi4JJMAcBROp3lV6JiojQy7gEvCSX39FcyVmzL5dHy9wjZgIckQIj+o9BnLtnBuvQYvI6TZMACXNps49btUa2lSAKfc9gkt3Og5UsIwbbjOdmaT5UAndUD39BEbccQjyc5BCRZtKP8UDIdQN9AJfoIGJ7Rjb9n02mh1JF0CO2YeasQIGDL10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 08-01-23 17:56:44, Christoph Hellwig wrote: > Use filemap_write_and_wait_range to write back the range of the dirty > page instead of write_one_page in preparation of removing write_one_page > and eventually ->writepage. > > Signed-off-by: Christoph Hellwig Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ocfs2/refcounttree.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c > index 623db358b1efa8..4a73405962ec4f 100644 > --- a/fs/ocfs2/refcounttree.c > +++ b/fs/ocfs2/refcounttree.c > @@ -2952,10 +2952,11 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle, > */ > if (PAGE_SIZE <= OCFS2_SB(sb)->s_clustersize) { > if (PageDirty(page)) { > - /* > - * write_on_page will unlock the page on return > - */ > - ret = write_one_page(page); > + unlock_page(page); > + put_page(page); > + > + ret = filemap_write_and_wait_range(mapping, > + offset, map_end - 1); > goto retry; > } > } > -- > 2.35.1 > -- Jan Kara SUSE Labs, CR