From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16684C54EBD for ; Mon, 9 Jan 2023 23:15:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A41408E0003; Mon, 9 Jan 2023 18:15:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F1088E0001; Mon, 9 Jan 2023 18:15:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E0EA8E0003; Mon, 9 Jan 2023 18:15:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C4008E0001 for ; Mon, 9 Jan 2023 18:15:17 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E360ABDCE for ; Mon, 9 Jan 2023 23:15:17 +0000 (UTC) X-FDA: 80336818674.02.F9935F6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id B806620011 for ; Mon, 9 Jan 2023 23:15:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1FiPfp+Z; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673306115; a=rsa-sha256; cv=none; b=Yx40bhhKi5pGwK30OE+i2vnsMx4bNpb4FSAvlCwuvSzrn7G6sNtvZWiiZMM18jKs8ERKz2 QpiojG11ULnfOvg74wBL3PkHDWqpjqJN6pFzx6g/+I61zOyh9rn1TX68prqCoIZEcHjuvl zoxGJOXIxjcqYKxNrRxLeyCRl4uvYtU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1FiPfp+Z; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673306115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wRvGINV3YDgDOcCTWNPeRJAv4hPykTP7EE8qmzyR2BA=; b=C+ZeVA15P08LTy9CjcQrGwD0qd9vnFi7xU4cIhHuDsWQs7QpnTUu7sSd3VqeafsOrHVx84 FBkkO1YjmG2W7M7GGGcdPk3gVItK+PnmeiJXHPOXk8zecnb4/sXHwW9JifAh5IdeQ4S9K7 tNAcmmvQ0NeTxNO4uxHRntCLRy6Zb5U= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D73E61488; Mon, 9 Jan 2023 23:15:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47880C433F0; Mon, 9 Jan 2023 23:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673306113; bh=tyQ2xvMTBFowxzlQRQp8kh7Rofi9QArKOmcBqhi5n6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1FiPfp+ZFUPzoXWaKkF5heaHIxX+pgDw8//YKdOV6h8u6A/rsWOpCkb2WOBFRCoOe 1C/FTMvLfFhWCp3YKrbTXWfRW4Fyu0BE5n9HqjjEIs2kadMFLWNGn4FZTZoXNY97BS MtFqmF69T228h3lkrmXFa8pkNqJNpAlwz6LvGKRs= Date: Mon, 9 Jan 2023 15:15:12 -0800 From: Andrew Morton To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "maple-tree@lists.infradead.org" , SeongJae Park Subject: Re: [PATCH] mm.h: Fix "mm: Add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma() Message-Id: <20230109151512.6d06b1d73895414885a698d7@linux-foundation.org> In-Reply-To: <20230109205300.955019-1-Liam.Howlett@oracle.com> References: <20230109205300.955019-1-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B806620011 X-Rspamd-Server: rspam01 X-Stat-Signature: bptqb89gbndfjn8igmmbcsm3ybbzh7jr X-HE-Tag: 1673306115-634656 X-HE-Meta: U2FsdGVkX1/xwnCCQvS2Are4Hk+8ZZ+jKeO+tiWDjZhWk7StMPalpIQl5ki6GAqMokcpfpg8ieflD9nN6AjRKQoGUqz0sj8eyL5V+B+KG0HZnJQtzWoJJpDk9DPlwqkS+C6OAdGs4HIfFMYQoRj6tVb/q70/5NmFC6LXdNgLMnsRFyUx45fndX1FyH6mwOSFMma14M1jbGDE12sBo2xyp/a2kODC51mE73Q8fJ5RUuSOT7gIDq6XIdg8I5QVYpmBv74gqejNLuWSu1GfsgBJy8wUnRMcXflzf+vbYZ8WlNJfy1XcNkTCPZi4wV2hFMuO+qrAsnyBuV8FbdL3x6SWhHhL/jJGejf1iuG5F1mPc4BlEJUZoeWT1MdM1CSyN6YFldEaAHSc30JAWAdMy5pTMCHrMJz5KvjLkqLSL1R8YAITR2E9BpaYRSFgqQ2phJo2mZBtBnV/nZu4IBKqdB8uVDPmWjytIGw10JTB+gfFALyUMKYLYV9h6DPyTkXxROkEjIuppXm+PdtnT59bpy7VT6HqJjGG+vKy3ybfeK45w5gwVWieatfBPkjADm8RZDk7yIfpy6WC+M6myCX6hIkOVoad242gzLE42zkFSwfGPJJmIraB7Q/uCVhGhgIXEm977nKPFvbLbUMDmZmXfmv+i6M3XTlKYvt52bhZztdkwxempSpgNtUHq9t8tZ3VtcDFmFhfC3LWVuqeWQIi9lDs9xwCnb3eHxXyJvyqbtg/9QqZXM2/83I+8bJtnPiTG53m4zA1rbpHxIOTvYdTj2MqV3fFszmqPnHhxwR99V+EymTg7MIXlFU1nYe3AW4XaQsoxcF0WKtQCs/pn/7a+ky0jPqWkuhqCJ1ULquKi5MvDOcjADYGWEphbnXNzLH5ZetJCILIduvW8U3TvSWF7EoU6u4sXQrJmYPWAylwdsT7CgnPW3wqU/F5H/0UQouFAVLB5hXyfMhfAhHbtNnc/8N S/7A5595 UbQldHseAYfqjRUA/dJn/lk4BBMUQLo+lG5syU+pfXoUXzHsjwIWKU8IJdggLXRSMMsEmA9QCQMNiW37vlfIf8sOmb2QUIkZA1DxpFXHH+dyntH7U4jIjRuqu213qX97oAefTvz0AMZNPYRNt3Yx3qSZJsdxQYWUqZ5wb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Jan 2023 20:53:22 +0000 Liam Howlett wrote: > The extern definition of __split_vma() was removed too early. Re-add it > and remove it once the users are all converted. I think I sorted this out. __split_vma() can be made static to mmap.c?