From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F868C53210 for ; Sun, 8 Jan 2023 17:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7E368E0002; Sun, 8 Jan 2023 12:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2ECF8E0001; Sun, 8 Jan 2023 12:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1E7A8E0002; Sun, 8 Jan 2023 12:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A507B8E0001 for ; Sun, 8 Jan 2023 12:08:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7F7421A0439 for ; Sun, 8 Jan 2023 17:08:29 +0000 (UTC) X-FDA: 80332265538.22.218ECD0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id CE74040012 for ; Sun, 8 Jan 2023 17:08:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673197708; a=rsa-sha256; cv=none; b=eSls4xz0CI/mMU6DKQ+pLnGhqEgj0lS2wzWOmmbg2n6PAvrPTmOjo1eqEPVQx/C1RFSpQp EEHNfiEOQJxGiqgGhA4+z6MQ1yOCYAQAr8F8JApWuPX7wTH8aQb0uD8F1RWlmHjechfNTH s78uS7qYFMSozLCdMFFgPZgkg+ynYVQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673197708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pAM+oQymY9DB2AmuRhKP/KYpxpde26C4QjAhINoWsVU=; b=QRi1tkAffF2L7mFlMCggPRNo/fBik/QwgooGb5/kZK902bxOjdy5TOjVSEXCwGxcFpL2nh JqqgGDflcH8GvO0sVv0aE3fMSEbbzy+OoBNx4Rt9ZZW6RpLGRX5xl5Yvwvk88H/eNkB08p JlO5QqCUcLBRTesXzthta2VxR01j1MI= Received: by verein.lst.de (Postfix, from userid 2407) id 88CE868D06; Sun, 8 Jan 2023 18:08:24 +0100 (CET) Date: Sun, 8 Jan 2023 18:08:24 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv3 09/12] dmapool: simplify freeing Message-ID: <20230108170824.GD19739@lst.de> References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-10-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191551.3254778-10-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: CE74040012 X-Rspamd-Server: rspam01 X-Stat-Signature: kcfr5dmh5tmm7ibshzjswerm3iszssq4 X-HE-Tag: 1673197707-511023 X-HE-Meta: U2FsdGVkX1+LhKQF9vqee6T+Bxun+fccXUFh5UdRFxErIauwAFlpoF5mtCHroyRACea4bQrdpivA6KA5RUWfI4v9/fRxXNu8runCX9SQE6X4FRkpR5DaWc8X0wBvoYriV4wljQ/v0g9v2IiOO/uxPTovTTG8qVZ7V6uLLiPFjj9P3a8l2pdkmJ9XG5H29bqol8WEHeuJ18IMUvrvwlw6l7IeKLVCoiZ/NxMS6vRMGlUyTpdZEolbYeidGapDzt1/t15DUspqh0QrXj/mXBCdwomtyq4HWJ9+DAQWby3RtUYtvB0S93b8KAArSSuTCqqLemKFBhWtKBt3eUSipzR49/Z6wTlwPhzsIbNoXNZ96ZF9+/rBEnkh0LVMk7EtCXdIVxifp52jXmbCnS38xknF1/qJf6iQtvcR2EAgKtgqwq8ZwF2nJEknM1M2b4BPGhNMUAN4UbLQ9ke7DfE9jHZKp/3jt5WTe9vqb1MPs+9E7jUov2jUddVG7QeHdDi6rK2pljYVmLv348ZSZxx+FzWi0E681fsL8DU32+R8ZDYCeU2I+fSqQK2FNWkUnfhInQWQXA4vQ9AaluBn3fG591Q18oGqp+dm1dh6qFLFqRxkBzk+u42/YpyrSuKRjt0dPBmragLi1RWZn+FIMYNMwXzudqaxGyOB8aezFE2tHURg6sOvizo7IRYYM0x4NYqEBE2FOma0ERhiDkyVcsqxacxeCQK3H5z5XALMvWunBZS5GAoeoZqm0jXJZCJhnu370W1fgxeguW8VtpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > - * DMA Pool allocator > +* DMA Pool allocator This got corrupted somehow. > + if (!is_page_busy(page)) > + dma_free_coherent(pool->dev, pool->allocation, > + page->vaddr, page->dma); > + else > dev_err(pool->dev, "%s %s, %p busy\n", __func__, > pool->name, page->vaddr); > + list_del(&page->page_list); > + kfree(page); I'm still not sure what the point of leaking the page in case it is busy vs letting KASAN and friends actually catch it, but the pure rearrangement is an improvement over the previous state, so: Reviewed-by: Christoph Hellwig