From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1331BC53210 for ; Sun, 8 Jan 2023 17:06:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8078E0002; Sun, 8 Jan 2023 12:06:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 997F08E0001; Sun, 8 Jan 2023 12:06:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8868F8E0002; Sun, 8 Jan 2023 12:06:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 753C18E0001 for ; Sun, 8 Jan 2023 12:06:54 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4048C1C5AFF for ; Sun, 8 Jan 2023 17:06:54 +0000 (UTC) X-FDA: 80332261548.23.A00ABCC Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 8888A40018 for ; Sun, 8 Jan 2023 17:06:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673197612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9h2YMlXm5opDxGyBrem6tPwFgzRqZC5SyXj3cxNyek4=; b=y949AnNQ7RRCCWo1vaHDumKMEw5SzZLIEcHYRB3funwsGJoJbam+NcCeYTlr/Pwfb3q6qA mhSUY3KgElpIqDFhxTCIWr5YUnyNX2JNzXXvjLj18x/wR3tOFnHUouNNOCINNVYaYu4k9B 7qxqNtOec+XypBUWufSPEO3eFQyaTXs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673197612; a=rsa-sha256; cv=none; b=aW8EUGzdO0TAqFd+1h3ud+f5avBUEcNWdZkPbm+2izN5bMbfHbyQ9JKk2rR/jFyGuTFacQ XFP10BgyZqv5tB/tvChyXzh7CQ8EYRXJMnCp8uD95jSbcxOxQjRQDfV72y9ijIv6h6W99+ mMg04SOSI3VhoFlbUp2AyHYFakzhnYc= Received: by verein.lst.de (Postfix, from userid 2407) id BFBD268AA6; Sun, 8 Jan 2023 18:06:48 +0100 (CET) Date: Sun, 8 Jan 2023 18:06:48 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv3 06/12] dmapool: move debug code to own functions Message-ID: <20230108170648.GB19739@lst.de> References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-7-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191551.3254778-7-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 8888A40018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cco5qh87fcrx9f1umse5zommgnamyzra X-HE-Tag: 1673197612-516553 X-HE-Meta: U2FsdGVkX1/8pzXU6Fkkr4JD8VOQd3ZfIA7lGUzk1IYK9vurWdmUFl3wjce65DgXoOhS52d227CQHM2bETcxaHZ4iYG1c18RJCmqjygLNx49C2YoErtWv9QzGjqf2nFWEIAMUQpfAh3IfO/rGhCpDBBY2CFmlabyw9DWH+RHrT1i+9v83+gA/DMyZOSt9WVlq6/d8W9uZFveIKmJpAdTDH7aYFMuVXdWrajChFTTH2ykrxsYF9aY/XyxGxkHjMTyRTk/FZa1DrHUiC+sAXZJfRV+yPZfO3g8abHaLuq6jgTgMQlmpeZ47G8tZslhOo/zWTeyCQ4BejUZM3PukszGfzW9mBhflBHq6A/KTZ8+4nfAoIPVEN1ZNZk2eZYs8nBMu4HxTABLErD2WnuGP4/oscMpJkdmBuVxkjmHTT4CQK9Am9TA20RFVLm1cad3IWEQDZUUrTegUsKxxjVmoNPRK0tLoaW3HDtO63IRgqnUYrMhsky/MazdvYq4NxM7xHqb5S4ItdXQ9LYKLNGIilBYu3IKfu1X3b7eKIABJ3Bl0e8RAcOi0z9iovfsITuQi7DD/dSJFm8ohXfrl98OzNBmnlIGNzakagDUp9XpoZDkJCK5kb/I4hN4f1zmhCXuJhe7+t3gOKwV2u+aof53LZebwzTysi7qo/+DtAA2Kc30ewLBqmXbwN1GDDmIdxyMd4eP/iFMh4Jm7z/vwTi9vodTAtqyx/pZ0j/9wZ4foIPDGuq3XG55HdAmdOesRSj9s4kLUvmeB0BIGGI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +#ifdef DMAPOOL_DEBUG I'd drop the weird tab indent carrier over from the original code here. Also any reason to not use a single big ifdef blocked instead of multiple ones? Otherwise looks good: Reviewed-by: Christoph Hellwig